This project is kinda cool. Unfortunately, the current version doesn't support the <co

works fine for me: <div class="highlight highlight-source-python notranslate posit

<a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-url="/us

Consider adding support for `extras_require` about setup-py-upgrade HOT 6 CLOSED

asottile commented on August 18, 2024

Consider adding support for `extras_require`

from setup-py-upgrade.

Comments (6)

asottile commented on August 18, 2024

works fine for me:

from setuptools import setup

setup(
    name='wat',
    extras_require={
        'foo': ['cfgv'],
        'bar': ['astpretty', 'pyupgrade'],
    },
)

$ setup-py-upgrade .
./setup.py and ./setup.cfg written!

[metadata]
name = wat

[options.extras_require]
foo = cfgv
bar =
    astpretty
    pyupgrade

from setup-py-upgrade.

wiseaidev commented on August 18, 2024

@asottile Ummm, you are right. However, it doesn't support explicitly changing this section. Take the following as an example:

from setuptools import setup

extra_requires = {
        'foo': ['cfgv'],
        'bar': ['astpretty', 'pyupgrade'],
}

extra_requires['bar'] += extra_requires['foo']

setup(
    name='wat',
    extras_require=extra_requires,
)

$ setup-py-upgrade .

Traceback (most recent call last):
  File ".venv/bin/setup-py-upgrade", line 8, in <module>
    sys.exit(main())
    visitor.visit(tree)
  File "/usr/lib/python3.8/ast.py", line 371, in visit
    return visitor(node)
  File "/usr/lib/python3.8/ast.py", line 379, in generic_visit
    self.visit(item)
  File "/usr/lib/python3.8/ast.py", line 371, in visit
    return visitor(node)
  File "/usr/lib/python3.8/ast.py", line 381, in generic_visit
    self.visit(value)
  File "/usr/lib/python3.8/ast.py", line 371, in visit
    return visitor(node)
  File ".venv/lib/python3.8/site-packages/setup_py_upgrade.py", line 128, in visit_Call
    raise NotImplementedError(f'unparsable: {kwd.arg}=')
NotImplementedError: unparsable: extras_require=