assetmantle / modules Goto Github PK

View Code? Open in Web Editor NEW

21.0 21.0 12.0 23.6 MB

License: Apache License 2.0

Makefile 0.31% Go 99.69%

modules's People

Contributors

Stargazers

Watchers

Forkers

ritesh-ranka unnati914 adinalini somewisesomeotherwise harmansohi123 namaha10 rmsharma01 nk307 muku314115 pratikbin rajika111

modules's Issues

modules/schema/data/utilities/strings_test.go/TestReadData - trim whitespaces in List data

"L|A|data,A|data1" works fine but the presence of a whitespace can cause problems
eg. "L|A|data, A|data1"

getting MetaDataError for MakeMsg

modules/modules/identities/internal/transactions/deputize/request_test.go

Line 255 in 753428b

 {"+ve", fields{testBaseReq, "9UNIA3_tulK2vRE0nSmsHKNzhDxoCBHI4z8XXfLO1FM=.pvamJCA8talIpNPu8fekxGhvFtTGtjSRhAaaKQOrHfg", "9UNIA3_tulK2vRE0nSmsHKNzhDxoCBHI4z8XXfLO1FM=.pvamJCA8talIpNPu8fekxGhvFtTGtjSRhAaaKQOrHfg", "9UNIA3_tulK2vRE0nSmsHKNzhDxoCBHI4z8XXfLO1FM=", "maintainedProperty:S|maintainedProperty", false, false, false}, newMessage(fromAccAddress, testFromID, testToID, testClassificationID, maintainedProperties, false, false, false), false}, //TODO: issue==> getting MetaDataError that is not expected 

modules/modules/identities/internal/transactions/issue/request_test.go

Line 285 in 753428b

 {"+ve", fields{testBaseReq, toAddress, "9UNIA3_tulK2vRE0nSmsHKNzhDxoCBHI4z8XXfLO1FM=.pvamJCA8talIpNPu8fekxGhvFtTGtjSRhAaaKQOrHfg", "9UNIA3_tulK2vRE0nSmsHKNzhDxoCBHI4z8XXfLO1FM=", immutableMetaPropertiesString, immutablePropertiesString, mutableMetaPropertiesString, mutablePropertiesString}, newMessage(fromAccAddress, toAccAddress, testFromID, testClassificationID, immutableMetaProperties, immutableProperties, mutableMetaProperties, mutableProperties), false}, //TODO: issue==> getting MetaDataError that is not expected 

ReadIDData() can accept all special chars

ReadIDData() can accept all special chars, there should be some kind of validation
GetID() along with other methods can accept special char.
https://github.com/AssetMantle/modules/blob/8963be3376df53e9816ecfd7ea61b667814da1d7/schema/data/base/idData.go

Wrong Transact return logic in renumerate assets tx

Line can't be hit, so can't get a success response in any case

modules/modules/assets/internal/transactions/renumerate/keeper.go

Lines 62 to 66 in a400852

 } else { 

 return newTransactionResponse(errorConstants.MetaDataError) 

 } 

 return newTransactionResponse(nil)

Panic case: decData.GenerateHashID fails when nil value passed in params

decData.go: passing nil value in decData.GenerateHashID leads to panic - check if this is expected behaviour or not, null checks can be added to avoid fatal panic

couldn't mutate list in list.go & propertyList.go

modules/schema/lists/base/list_test.go

Line 90 in ed62da9

 {"+ve", []traits.Listable{base.NewPropertyID(base.NewID("ID"), base.NewID("Data1"))}, args{[]traits.Listable{base.NewPropertyID(base.NewID("ID"), base.NewID("Data2"))}}, list{base.NewPropertyID(base.NewID("ID"), base.NewID("Data2"))}}, // TODO: fix mutate issue 

modules/schema/lists/base/propertyList_test.go

Line 159 in ed62da9

 {"+ve", fields{NewList(propertiesToListables([]properties.Property{base.NewProperty(baseIDs.NewID("a"), NewStringData("factA"))}...)...)}, args{nil}, propertyList{NewList(propertiesToListables([]properties.Property{base.NewProperty(baseIDs.NewID("a"), NewStringData("factA"))}...)...)}}, //TODO: Type & value same but not matching 

Type & value same but not matching for propertyList

modules/schema/lists/base/propertyList_test.go

Line 101 in ed62da9

 {"+ve", fields{NewList()}, []properties.Property{}}, //TODO: Type & value same but not matching 

auxiliaryRequest for case is verify.auxiliaryRequest but it should be define.auxiliaryRequest

modules/modules/classifications/auxiliaries/define/request.go

Lines 25 to 32 in a689632

 func auxiliaryRequestFromInterface(request helpers.AuxiliaryRequest) auxiliaryRequest { 

 switch value := request.(type) { 

 case auxiliaryRequest: 

 return value 

 default: 

 return auxiliaryRequest{} 

 } 

 }

modules/modules/assets/internal/transactions/deputize/keeper.go

Lines 24 to 35 in ce0fbbb

 func (transactionKeeper transactionKeeper) Transact(context sdkTypes.Context, msg sdkTypes.Msg) helpers.TransactionResponse { 

 message := messageFromInterface(msg) 

 if auxiliaryResponse := transactionKeeper.authenticateAuxiliary.GetKeeper().Help(context, authenticate.NewAuxiliaryRequest(message.From, message.FromID)); !auxiliaryResponse.IsSuccessful() { 

 return newTransactionResponse(auxiliaryResponse.GetError()) 

 } 

 if auxiliaryResponse := transactionKeeper.deputizeAuxiliary.GetKeeper().Help(context, deputize.NewAuxiliaryRequest(message.FromID, message.ToID, message.ClassificationID, message.MaintainedProperties, message.AddMaintainer, message.RemoveMaintainer, message.MutateMaintainer)); !auxiliaryResponse.IsSuccessful() { 

 return newTransactionResponse(auxiliaryResponse.GetError()) 

 } 

 return newTransactionResponse(nil) 

 }

wong compare result for metaProperty()

modules/schema/properties/base/metaProperty_test.go

Lines 118 to 119 in 127e749

 {"+ve compare with metaProperty with no Data", fields{testPropertyID, testData}, args{metaProperty{ID: base.NewPropertyID(base.NewID("ID"), base.NewID("S"))}}, 1}, //TODO: wong compare result 

 {"+ve", fields{testPropertyID, testData}, args{metaProperty{ID: base.NewPropertyID(base.NewID("ID"), base.NewID("S")), Data: NewStringData("Data2")}}, 1}, //TODO: wong compare result

json output flag is not working

JSON output flag is not working. This will be great if you can integrate this flag.

assetClient query identities identities --output json

Error:

ERROR: Cannot encode unregistered concrete type mappable.identity.

Remove() in propertylist.go not removing from List

modules/schema/lists/base/propertyList_test.go

Lines 188 to 190 in ed62da9

 {"+ve", fields{NewList(propertiesToListables([]properties.Property{base.NewProperty(baseIDs.NewID("a"), NewStringData("factA"))}...)...)}, args{nil}, propertyList{NewList(propertiesToListables([]properties.Property{base.NewProperty(baseIDs.NewID("a"), NewStringData("factA"))}...)...)}}, //TODO: Type & value same but not matching 

 {"+ve", fields{NewList()}, args{[]properties.Property{base.NewProperty(baseIDs.NewID("a"), NewStringData("factA"))}}, propertyList{NewList()}}, 

 {"+ve", fields{NewList(propertiesToListables([]properties.Property{base.NewProperty(baseIDs.NewID("a"), NewStringData("factA")), base.NewProperty(baseIDs.NewID("b"), NewStringData("factB"))}...)...)}, args{[]properties.Property{base.NewProperty(baseIDs.NewID("a"), NewStringData("factA"))}}, propertyList{NewList()}}, // TODO: raise issue

Invalid base64 string causing failure

The use of testFromID, err := baseIDs.ReadIdentityID("CBepOLnJFnKO9NEyZlSv7r80nKNZFFXRqHfnsObZ_KU=.w1D9MwUD81HdnMXMEn-RjphrPDo76MVVH3EcgA81oVQ=") is causing errors, seems like an invalid base64 string however the real input required is not known yet so can’t update it 

Initialize() in helpers panics with nil value

Initialize() for auxiliary panics for nil value

https://github.com/AssetMantle/modules/blob/8963be3376df53e9816ecfd7ea61b667814da1d7/schema/helpers/base/auxiliary.go

signature verification fails if one of the xxproperties fields are missing in request

stack overflow for nil in GetList()

modules/schema/lists/base/idList_test.go

Line 55 in ed62da9

{"+ve with nil", fields{NewList()}, []ids.ID{}}, //TODO: stackoverflow issue

incorrect IdentityID initialization with nil classificationID and immutables

baseIDs.NewIdentityID(nil, nil)
having nil classificationID and immutables, NewIdentityID panics

HashID: GenerateHashID(classificationID.Bytes(), immutables.GenerateHashID().Bytes()),

Instead we can use:
baseIDs.PrototypeIdentityID()

modules/modules/orders/internal/transactions/immediate/keeper.go

Line 138 in ca522f0

 orders.Iterate(key.NewKey(baseIDs.NewOrderID(order.GetClassificationID(), order.GetTakerOwnableID(), order.GetMakerOwnableID(), sdkTypes.SmallestDec(), baseTypes.NewHeight(-1), baseIDs.NewIdentityID(nil, nil), baseQualified.NewImmutables(baseLists.NewPropertyList()))), accumulator) 

identity present check for deputize txns

there is no present check for deputize txns

Panics for nil list in GetList in dataList

modules/schema/lists/base/dataList_test.go

Line 74 in ed62da9

 {"+ve with empty struct", fields{list{}}, []data.Data{}}, //TODO: issue Panic for nil 

NewIdentityID() panics for nil immutableProperties

	{"+ve nil", fields{classificationID, baseQualified.Immutables{PropertyList: nil}.GenerateHashID()}, append(classificationID.Bytes(), baseQualified.Immutables{PropertyList: nil}.GenerateHashID().Bytes()...)},

https://github.com/AssetMantle/modules/blob/8963be3376df53e9816ecfd7ea61b667814da1d7/modules/identities/internal/key/identityID.go

validator() in parameters panics

Panics for
{"-ve InvalidParameter", args{baseTypes.NewParameter(baseIDs.NewID(""), baseData.NewStringData(""), validator)}, errors.InvalidParameter},

https://github.com/AssetMantle/modules/blob/8963be3376df53e9816ecfd7ea61b667814da1d7/modules/assets/internal/parameters/dummy/validator.go

panics for nil in NewMetaProperty()

modules/schema/properties/base/metaProperty_test.go

Line 59 in 127e749

{"+ve for nil", args{}, metaProperty{}}, //TODO: panics for nil

modules/schema/properties/base/metaProperty_test.go

Line 117 in 127e749

 {"+ve", fields{testPropertyID, testData}, args{metaProperty{}}, 1}, //TODO: panics for nil 

modules/schema/properties/base/metaProperty_test.go

Line 120 in 127e749

{"+ve with nil", fields{}, args{metaProperty{}}, 0}, //TODO: panics for nil

modules/schema/properties/base/metaProperty_test.go

Lines 175 to 176 in 127e749

 {"+ve", fields{testPropertyID, testData}, testMetaProperty.GetData().GetID()}, //TODO: panics 

 {"+ve", fields{}, metaProperty{}.Data.GetID()}, //TODO: panics for nil

modules/schema/properties/base/metaProperty_test.go

Lines 203 to 204 in 127e749

 {"+ve", fields{testPropertyID, testData}, testData.GenerateHash()}, //TODO: panics 

 {"+ve", fields{}, metaProperty{}.Data.GenerateHash()}, //TODO: panics for nil

modules/schema/properties/base/metaProperty_test.go

Lines 259 to 260 in 127e749

 {"+ve", fields{testPropertyID, testData}, testKey}, //TODO: panics 

 {"+ve", fields{}, metaProperty{}.ID.GetKey()}, //TODO: panics

modules/schema/properties/base/metaProperty_test.go

Lines 287 to 288 in 127e749

 {"+ve", fields{testPropertyID, testData}, testData.GetType()}, //TODO: panics 

 {"+ve", fields{}, metaProperty{}.Data.GetType()}, //TODO: panics

verify keeper Type & data same but doesn't match on initialize()

modules/modules/maintainers/auxiliaries/verify/keeper_test.go

Line 121 in f1a256c

 {"+ve", fields{Mapper}, args{Mapper, testParameters, []interface{}{}}, auxiliaryKeeper{Mapper}}, // TODO: type & data same but doesn't match 

To Typecast orders after checking for nil

If Order is then nil then it will panic for nil to documents.Order typecasting

modules/modules/orders/internal/transactions/cancel/keeper.go

Lines 38 to 39 in e6d4b17

 order := orders.Get(key.NewKey(message.OrderID)).(documents.Order) 

 if order == nil {

GenerateHash() along with some other functions panics for nil value.

GenerateHash() along with some other functions panics for nil value.
https://github.com/AssetMantle/modules/blob/8963be3376df53e9816ecfd7ea61b667814da1d7/schema/data/base/listData.go

id_Compare is not properly implemented

	{"-ve", fields{"ID"}, args{NewID("ID2")}, 0},

for Above inputs it should result 1/-1 but it's passing that should not happen

https://github.com/AssetMantle/modules/blob/3e62f8cb40b10039df374e574e59a5f9518a135d/schema/ids/base/id.go

RemoveData Logic needs review

modules/schema/properties/base/metaProperty_test.go

Line 315 in 127e749

 {"+ve", fields{testPropertyID, testData}, metaProperty{ID: testPropertyID}}, //TODO: RemoveData Logic is not okay 

wong compare result in property.go

modules/schema/properties/base/property_test.go

Lines 142 to 143 in 127e749

 {"+ve compare with property with no Data", fields{testPropertyID, testData.GetID()}, args{property{ID: base.NewPropertyID(base.NewID("ID"), base.NewID("S"))}}, 1}, //TODO: wong compare result 

 {"+ve", fields{testPropertyID, testData.GetID()}, args{property{ID: base.NewPropertyID(base.NewID("ID"), base.NewID("S")), DataID: NewStringData("Data2").GetID()}}, 1}, //TODO: wong compare result

stack overflow for listData.Search()

Instead of

func (listData listData) Search(data data.Data) (int, bool) {
	return listData.Search(data)
}

It should be

func (listData listData) Search(data data.Data) (int, bool) {
	return listData.Value.Search(data)
}

at listData.go

interface conversion: base.classificationID is not ids.IdentityID: missing method GetHashID

modules/modules/maintainers/internal/mappable/maintainer.go

Lines 30 to 35 in 753428b

 func (maintainer maintainer) GetIdentityID() ids.IdentityID { 

 if property := maintainer.GetProperty(constants.IdentityIDProperty.GetID()); property != nil && property.IsMeta() { 

 return property.(properties.MetaProperty).GetData().(data.IDData).Get().(ids.IdentityID) 

 } 

 return constants.MaintainedClassificationIDProperty.GetData().(data.IDData).Get().(ids.IdentityID) 

 }

in maintainer GetIdentityID(), panics at interface conversion

xprtErrors variables can be renamed to mntlErrors

https://github.com/AssetMantle/modules/blob/0c182bb8b1e4427fe7b32d1825dfe68377098452/modules/orders/internal/transactions/make/message.go

Data & type is same but not matching in metaPropertyList.go

modules/schema/lists/utilities/metaPropertyList_test.go

Line 28 in 127e749

 {"+ve", args{"ID:S|Data,ID1:S|Data1,ID2:S|Data2"}, base.NewMetaProperties([]properties2.MetaProperty{base2.NewMetaProperty(base3.NewID("ID"), base2.NewStringData("Data")), base2.NewMetaProperty(base3.NewID("ID1"), base2.NewStringData("Data1")), base2.NewMetaProperty(base3.NewID("ID2"), base2.NewStringData("Data2"))}...), false}, //TODO: Data & type is same but not matching 

Search() in datalist & idList fails for empty struct

modules/schema/lists/base/dataList_test.go

Line 133 in ed62da9

 {"+ve with empty struct", fields{NewList(dataToListables([]data.Data{}...)...)}, args{NewStringData("Data")}, 0, false}, //TODO: fix this 

modules/schema/lists/base/idList_test.go

Line 114 in ed62da9

 {"+ve with nil", fields{NewList(idsToListables([]ids.ID{}...)...)}, args{base.NewID("ID")}, 0, false}, //TODO report issue 

Test_auxiliary_Initialize() is failing given same data on return

https://github.com/AssetMantle/modules/blob/8963be3376df53e9816ecfd7ea61b667814da1d7/schema/helpers/base/auxiliary.go

Document fails to Mutate with nil

for Test input:
{"+ve with nil mutables", fields{ClassificationID: classificationID, Immutables: testImmutables, Mutables: mutables{}}, args{[]properties.Property{testMutateProperty}}, document{ClassificationID: classificationID, Immutables: testImmutables, Mutables: mutables{}}.Mutate(testMutateProperty)},
in base/document.go

v0.2.0 mint supply error

if metaProperties := base.NewMetaPropertyList(append(message.ImmutableMetaProperties.GetList(), message.MutableMetaProperties.GetList()...)...); metaProperties.GetMetaProperty(constants.LockProperty) != nil {
split = metaProperties.GetMetaProperty(constants.LockProperty).GetData().(data.DecData).Get()
}

parameter.Validate() is failing with error "openpgp: incorrect key"

Test Data:
id, testData, _ := createTestInput(t)

	{"+ve", fields{id, testData, validator}, false},

Also For nil value it should not panic
https://github.com/AssetMantle/modules/blob/3e62f8cb40b10039df374e574e59a5f9518a135d/schema/parameters/base/parameter_test.go

Fix RandomizedGenesisState method for maintainers module

// TODO fix this
// for i := range mappableList {
// 	immutables := baseQualified.NewImmutables(baseSimulation.GenerateRandomPropertyList(simulationState.Rand))
// 	mutables := baseQualified.NewMutables(baseSimulation.GenerateRandomPropertyList(simulationState.Rand))
// 	mappableList[i] = mappable.NewMappable(base.NewMaintainer(baseIDs.NewClassificationID(immutables, mutables), immutables, mutables))
// }

transactionKeeper have nil verifyAuxiliary

if auxiliaryResponse := transactionKeeper.verifyAuxiliary.GetKeeper().Help(context, verify.NewAuxiliaryRequest(message.From, message.FromID)); !auxiliaryResponse.IsSuccessful()

modules/schema/data/utilities/strings_test.go/TestReadData - trim whitespaces in List data so that the presence of whitespace between two addresses does not cause failure

invalid Bech32 prefix; expected cosmos, got mantle

ReadListData() in listData.go file gives this error invalid Bech32 prefix; expected cosmos, got mantle
{"Test for some id", args{"mantle1x53dugvr4xvew442l9v2r5x7j8gfvged5xd3xr"}, NewListData(NewStringData("mantle1x53dugvr4xvew442l9v2r5x7j8gfvged5xd3xr")), assert.NoError},

https://github.com/AssetMantle/modules/blob/8963be3376df53e9816ecfd7ea61b667814da1d7/schema/data/base/listData.go

dataID panics for nil

modules/schema/ids/base/dataID_test.go

Line 27 in 0691026

{"+ve", args{nil}, dataID{}}, //TODO: report for panic

modules/schema/ids/base/dataID_test.go

Line 78 in 0691026

{"+ve with nil", fields{}, []byte{}}, //TODO: report for panic

modules/schema/ids/base/dataID_test.go

Line 110 in 0691026

{"+ve with nil", fields{}, args{dataID{}}, 0}, //TODO: Panics for nil

validator() returning wrong value

For data {"-ve wrong parameter Type", args{baseTypes.NewParameter(baseIDs.NewID("newID"), baseData.NewStringData("newStringData"), validator)}, false},

it should return errors.InvalidParameter instead panics
https://github.com/AssetMantle/modules/blob/8963be3376df53e9816ecfd7ea61b667814da1d7/modules/identities/internal/parameters/dummy/validator.go

modules/schema/ids/base/ test files have an import cycle, this is preventing test cases from running

panics for nil NewProperty() in property.go

modules/schema/properties/base/property_test.go

Line 59 in 127e749

{"+ve with nil", args{}, property{}}, //TODO: panics for nil

modules/schema/properties/base/property_test.go

Line 141 in 127e749

 {"+ve", fields{testPropertyID, testData.GetID()}, args{property{}}, 1}, //TODO: panics for nil 

modules/schema/properties/base/property_test.go

Line 199 in 127e749

{"+ve with nil", fields{}, nil}, //TODO: panics for nil

modules/schema/properties/base/property_test.go

Line 255 in 127e749

{"+ve with nil", fields{}, nil}, //TODO: panics for nil

modules/schema/properties/base/property_test.go

Line 283 in 127e749

{"+ve with nil", fields{}, nil}, //TODO: panics for nil

Couldn't add in idList & propertyList

modules/schema/lists/base/idList_test.go

Line 30 in ed62da9

 {"+ve for nil", fields{NewList()}, args{[]ids.ID{base.NewID("ID")}}, idList{NewList(idsToListables([]ids.ID{base.NewID("ID")}...)...)}}, //TODO: panic for nil 

modules/schema/lists/base/propertyList_test.go

Lines 76 to 77 in ed62da9

 {"+ve nil with property addition", fields{NewList(propertiesToListables([]properties.Property{}...)...)}, args{[]properties.Property{base.NewProperty(baseIDs.NewID("a"), NewStringData("factA"))}}, propertyList{NewList(propertiesToListables([]properties.Property{base.NewProperty(baseIDs.NewID("a"), NewStringData("factA")), base.NewProperty(baseIDs.NewID("b"), NewStringData("factB"))}...)...)}}, //TODO: Not being added 

 {"+ve", fields{NewList(propertiesToListables([]properties.Property{base.NewProperty(baseIDs.NewID("a"), NewStringData("factA"))}...)...)}, args{[]properties.Property{base.NewProperty(baseIDs.NewID("b"), NewStringData("factB"))}}, propertyList{NewList(propertiesToListables([]properties.Property{base.NewProperty(baseIDs.NewID("a"), NewStringData("factA")), base.NewProperty(baseIDs.NewID("b"), NewStringData("factB"))}...)...)}}, //TODO: Not being added

 {"+ve", fields{testBaseReq, testFromID.String(), testToID.String(), testClassificationID.String()}, message{testFromAccAddress, testFromID, testToID, testClassificationID}, false}, //TODO: Type & Data same but Not matching 

listData.search is not showing expected behaviour

modules/schema/data/base/listData.go

Line 29 in d67d671

func (listData listData) Search(data data.Data) (int, bool) {

For Test sample:

modules/schema/data/base/listData_test.go

Line 283 in d67d671

}

It shouldn't give 0 as the data is not available in listData
or for other test sample it should return no of occurrences then it's true but for other data it's wrong

	} else {
	return newTransactionResponse(errorConstants.MetaDataError)
	}

	return newTransactionResponse(nil)

	func auxiliaryRequestFromInterface(request helpers.AuxiliaryRequest) auxiliaryRequest {
	switch value := request.(type) {
	case auxiliaryRequest:
	return value
	default:
	return auxiliaryRequest{}
	}
	}

	func (transactionKeeper transactionKeeper) Transact(context sdkTypes.Context, msg sdkTypes.Msg) helpers.TransactionResponse {
	message := messageFromInterface(msg)
	if auxiliaryResponse := transactionKeeper.authenticateAuxiliary.GetKeeper().Help(context, authenticate.NewAuxiliaryRequest(message.From, message.FromID)); !auxiliaryResponse.IsSuccessful() {
	return newTransactionResponse(auxiliaryResponse.GetError())
	}

	if auxiliaryResponse := transactionKeeper.deputizeAuxiliary.GetKeeper().Help(context, deputize.NewAuxiliaryRequest(message.FromID, message.ToID, message.ClassificationID, message.MaintainedProperties, message.AddMaintainer, message.RemoveMaintainer, message.MutateMaintainer)); !auxiliaryResponse.IsSuccessful() {
	return newTransactionResponse(auxiliaryResponse.GetError())
	}

	return newTransactionResponse(nil)
	}

	{"+ve compare with metaProperty with no Data", fields{testPropertyID, testData}, args{metaProperty{ID: base.NewPropertyID(base.NewID("ID"), base.NewID("S"))}}, 1}, //TODO: wong compare result
	{"+ve", fields{testPropertyID, testData}, args{metaProperty{ID: base.NewPropertyID(base.NewID("ID"), base.NewID("S")), Data: NewStringData("Data2")}}, 1}, //TODO: wong compare result

	{"+ve", fields{NewList(propertiesToListables([]properties.Property{base.NewProperty(baseIDs.NewID("a"), NewStringData("factA"))}...)...)}, args{nil}, propertyList{NewList(propertiesToListables([]properties.Property{base.NewProperty(baseIDs.NewID("a"), NewStringData("factA"))}...)...)}}, //TODO: Type & value same but not matching
	{"+ve", fields{NewList()}, args{[]properties.Property{base.NewProperty(baseIDs.NewID("a"), NewStringData("factA"))}}, propertyList{NewList()}},
	{"+ve", fields{NewList(propertiesToListables([]properties.Property{base.NewProperty(baseIDs.NewID("a"), NewStringData("factA")), base.NewProperty(baseIDs.NewID("b"), NewStringData("factB"))}...)...)}, args{[]properties.Property{base.NewProperty(baseIDs.NewID("a"), NewStringData("factA"))}}, propertyList{NewList()}}, // TODO: raise issue

	{"+ve", fields{testPropertyID, testData}, testMetaProperty.GetData().GetID()}, //TODO: panics
	{"+ve", fields{}, metaProperty{}.Data.GetID()}, //TODO: panics for nil

	{"+ve", fields{testPropertyID, testData}, testKey}, //TODO: panics
	{"+ve", fields{}, metaProperty{}.ID.GetKey()}, //TODO: panics

	order := orders.Get(key.NewKey(message.OrderID)).(documents.Order)
	if order == nil {

	{"+ve compare with property with no Data", fields{testPropertyID, testData.GetID()}, args{property{ID: base.NewPropertyID(base.NewID("ID"), base.NewID("S"))}}, 1}, //TODO: wong compare result
	{"+ve", fields{testPropertyID, testData.GetID()}, args{property{ID: base.NewPropertyID(base.NewID("ID"), base.NewID("S")), DataID: NewStringData("Data2").GetID()}}, 1}, //TODO: wong compare result

	func (maintainer maintainer) GetIdentityID() ids.IdentityID {
	if property := maintainer.GetProperty(constants.IdentityIDProperty.GetID()); property != nil && property.IsMeta() {
	return property.(properties.MetaProperty).GetData().(data.IDData).Get().(ids.IdentityID)
	}
	return constants.MaintainedClassificationIDProperty.GetData().(data.IDData).Get().(ids.IdentityID)
	}

assetmantle / modules Goto Github PK

modules's People

Contributors

Stargazers

Watchers

Forkers

modules's Issues

Recommend Projects

Recommend Topics

Recommend Org