last release is broken without `lib` dir about bundler HOT 33 CLOSED

@toukirkhan please go ahead

from bundler.

@derberg can I look into this?

from bundler.

tip: you can test it locally, if your fix works by running npm publish --dry-run, if I remember the command correct 😄

if terminal will print only 👇🏼

npm notice === Tarball Contents === 
npm notice 11.4kB LICENSE     
npm notice 7.1kB  README.md   
npm notice 3.0kB  package.json
npm notice === Tarball Details === 

then it is not fixed.
it is fixed if index.js will be listed too

from bundler.

alright @derberg working on this one!!

from bundler.

@derberg am using npm publish --dry -run it only shows package.json in tarball contents, am I doing something wrong?

from bundler.

@toukirkhan can you show full log, please, and what modifications you already did

from bundler.

yeah am attaching the screenshots @derberg

from bundler.

I have changed "lib/" to "/lib"

from bundler.

also it has shown the tarball contents you mentioned above once

from bundler.

strange you see only package.json

anyway, I forgot to tell you that you need to install bundler npm i and then run npm run build to actually generate lib dir first. Publish dry run do not show lib probably because you do not have it there on a local drive

from bundler.

from bundler.

ok 🤔 , can you share, like drop the view of the directory from which you run npm publish?

from bundler.

yeah sure

from bundler.

@derberg okay I got it changed lib but it still does not show index.html

from bundler.

you mean index.js right?
can you show latest logs?

from bundler.

@derberg yeah

from bundler.

I saw that in picture your terminal says that npm run build doesn't exist. This is weirt. Are you sure bundler is the directory where you cloned the project? can you print all files you have there ls is command in UNIX, not sure windows

from bundler.

from bundler.

I saw that in picture your terminal says that npm run build doesn't exist. This is weirt. Are you sure bundler is the directory where you cloned the project? can you print all files you have there ls is command in UNIX, not sure windows

yeah sure

from bundler.

I think best would be if @toukirkhan you can open a PR, and we can check it.

from bundler.

from bundler.

I think best would be if @toukirkhan you can open a PR, and we can check it.

it won't be a great idea because it does not resolves the issue

from bundler.

@derberg i did npm run build

from bundler.

Ok, I think I know what the problem is

you do ls and other command runs from inside the node_modules where bundler is installed, and yes it shows that package is empty, which is wrong.

now please explain why in bundler directory you installed @asyncapi/bundler

what is exactly in bundler directory, main one, not bundler\none_modules\@asyncapi\bundler?

from bundler.

so if C:\Users\Lenovo\Desktop\bundler is a place where you cloned your fork

then you should do:

C:\Users\Lenovo\Desktop\bundler> npm i
C:\Users\Lenovo\Desktop\bundler> npm run build
C:\Users\Lenovo\Desktop\bundler> npm publish --dry-run

from bundler.

Ok, I think I know what the problem is

you do ls and other command runs from inside the node_modules where bundler is installed, and yes it shows that package is empty, which is wrong.

now please explain why in bundler directory you installed @asyncapi/bundler

what is exactly in bundler directory, main one, not bundler\none_modules\@asyncapi\bundler?

bundler directory is a directory in my desktop inside which I have installed the bundler

from bundler.

so if C:\Users\Lenovo\Desktop\bundler is a place where you cloned your fork

then you should do:

C:\Users\Lenovo\Desktop\bundler> npm i
C:\Users\Lenovo\Desktop\bundler> npm run build
C:\Users\Lenovo\Desktop\bundler> npm publish --dry-run

yeah finally I got this!!

from bundler.

I have run the command inside the cloned bundler repo and made a dry run and it shows this

from bundler.

now where should I make the changes?

from bundler.

here is the directory

from bundler.

yup, perfect. from your logs it looks like it is the fix we expect. go ahead and open up a PR

from bundler.

@derberg okay cool! am opnening it rn

from bundler.

🎉 This issue has been resolved in version 0.3.2 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀

from bundler.