Exception is thrown if `$ref` value is not a `string` about bundler HOT 2 CLOSED

Shani Alaluf Shamah
Can you please clarify what value are you passing to $ref, because I have tried passing to $ref in YAML

• array, YAML object, number, boolean, but all I get is

TypeError: ref.startsWith is not a function

• with absence of value (NOT '') and null I get

TypeError: Cannot read properties of null (reading 'startsWith')

• with an empty string '' the value is simply ignored (no exception thrown, execution successful)

• with ./, /, https..., function, undefined Node.js gives various errors of failing to open or fetch file.

But no TypeError: Cannot read property 'startsWith' of undefined

So for now I cannot reproduce exactly your bug, to begin fixing it, on Node.js v16.17.0 and Node.js v18.9.0.

Maciej Urbańczyk solution

function isExternalReference(ref: string): boolean {
  return typeof ref === 'string' && !ref.startsWith('#');
}

works - it makes bundler ignore any value that is not a string, thus might fix exactly your issue indirectly, so it definitely should be merged.

After this change is merged, please comment if exactly your issue was fixed.

from bundler.

User did not provide feedback, assuming issue fixed, resolved and closed.

from bundler.