http://book.agiletoolkit.org/agiletoolkit-overview/application.html

• "therefore you can have multiple applicaiton classes" - i think will be better "therefore you can have multiple applicaiton classes for one project"
• "don’t go outside of your application" - not clear. How can I go outside of my app? If it is possible we need something like "bad example", otherwise i can "go outside" accidentally and do not even know that i did it.
• "it will initialize several sub-components which call Controllers" - not clear. Maybe lists of sub-components for each type of App will be good to have here?
• It is good to have example of Frontend.php file with db connection, jQueryUI and so on after "it will initialize several sub..." paragraph.
• "ApiFrontend will automatically initialize Logger() which makes error logging more bearable." - is any information how to use this logger?
• "Layouts A Layout is a region in the shared template". Typo?
• "Layouts A Layout is a region in the shared template (shared.html), which is parsed by the API class. If the region is defined, then a corresponding layout function is called." - i think this part can be extended. Don't know how yet.
• "most significant layout element is “Content”" - why layout, not template? And why element, not spot? Content is required spot in template.
• - old style spot

http://book.agiletoolkit.org/agiletoolkit-overview/model.html

• The Dataset - i think this part should be rewrited.
• setSource - Primary Source - require some examples.
• addCache - Caches - same, require some examples. Much more :)
• Model data and methods. "In a typical ORM implementation, model data is stored in model properties while reserving all the property names beginning with underscore. Agile Toolkit stores model data as array in a single property called “data”." - add more low level explanation or stay on high level only. I think description set(), get() functions is more then enough at this point, most of the users will never ask you how it works behind the curtains.
• class Model_User doesn't have public $table property.
• "Please note that model is defined using PHP language and it’s always defined as a class." - i get confused with this phrase :) really :)
• * you must define some fields* - how to define fields? Short example required here.
• $m['name']='John';$m['daily_salary']=150; - why this written in one line?
• * Extend “User” model to create “Manager” model.* - example might be very useful here.
• Loading and Saving models - pretty good!
• Relational Models (SQL) - this is h3 element. Everything "described below" has h2 element for header. Not clear what exactly is "described below".

http://book.agiletoolkit.org/agiletoolkit-overview/view.html
https://github.com/atk4/book/blob/master/en/agiletoolkit-overview/view.rst#helloworld-view

$this->add('HelloWorld', ['message' => 'Hello, Agile Toolkit']);

This example will not work because $message is private.

private $message = 'Hello, World';  

http://book.agiletoolkit.org/agiletoolkit-overview/view.html

I don't find examples which are close to "every day" programming workflow

• Example with function defaultTemplate()
• complete example with $this->add('MyView') which contains MyView class, template for this class and resulting view (screenshot from browser while we have no embed Snippets). The good example is here where code and template located in different tabs, and result is under them.
• $poem->setModel('Book')->tryLoadAny(); - this part needs more explanation. I think beginners will not understand how to use model with view, though it is very important feature of AgileToolkit
• Composite Views - i don't see difference between views added to other views and composite view. It needs to be described more clear if there is a difference or add example with "user-created" Composite Views. Maybe "You can create Composite Views by adding one view to another $myView->add('MyOtherView')" is enough.
• View with Template - we have two ways to set template to View. Only one is described. Do we really want user to go somewhere else from this page to know second way? I think both ways should be described on this page

Issue by romaninsh
Sunday Jun 08, 2014 at 13:52 GMT
Originally opened as atk4/atk4#551

Cloning Objects

When you use the PHP clone statement the whole object is duplicated
into an independent variable.

$book_archive = clone $book;

$book_archive->addCondition('is_archive',true);
$book->addCondition('is_archive',false);

$this->add('Grid')->setModel('book');
$this->add('Grid')->setModel('book_archive');

This code will display two grids - one for regular books and another for
archived. Because objects are cloned, adding conditions to one will not
affect the other.

But be careful – there's a gotcha when you clone hooks.

To continue the example above, say you have a hook inside Model_Book
to check a value before saving:

// In Model_Book

function init()
{
    parent::init();

    $this->addField('review');
    $this->hasOne('Author');

    $this->addHook('beforeSave', array($this,'check'));
}

function check($m)
{
    if (strlen($this['review']) < 100) {
        throw $this->exception('Review is too short');
    }
}

After cloning, $this will be referencing the wrong object! Saving
our Model with $book_archive->save() will call $book->check(),
and $this will validate the value of $book instead of
$book_archive.

You can avoid this problem if you use the Model passed in as $m
instead of $this inside a hook. In the above example, $m will
point to $book_archive.

Issue by johndobsonRoR
Tuesday Aug 26, 2014 at 21:59 GMT
Originally opened as atk4/atk4#573

There is a CRUD issue with the first example in the atk book, the update option used for a basic edit or checking a book out as borrowed fails to rewrite the row after edit (including ID) using the 'save' button, leaving the table in an unusable state. This raises another issue, I can't locate the database where the books are stored in order to 'drop' the table and start again - the example doesn't appear to reference the "config-default.php" file in the admin directory, the only way I can drop the database is to reboot my machine.

Hi,

When using atk4.2 before, I was really helped alot with being able to browse the Class and API reference documentation generated by doxygen.

since the new documentation/book went online this seems to be unavailable in its old location.
Is there a new link for this, or is that not available anymore for atk 4.3?

http://book.agiletoolkit.org/model/sql.html

table_alias needs to be there and it needs to be public property.