Gutter width does not increase when icons are shown about git-diff HOT 6 CLOSED

Are you using the react editor?

On Thu, May 8, 2014 at 10:31 PM, rawrkats [email protected] wrote:

The gutter does not have padding on the right of the line numbers when
icons are shown. Each number is flush to the right of the editor/code body,
decreasing legibility.

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/18
.

from git-diff.

Yes. After I disabled it, it works. Thanks!

On May 8, 2014, at 9:51 PM, Ben Ogle [email protected] wrote:

Are you using the react editor?

On Thu, May 8, 2014 at 10:31 PM, rawrkats [email protected] wrote:

The gutter does not have padding on the right of the line numbers when
icons are shown. Each number is flush to the right of the editor/code body,
decreasing legibility.

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/18
.

—
Reply to this email directly or view it on GitHub.

from git-diff.

@nathansobo the icons shift the gutter elements but it looks like the width
doesn't change in the react editor.

On Friday, May 9, 2014, rawrkats [email protected] wrote:

Yes. After I disabled it, it works. Thanks!

On May 8, 2014, at 9:51 PM, Ben Ogle <[email protected]javascript:_e(%7B%7D,'cvml','[email protected]');>
wrote:

Are you using the react editor?

On Thu, May 8, 2014 at 10:31 PM, rawrkats <[email protected]javascript:_e(%7B%7D,'cvml','[email protected]');>
wrote:

The gutter does not have padding on the right of the line numbers when
icons are shown. Each number is flush to the right of the editor/code
body,
decreasing legibility.

—
Reply to this email directly or view it on GitHub<
https://github.com/atom/git-diff/issues/18>
.

—
Reply to this email directly or view it on GitHub.

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/18#issuecomment-42670310
.

from git-diff.

Damn. I am fixing the width of the gutter to allow line numbers to be absolutely positioned to optimize repaints when scrolling up. Looks like I'm going to need to find another solution to that because it's probably too fragile.

from git-diff.

@nathansobo that would be nice for visual niceness as well since the line numbers are all over the place. What if the line numbers themselves were colored instead of having a line or icon?

from git-diff.

@benogle @nathansobo This was fixed, right? Please reopen if I misunderstood.

What if the line numbers themselves were colored instead of having a line or icon?

That's an interesting idea, @eddiemonge! Personally, I'd be interested in seeing how that looks and feels.

from git-diff.