atom / git-diff Goto Github PK

[Enter steps to reproduce below:]

1. ...
2. ...

Atom Version: 0.175.0
System: Mac OS X 10.10.2
Thrown From: git-diff package, v0.28.0

Stack Trace

Uncaught TypeError: Cannot read property 'style' of undefined

At /Applications/Atom.app/Contents/Resources/app/node_modules/space-pen/lib/space-pen.js:516

TypeError: Cannot read property 'style' of undefined
  at [object Object].$.fn.isHidden (/Applications/Atom.app/Contents/Resources/app/node_modules/space-pen/lib/space-pen.js:516:20)
  at [object Object].$.fn.isVisible (/Applications/Atom.app/Contents/Resources/app/node_modules/space-pen/lib/space-pen.js:511:18)
  at GitDiffView.module.exports.GitDiffView.renderDiffs (/Users/dl1/.atom/packages/git-diff/lib/git-diff-view.coffee:109:27)
  at atom-text-editor.<anonymous> (/Users/dl1/.atom/packages/git-diff/lib/git-diff-view.coffee:1:1)
  at atom-text-editor.handler (/Applications/Atom.app/Contents/Resources/app/src/space-pen-extensions.js:112:34)
  at atom-text-editor.jQuery.event.dispatch (/Applications/Atom.app/Contents/Resources/app/node_modules/space-pen/vendor/jquery.js:4681:9)
  at atom-text-editor.elemData.handle (/Applications/Atom.app/Contents/Resources/app/node_modules/space-pen/vendor/jquery.js:4359:46)
  at CommandRegistry.module.exports.CommandRegistry.handleCommandEvent (/Applications/Atom.app/Contents/Resources/app/src/command-registry.js:243:29)
  at CommandRegistry.handleCommandEvent (/Applications/Atom.app/Contents/Resources/app/src/command-registry.js:3:61)
  at CommandRegistry.module.exports.CommandRegistry.dispatch (/Applications/Atom.app/Contents/Resources/app/src/command-registry.js:156:19)
  at TextEditorView.jQuery.fn.trigger (/Applications/Atom.app/Contents/Resources/app/src/space-pen-extensions.js:64:23)
  at [object Object].module.exports.React.createClass.componentDidUpdate (/Applications/Atom.app/Contents/Resources/app/src/text-editor-component.js:273:54)
  at CallbackQueue.mixInto.notifyAll (/Applications/Atom.app/Contents/Resources/app/node_modules/react-atom-fork/lib/CallbackQueue.js:75:22)
  at ReactReconcileTransaction.ON_DOM_READY_QUEUEING.close (/Applications/Atom.app/Contents/Resources/app/node_modules/react-atom-fork/lib/ReactReconcileTransaction.js:88:26)
  at ReactReconcileTransaction.Mixin.closeAll (/Applications/Atom.app/Contents/Resources/app/node_modules/react-atom-fork/lib/Transaction.js:214:42)
  at ReactReconcileTransaction.Mixin.perform (/Applications/Atom.app/Contents/Resources/app/node_modules/react-atom-fork/lib/Transaction.js:155:16)
  at ReactUpdatesFlushTransaction.Mixin.perform (/Applications/Atom.app/Contents/Resources/app/node_modules/react-atom-fork/lib/Transaction.js:141:20)
  at ReactUpdatesFlushTransaction.mixInto.perform (/Applications/Atom.app/Contents/Resources/app/node_modules/react-atom-fork/lib/ReactUpdates.js:98:38)
  at Object.flushBatchedUpdates (/Applications/Atom.app/Contents/Resources/app/node_modules/react-atom-fork/lib/ReactUpdates.js:176:19)
  at ReactDefaultBatchingStrategyTransaction.Mixin.closeAll (/Applications/Atom.app/Contents/Resources/app/node_modules/react-atom-fork/lib/Transaction.js:214:42)
  at ReactDefaultBatchingStrategyTransaction.Mixin.perform (/Applications/Atom.app/Contents/Resources/app/node_modules/react-atom-fork/lib/Transaction.js:155:16)
  at Object.ReactDefaultBatchingStrategy.batchedUpdates (/Applications/Atom.app/Contents/Resources/app/node_modules/react-atom-fork/lib/ReactDefaultBatchingStrategy.js:70:19)
  at Object.enqueueUpdate (/Applications/Atom.app/Contents/Resources/app/node_modules/react-atom-fork/lib/ReactUpdates.js:209:22)
  at [object Object].ReactCompositeComponentMixin.replaceState (/Applications/Atom.app/Contents/Resources/app/node_modules/react-atom-fork/lib/ReactCompositeComponent.js:878:20)
  at [object Object].ReactCompositeComponentMixin.setState (/Applications/Atom.app/Contents/Resources/app/node_modules/react-atom-fork/lib/ReactCompositeComponent.js:850:10)
  at [object Object].module.exports.React.createClass.focused (/Applications/Atom.app/Contents/Resources/app/src/text-editor-component.js:619:14)
  at [object Object].boundMethod [as focused] (/Applications/Atom.app/Contents/Resources/app/node_modules/react-atom-fork/lib/ReactCompositeComponent.js:1295:21)
  at atom-text-editor.TextEditorElement.focused (/Applications/Atom.app/Contents/Resources/app/src/text-editor-element.js:199:55)

Commands

     -7:53.2 core:save-as (atom-text-editor.editor)
     -6:30.7 grammar-selector:show (atom-text-editor.editor)
     -6:28.4 editor:consolidate-selections (atom-text-editor.editor.mini)
     -6:28.4 core:cancel (atom-text-editor.editor.mini)
 34x -6:26.1 core:backspace (atom-text-editor.editor)
  2x -5:55.3 editor:newline (atom-text-editor.editor)
  3x -5:45.9 core:backspace (atom-text-editor.editor)
  2x -5:20.9 core:move-left (atom-text-editor.editor)
     -5:19.2 core:move-right (atom-text-editor.editor)
 33x -5:17.2 core:backspace (atom-text-editor.editor)
     -4:39.2 core:select-all (atom-text-editor.editor)
     -4:38.0 core:copy (atom-text-editor.editor)
     -0:00.0 window:install-shell-commands (atom-workspace.workspace.scrollbars-visible-when-scrolling.theme-atom-dark-syntax.theme-atom-light-ui)

Config

{
  "core": {
    "themes": [
      "atom-light-ui",
      "atom-dark-syntax"
    ]
  }
}

Installed Packages

# User
git-diff, v0.28.0

# Dev
No dev packages

/cc @atom/core

For some reason all css fils in my project show as changed; even if git status shows nothing new/changed.
Changing focus, refreshing the file or restarting Atom do not fix this.

What can be done to fix this?

The gutter does not have padding on the right of the line numbers when icons are shown. Each number is flush to the right of the editor/code body, decreasing legibility.

For the most part I find the lines quite distracting however every now and then I would find them very useful and thus it would be useful if there was a quick way to enable/disable them. At the moment to do this I would have to go into Settings > Packages and disable/enable the package?

git-diff is not proving any feedback, when the parent directory of the repository is opened in editor.

Please find the attached image for
❌actual behavior highlighted in red
✅ expected behavior highlighted in green

When the first line of a file is removed, the red 'removed' marker shows below line 1, rather than above it.

If I open folder in Atom, then create a git repository in folder/subfolder/.git and modify folder/subfolder/some-file, the package doesn't recognise the diff. Diffs are only recognised when I open folder/subfolder (i.e. when .git resides at the root of the currently opened folder).

Display a list of the first line and line number of all diff hunks in the active editor, allow you to jump to an specific hunk.

First of all, I've just started using Atom, so I'm not sure if this is possible or if it is within the scope of intended use for the gutter. If it is possible and desired behavior, I might try to go ahead and fork and pull it in when I get some free time.

Today I was looking for my change in a large file, and I tried clicking the "+1" in the corner of my atom window (the gutter icon), but it didn't work. So I checked the plugin preferences and saw that there was a keyboard shortcut to scroll to next changed block. I used that and it worked fine. Still, it would be intuitive to just be able to click on the gutter icon and scroll straight to the next change, or perhaps right click to get the three options (scroll to next, scroll to previous, show diff list) along with their keyboard shortcuts displayed next to them in a context menu.

Just posting here to see if this is possible, and if it would be desireable behavior.

I opened a folder in Atom that has git-diff installed. This folder has several repos. Git diff appears to not be working, as if it was an untracked file.

I think the way git-diff for atom handles gutter marks is beautiful, though the red gutter marks for "removed" lines is a bit confusing. Instead, I think gutter marks for removed lines should point between the surrounding lines where line(s) in question used to exist. See screenshot of GitGutter for Sublime Text. I think this is easier to understand than highlighting the gutter of a nearby existing line. Thank you for considering this suggestion.

Currently the gutter seems only to be working if the project root is a git repo. Please also support non-repo-root-folders with nested repos. I'm using this constellation at work because we have notes and other files which should not be in the (e.g. customer) repos.

Hi

I really like this package but it is a really pain when you are using the Swiss-German (French, etc) keyboard layout because "alt-g" is mapped to "@". The issue is that you always have to type "alt-g" twice to get the "@" and this is not really usable IMHO:

It is possible to change the keybindings or at least give an option to override it or disable the mapping for this keybinding?

I have a problem that's probably my own: it doesn't repro in safe mode, so it must be due to some package I have installed.

The problem is that the green, yellow and red indicators do not appear in the gutter when I have Shadow DOM enabled. Inspecting the DOM, I see that the gutter still has .git-line-added on it. But there's no CSS rule that adds the border. Here's the CSS that gets applied in normal mode:

In safe mode, there is another rule that adds a green border.

I could understand if a package was overriding this rule, but somehow something I have installed seems to be preventing the rule from even being applied to the document. Any tips on debugging this?

I already tried disabling all my packages, but it didn't help.

In the GIF below, I toggle the line numbers off and back on again. Notice that before I toggle them -- the git diff icons are shown, and after -- they're not. (I had to move the cursor after toggling the line numbers due to another issue.) Happens only with the react editor component.

cc @benogle @nathansobo

I'm not sure if this is intended behavior or not, but it isn't what I was expecting so I thought I'd post an issue. Apologies if this is a non-issue!

When I take code such as:

def dummy_method
end

And change it to:

def dummy_method(num)
  num.times do |i|
    puts "#{i} dummy"
  end
end

Instead of identifying one modified line and three new lines, the gutter indicates I have four modified lines.

If I instead change the code to:

def dummy_method
  10.times do |i|
    puts "#{i} dummy"
  end
end

The gutter displays three new lines. It appears modifying the function definition in this case triggers the difference.

I'm using the Icons setting at the moment.

• Unchecking and rechecking makes it work.
• Works on reload of editor when there is a addition / change.

git allows you to create a .git file with the contents git-dir: /path/to/repo (see here).

The sidebar file-highlighting and the gutter line-highlighting doesn't work with this repository layout.

[Enter steps to reproduce below:]

just started atom after upgrade

Atom Version: 0.183.0
System: linux 3.18.6-1-ARCH
Thrown From: git-diff package, v0.53.0

Stack Trace

Uncaught Error: Repository has been destroyed

At /usr/share/atom/resources/app/src/git-repository.js:394

Error: Repository has been destroyed
  at GitRepository.module.exports.GitRepository.getRepo (/usr/share/atom/resources/app/src/git-repository.js:394:15)
  at GitRepository.module.exports.GitRepository.getLineDiffs (/usr/share/atom/resources/app/src/git-repository.js:309:19)
  at GitDiffView.module.exports.GitDiffView.updateDiffs (/usr/share/atom/resources/app/node_modules/git-diff/lib/git-diff-view.js:151:99)
  at /usr/share/atom/resources/app/node_modules/git-diff/lib/git-diff-view.js:3:61
  at Emitter.module.exports.Emitter.emit (/usr/share/atom/resources/app/node_modules/event-kit/lib/emitter.js:82:11)
  at /usr/share/atom/resources/app/node_modules/text-buffer/lib/text-buffer.js:1151:25

Commands

Config

{
  "core": {
    "excludeVcsIgnoredPaths": false,
    "disabledPackages": [
      "welcome",
      "metrics",
      "autocomplete",
      "incremental-search",
      "Tern",
      "grunt-runner",
      "tree-view-open-files",
      "tree-view-breadcrumb",
      "atomatigit",
      "symbols-view",
      "themed-settings",
      "spell-check",
      "linter-scspell",
      "symbol-gen"
    ],
    "themes": [
      "one-dark-ui",
      "solarized-dark-syntax"
    ],
    "projectHome": "/home/despairblue/vcs/git/",
    "destroyEmptyPanes": false,
    "autoHideMenuBar": true
  }
}

Installed Packages

# User
atom-color-highlight, v3.0.8
atom-jasmine, v0.5.0
atom-ternjs, v0.4.18
autocomplete-paths, v1.0.2
autocomplete-plus, v2.1.6
autocomplete-snippets, v1.0.1
block-travel, v1.0.2
bug-report, v0.6.1
color-picker, v1.4.4
compare-files, v0.4.1
docblockr, v0.5.8
file-icons, v1.4.11
filetype-color, v0.1.4
git-log, v0.2.0
go-plus, v3.2.2
grammar-token-limit, v0.1.1
highlight-line, v0.9.3
highlight-selected, v0.9.0
indentation-indicator, v0.4.1
javascript-snippets, v1.0.0
keybinding-cheatsheet, v0.0.7
linter, v0.11.1
linter-coffeelint, v0.1.7
linter-htmlhint, v0.0.8
linter-js-yaml, v0.1.3
linter-jshint, v0.1.0
linter-lua, v0.1.3
linter-puppet-lint, v0.2.8
linter-shellcheck, v0.0.6
minimap, v4.1.4
minimap-color-highlight, v4.0.0
minimap-find-and-replace, v3.1.0
minimap-git-diff, v3.1.1
minimap-highlight-selected, v4.0.0
neon-cursor, v0.2.0
neon-selection, v0.3.2
open-last-project, v0.2.2
project-manager, v1.15.5
regex-railroad-diagram, v0.6.3
tab-smart-sort, v0.1.2
tabs-to-spaces, v0.8.1
test-status, v0.27.1
travis-ci-status, v0.11.2
view-tail-large-files, v0.1.10
zentabs, v0.8.2

# Dev
No dev packages

[Enter steps to reproduce below:]

1. Open a directory

Atom Version: 0.209.0
System: Mac OS X 10.10.2
Thrown From: git-diff package, v0.55.0

Stack Trace

Failed to load the git-diff package

At Cannot find module 'fs-plus'

Error: Cannot find module 'fs-plus'
  at Module._resolveFilename (module.js:328:15)
  at Function.Module._resolveFilename (/Applications/Atom.app/Contents/Resources/app.asar/src/module-cache.js:383:52)
  at Function.Module._load (module.js:270:25)
  at Module.require (module.js:357:17)
  at require (module.js:376:17)
  at Object.<anonymous> (/Users/danielravina/.atom/packages/git-diff/lib/helpers.coffee:1:6)
  at Object.<anonymous> (/Users/danielravina/.atom/packages/git-diff/lib/helpers.coffee:1:1)
  at Module._compile (module.js:452:26)
  at Object.requireCoffeeScript (/Applications/Atom.app/Contents/Resources/app.asar/node_modules/coffee-cash/lib/coffee-cash.js:85:19)
  at Module.load (module.js:347:32)
  at Function.Module._load (module.js:302:12)
  at Module.require (module.js:357:17)
  at require (module.js:376:17)
  at Object.<anonymous> (/Users/danielravina/.atom/packages/git-diff/lib/git-diff-view.coffee:2:23)
  at Object.<anonymous> (/Users/danielravina/.atom/packages/git-diff/lib/git-diff-view.coffee:1:1)
  at Module._compile (module.js:452:26)
  at Object.requireCoffeeScript (/Applications/Atom.app/Contents/Resources/app.asar/node_modules/coffee-cash/lib/coffee-cash.js:85:19)
  at Module.load (module.js:347:32)
  at Function.Module._load (module.js:302:12)
  at Module.require (module.js:357:17)
  at require (module.js:376:17)
  at Object.<anonymous> (/Users/danielravina/.atom/packages/git-diff/lib/main.coffee:1:15)
  at Object.<anonymous> (/Users/danielravina/.atom/packages/git-diff/lib/main.coffee:1:1)
  at Module._compile (module.js:452:26)
  at Object.requireCoffeeScript (/Applications/Atom.app/Contents/Resources/app.asar/node_modules/coffee-cash/lib/coffee-cash.js:85:19)
  at Module.load (module.js:347:32)
  at Function.Module._load (module.js:302:12)
  at Module.require (module.js:357:17)
  at require (module.js:376:17)
  at Package.module.exports.Package.requireMainModule (/Applications/Atom.app/Contents/Resources/app.asar/src/package.js:709:34)
  at /Applications/Atom.app/Contents/Resources/app.asar/src/package.js:188:28
  at Package.module.exports.Package.measure (/Applications/Atom.app/Contents/Resources/app.asar/src/package.js:165:15)
  at Package.module.exports.Package.load (/Applications/Atom.app/Contents/Resources/app.asar/src/package.js:179:12)
  at PackageManager.module.exports.PackageManager.loadPackage (/Applications/Atom.app/Contents/Resources/app.asar/src/package-manager.js:372:14)
  at PackageManager.module.exports.PackageManager.loadPackages (/Applications/Atom.app/Contents/Resources/app.asar/src/package-manager.js:336:14)
  at Atom.module.exports.Atom.startEditorWindow (/Applications/Atom.app/Contents/Resources/app.asar/src/atom.js:638:21)
  at Object.<anonymous> (/Applications/Atom.app/Contents/Resources/app.asar/src/window-bootstrap.js:12:8)
  at Object.<anonymous> (/Applications/Atom.app/Contents/Resources/app.asar/src/window-bootstrap.js:23:4)
  at Module._compile (module.js:452:26)
  at Object.loadFile [as .js] (/Applications/Atom.app/Contents/Resources/app.asar/src/babel.js:162:21)
  at Module.load (module.js:347:32)
  at Function.Module._load (module.js:302:12)
  at Module.require (module.js:357:17)
  at require (module.js:376:17)
  at setupWindow (file:///Applications/Atom.app/Contents/Resources/app.asar/static/index.js:95:23)
  at window.onload (file:///Applications/Atom.app/Contents/Resources/app.asar/static/index.js:36:7)

Commands

Config

{
  "core": {
    "themes": [
      "atom-dark-ui",
      "my-theme-syntax"
    ]
  }
}

Installed Packages

# User
color-picker, v2.0.4
git-diff, v0.55.0
my-theme-syntax, v0.0.0

# Dev
No dev packages

When all hunks in a file are commited, the colored status column is reset as expected. If, however, only some hunks are staged and commited (git add -p and friends), the update does not happen. Closing the tab and reopening fixes the issue.

Not sure whether that's a request for git-diff or minimap, but it would be very useful if git diffs would also be visible in the minimap window, so developers can quickyl navigate to them.

If multiple packages use this method (adding a class that adjusts left-padding and sets a left border), only one is able to show their line highlight.

Minor issue but it would be nice if when a user committed files, line diffs were automatically updated as opposed to updating when the window is refocused.

i.e. when I change a line and then commit that change, atom still thinks the line is different than HEAD until refocusing the editor.

Every line except for the last line on nearly all the files I open (HTML, CSS, JS, PHP, etc) is marked as modified, but I haven't made any changes to a single file. git diff returns nothing.

I believe it would also require changes in the repository class in core so that we can pass cli options to getLineDiffs (-w in that case).

See atom-minimap/minimap-git-diff#12

E.g., git diff-files.

When only adding whitespace to a file it shows as orange (modified) in the folder tree-view.
git-diff however ignores this whitespace.

I realize that the whitespace plugin by default mitigates this issue but it can still happen if the "ignoring whitespace only lines" is set. Or for those that disable it completely.

See atom/atom#2423

Repro Steps

1. Launch Atom
2. Edit a file in a Git repository
3. Open Settings
4. Check box next to "Use React Editor"
5. Scroll down to the Git Diff package
6. Check box next to "Show Icons In Editor Gutter"
7. Restart Atom
8. Open edited file

Expected: Modified line icons to be showing in the gutter
Actual: No icons showing

The icons show when the box is unchecked, and hide when the box is checked.

Hi, I can get it to highlight any changes in the document, I've tried enabling and disabling the option Show icons in the editor glutter and nothing happends. Here is an screenshot:

Don't know if it's already possible, But can we see the diff, inline ? Instead just lines changed ?

For instance, if I open ~/Projects, which contains project1, project2, project3, all with their own initialised git repos, all with changes, this plugin doesn't show any of the changes.

It will only show changes if the root directory that I'm editing, is the project directory with the git repository.

Ideally, this plugin should be intelligent enough to find the git repos in the current tree, and display their modifications accordingly in the editor.

Git diff show all the files of my repo like untracked files.

For example, If I add a new line to the file, the new line added isn't marked as "new line".

Screenshoots:

Before add a line

After add a line

GitGutter's indicator icons are much clearer, even on a light background.
It would be great if git-diff would have that sort of option.

Similar to the way n/N work in Vim search and less. When hit the last change in the file, instead of a beep start at the top with a message in the status bar. And vice versa when hit the first change in the file start from the bottom with a message in the status bar.

I have file encoded with GBK.

this plugin will marked lines with Chinese characters as diff, but the file actually doesn't have any diff.

[Enter steps to reproduce below:]

1. Open a directory with some changed uncommitted files under git

Atom Version: 0.192.0
System: Mac OS X 10.9.5
Thrown From: git-diff package, v0.54.0

Stack Trace

Uncaught Error: No screen line exists when converting buffer row to screen row

At /Applications/Atom.app/Contents/Resources/app/src/display-buffer.js:1029

Error: No screen line exists when converting buffer row to screen row
  at DisplayBuffer.module.exports.DisplayBuffer.screenPositionForBufferPosition (/Applications/Atom.app/Contents/Resources/app/src/display-buffer.js:1029:17)
  at DisplayBuffer.module.exports.DisplayBuffer.screenRangeForBufferRange (/Applications/Atom.app/Contents/Resources/app/src/display-buffer.js:884:20)
  at Marker.module.exports.Marker.getScreenRange (/Applications/Atom.app/Contents/Resources/app/src/marker.js:138:33)
  at TextEditorPresenter.module.exports.TextEditorPresenter.didDestroyDecoration (/Applications/Atom.app/Contents/Resources/app/src/text-editor-presenter.js:1210:80)
  at /Applications/Atom.app/Contents/Resources/app/src/text-editor-presenter.js:1165:24
  at Emitter.module.exports.Emitter.emit (/Applications/Atom.app/Contents/Resources/app/node_modules/event-kit/lib/emitter.js:82:11)
  at Decoration.module.exports.Decoration.destroy (/Applications/Atom.app/Contents/Resources/app/src/decoration.js:57:20)
  at /Applications/Atom.app/Contents/Resources/app/src/decoration.js:42:24
  at Emitter.module.exports.Emitter.emit (/Applications/Atom.app/Contents/Resources/app/node_modules/event-kit/lib/emitter.js:82:11)
  at Marker.module.exports.Marker.destroyed (/Applications/Atom.app/Contents/Resources/app/src/marker.js:229:20)
  at /Applications/Atom.app/Contents/Resources/app/src/marker.js:42:24
  at Emitter.module.exports.Emitter.emit (/Applications/Atom.app/Contents/Resources/app/node_modules/event-kit/lib/emitter.js:82:11)
  at Marker.module.exports.Marker.destroy (/Applications/Atom.app/Contents/Resources/app/node_modules/text-buffer/lib/marker.js:299:20)
  at Marker.module.exports.Marker.destroy (/Applications/Atom.app/Contents/Resources/app/src/marker.js:53:25)
  at GitDiffView.module.exports.GitDiffView.removeDecorations (/Applications/Atom.app/Contents/Resources/app/node_modules/git-diff/lib/git-diff-view.js:187:16)
  at GitDiffView.module.exports.GitDiffView.updateDiffs (/Applications/Atom.app/Contents/Resources/app/node_modules/git-diff/lib/git-diff-view.js:158:12)
  at /Applications/Atom.app/Contents/Resources/app/node_modules/git-diff/lib/git-diff-view.js:3:61
  at Emitter.module.exports.Emitter.emit (/Applications/Atom.app/Contents/Resources/app/node_modules/event-kit/lib/emitter.js:82:11)
  at /Applications/Atom.app/Contents/Resources/app/node_modules/text-buffer/lib/text-buffer.js:1111:25

Commands

Config

{
  "core": {
    "themes": [
      "atom-dark-ui",
      "atom-dark-syntax"
    ]
  }
}

Installed Packages

# User
atom-typescript, v2.15.0
autocomplete-plus, v2.9.0
linter, v0.12.0
tabs-to-spaces, v0.9.2

# Dev
No dev packages

Currently we style the line numbers with colors but I feel like using the border on the left makes it more visible and we aren't using that side for any information yet.

See https://github.com/atom/solarized-dark-syntax/blob/master/git-diff.less for markup (I love that I can use css's calc function).

Thoughts, @benogle @kevinsawicki?

I use atom to edit my golang project (.go file), git-diff does not work, but work well in php project (.php file), and I am sure I use git in both projects, that's strange.

I have version 0.55.0 installed and it doesn't seem to work anymore. No diffs are marked in the gutter.

If you open a project and then add a second pane to the Atom window, git diff does not show the line differences at all in the second pane. The original pane works fine, and when you focus on the other pane the information at the bottom of the window changes, but the lines never show up.

Submodules (both those managed by their parent repository and those with a simple pointer) don't reflect their changes in the gutter with git-diff.

This is more of a question than a bug right now. But when I open certain repos on my machine I don't see the diff coloring and in some I do. What would cause this to happen?

Every line in all of my files are showing as modified. The tree view does not mark them as modified and git status comes back clean. The status bar also does not show any changes. I believe I have my git line endings are set up properly. I've followed the solutions on a bunch of related issues — but no luck.

I'm using Parallels on my Mac (OSX Yosemite) to access the Windows partition. Running git status from OSX and Windows both comes back clean.

Anything else I should look into?

I'm unable to pinpoint the cause of this bug, but it may possibly be an issue of file permissions. The "status-modified" class is applied to certain files, but when running "git status" via the command line, it shows no changes have been made.

My environment:

• Ubuntu 14.04
• Atom v0.178.0 installed via http://ppa.launchpad.net/webupd8team/atom/ubuntu trusty main
• Atom accessing files via a Samba share

The Git status gutter is not shown when line numbers are hidden.

It appears that the top: .6em; setting in PR #32 is misaligning the removed icon in the gutter. It is pushing it too far down. Removing the top: .6em; rule fixes the problem.

Expected:

Actual:

help me to make it work please.

I tried all of the suggestions in this thread, but gutters are not working. The thread itself is about git-diff not working at all. It is only the gutter functionality that is not working on my instance.