Could trigger / procedure related keywords be implemented?
Here are a couple of them:

before delete on
after delete on
before update on
after update on
before insert on
after insert on

for each row
execute procedure
returns trigger
return
language plpgsql

perform
raise exception

if
elsif
else
end if

Thanks!

Dear all

I work with SAP HANA2 database on Cloud Foundry and noticed that there is no validation for .hdtable, .hdbview, .hdbprocedure, (which are the specific to SAP HANA2 on Cloud) I would find it interesting to include them here. What do you think?

Regards,

when I am opening a sql file that saved from SQL Server Management Studio (SSRS), and saved again using Atom. Here is some problems.

• The SQL keyword is not colored from atom
• When opening the sql file from other editor, eg. notepad, there is extra space added between each characters.

Will you help to suggest what is the right way to open it? such as the encoding, line end breaks... etc.

The CONCAT function doesn't get hilighted the way other functions get highlighted.

IF inside of CREATE TABLE IF NOT EXISTS... is highlighted incorrectly. It should be the same keyword color as the rest of these tokens, but instead language-sql is highlighting as if IF were the table name.

See https://dev.mysql.com/doc/refman/5.7/en/create-table.html

Periods, commas, brackets and semicolons are all source.sql

SELECT d.name AS department, max(salary);

MySQL rejects statements within TRIGGER declarations, which typically require semicolons, unless an alternative DELIMITER is defined prior to the trigger declaration.

It would be really helpful to highlight TRIGGER declarations in SQL code that are missing custom DELIMITERs, so that the user catches this mistake in the editor, as opposed to later at runtime. As a bonus, it would also be helpful to point out when SQL code neglects to explicitly reset DELIMITER ; following each trigger declaration.

Additional Information

Hello guys!

I work with ORACLE database and noticed that there is no validation for PKB and PKS (which are the packages specific to ORACLE) they are PL / SQL and I would find it interesting to include them here in this gadget. What do you think?

Regards,

Felipe de Almeida

Prerequisites

• Put an X between the brackets on this line if you have done all of the following:
  • Reproduced the problem in Safe Mode: http://flight-manual.atom.io/hacking-atom/sections/debugging/#using-safe-mode
  • Followed all applicable steps in the debugging guide: http://flight-manual.atom.io/hacking-atom/sections/debugging/
  • Checked the FAQs on the message board for common solutions: https://discuss.atom.io/c/faq
  • Checked that your issue isn't already filed: https://github.com/issues?utf8=✓&q=is%3Aissue+user%3Aatom
  • Checked that there is not already an Atom package that provides the described functionality: https://atom.io/packages

Description

It would be awesome if this package added snippets in the same way that language-javascript did.

Prerequisites

• Put an X between the brackets on this line if you have done all of the following:
  • Reproduced the problem in Safe Mode: http://flight-manual.atom.io/hacking-atom/sections/debugging/#using-safe-mode
  • Followed all applicable steps in the debugging guide: http://flight-manual.atom.io/hacking-atom/sections/debugging/
  • Checked the FAQs on the message board for common solutions: https://discuss.atom.io/c/faq
  • Checked that your issue isn't already filed: https://github.com/issues?utf8=✓&q=is%3Aissue+user%3Aatom
  • Checked that there is not already an Atom package that provides the described functionality: https://atom.io/packages

Description

language-sql wrongly interprets backslash as escaping char for varchars.

Steps to Reproduce

1. Add content:

begin
  dbms_output.put_line('First line');
  
  dbms_output.put_line('\');
  
  dbms_output.put_line('Second line');
end;

2. Change syntax to SQL

Expected behavior:

Line dbms_output.put_line('Second line'); should be formatted exactly as dbms_output.put_line('First line');

Actual behavior:

Reproduces how often:

100%

Versions

Atom : 1.16.0
Electron: 1.3.13
Chrome : 52.0.2743.82
Node : 6.5.0
Windows: 10
language-sql: 0.25.4

I looked through the grammar and could not find with or WITH which is used to begin a Common Table Expression (CTE).

May be related to atom/language-python#102.

Invalid.

The USING constraint that is part of a SQL JOIN clause is not highlighted. I've traced the issue to the language-sql package, but am new enough to Atom that I'm not sure how to change it. Line 148 looks to be the spot. Is this an easy fix for somebody who knows what they're doing?

Prerequisites

• Put an X between the brackets on this line if you have done all of the following:
  • Reproduced the problem in Safe Mode: https://flight-manual.atom.io/hacking-atom/sections/debugging/#using-safe-mode
  • Followed all applicable steps in the debugging guide: https://flight-manual.atom.io/hacking-atom/sections/debugging/
  • Checked the FAQs on the message board for common solutions: https://discuss.atom.io/c/faq
  • Checked that your issue isn't already filed: https://github.com/issues?utf8=✓&q=is%3Aissue+user%3Aatom
  • Checked that there is not already an Atom package that provides the described functionality: https://atom.io/packages

Description

The legacy MySQL 5.7- CHANGE keyword in ALTER TABLE... statements is not being highlighted.

Steps to Reproduce

1. Write a MySQL 5.7 compatible query to rename a column with ALTER TABLE... CHANGE...

Expected behavior:

CHANGE is highlighted as a keyword.

Actual behavior:

CHANGE is treated as a user field.

Reproduces how often:

Always

Versions

$ apm --version
apm  2.2.4
npm  6.2.0
node 8.9.3 x64
atom 1.39.0
python 2.7.15
git 2.18.0

It appears that there is enough differentiation between SQL variants such as T-SQL from Microsoft and the MySQL stuff for instance.

As there is functionality for multiple grammars e.g. how c and c++ are catered for by one package.

Would it make sense to add new grammars to this package then.
There are two forks currently for each of the languages:
MySQL: https://atom.io/packages/language-sql-mysql by @typester
T-SQL: https://atom.io/packages/language-tsql by @mattiascibien

Perhaps it would be helpful so that we avoid issues like #28 and we could invite the original developers of this package to make those changes?

SQL Server has TOP PERCENT syntax (see https://msdn.microsoft.com/en-us/library/ms189463.aspx). Currently language-sql doesn't highlight this syntax.

I noticed a pattern of behavior with Atom's performance while I work on SQL in the editor where Atom lags in performance the moment that SQL functions are defined somewhere in my code. The performance difference is dramatic. I have no SQL related packages installed -- only the standard SQL package bundled with Atom exists.

Example:

It should look like this (minus the space I added to hack the highlighting):

The MySQL DELIMITER keyword is not highlighting.

Description

SQL code within template literals appears without SQL syntax highlighting.

It would be nice to be able to utilize language-sql syntax highlighting for arbitrary text string within a code base.

A SQL string can be differentiated from other text by using a convention comment, e.g.

-- syntax-sql
SELECT
  id
FROM
  event
WHERE
  id IN ? AND
  -- Do not update seat information for event that has past or is due
  -- to start in less than 2 minutes.
  starts_at > + INTERVAL '2 MINUTE' AND
  -- Used to throttle seat request to at most once a minute.
  (
    seat_asked_at IS NULL OR
    seat_asked_at < NOW() - INTERVAL '1 MINUTE'
  )
FOR UPDATE

where syntax-sql triggers the syntax highlighting.

Just so far in my coding, the keywords

TRUNCATE
NOT

are not being highlighted by the syntax highlighter the same way SELECT, WHERE, GROUP BY, HAVING, AND, IN, INSERT INTO, etc. keywords are.

Hi, I noticed that the MySQL parser is not highlighting INSERT as a SQL keyword when this keyword appears within a trigger declaration.

I updated to 1.21 and noticed this started to happen. The digits at the end of the string should be the same color as the string.

language-sql
├── 0.19.0
├── https://github.com/atom/language-sql
├── SQL language support in Atom
├── 120180 downloads
└── 29 stars

Now that SQL implementations offer native JSON types, would be good to highlight this keyword as well.

The SIGNED and UNSIGNED keywords for declaring fine numeric types, such as in MySQL, are not being highlighted.

https://dev.mysql.com/doc/refman/5.7/en/numeric-type-overview.html

Prerequisites

• Put an X between the brackets on this line if you have done all of the following:
  • Reproduced the problem in Safe Mode: https://flight-manual.atom.io/hacking-atom/sections/debugging/#using-safe-mode
  • Followed all applicable steps in the debugging guide: https://flight-manual.atom.io/hacking-atom/sections/debugging/
  • Checked the FAQs on the message board for common solutions: https://discuss.atom.io/c/faq
  • Checked that your issue isn't already filed: https://github.com/issues?utf8=✓&q=is%3Aissue+user%3Aatom
  • Checked that there is not already an Atom package that provides the described functionality: https://atom.io/packages

Description

Out of the box, VSCode seems to not encounter this particular issue with SQL highlighting within a PHP string. The highlighting seems to interpret the PHP variable as a string, when it probably should fallback to the language of the file / outer scope and check what sort of class it should have - in this particular case, it should be interpreted as a PHP variable.

Also, I might create another issue for the following, but not sure how easy it is to check for this problem:

• When using SQL inside a PHP string, it isn't styling joined strings (e.g. concat via .) and
• When starting the string with a lowercase select, this does not trigger SQL highlighting. I could override the styles and transform them to lowercase, but this might actually be a project's styling convention, to not have the code be screaming at you.

Steps to Reproduce

1. Create new file
2. Paste in the following:

<?php
  $editors = '"'.implode('","', ['vim', 'atom', 'vscode']).'"';
  $results = database::select_one_column(
      "SELECT user.id
         FROM user
        WHERE user.healthy = true
          AND user.editor IN ($editors)"
  );

Expected behavior:

$editors should be highlighted/styled like a PHP variable

Screenshot from VSCode

Actual behavior:

$editors is styled like any other plain PHP string.

Screenshot from Atom

Reproduces how often:

100% of the time

Versions

Atom : 1.58.0
Electron: 9.4.4
Chrome : 83.0.4103.122
Node : 12.14.1

apm 2.6.2
npm 6.14.13
node 12.14.1 x64
atom 1.58.0
python
git 2.25.1

Ubuntu 20

Additional Information

It applies the styles of syntax--source syntax--sql syntax--embedded syntax--php and takes the form of a text element.

It is also worth noting that disabling this package, will correctly display PHP string interpolation.

I'm writing out some create table statements, and whenever I type the parenthesis after VARCHAR for example, the indent I have is undone.

So

   VARCHAR(255)

becomes

VARCHAR(255)

I can re-intent it again, but it gets annoying to do that.

To designate temp tables in SQL, they are proceeded with a '#' or '##'. Unfortunately, this seems to highlight them as comments, which is incorrect.

#MyTempTable
##MySecondTempTable

Statements such as the following should result in 'declare' being automatically highlighted as a key word. Currently it does not.

declare @myVariable as int