atty303 / pob-web Goto Github PK

View Code? Open in Web Editor NEW

43.0 2.0 3.0 2 MB

Online build planner for Path of Exile.

Home Page: https://pob.cool

License: MIT License

Lua 1.60% JavaScript 0.31% CMake 1.07% HTML 0.53% C 24.87% TypeScript 51.27% CSS 0.11% C++ 20.25%

pathofbuilding pathofexile emscripten webgl

pob-web's Introduction

pob.cool - Path of Building for browser environment

This is browser version of Path of Building.

Features

Run the PoB in your browser, that's all.
You can select the version of the PoB to run.
Saved builds are stored in the browser's local storage.
- The Cloud folder appears when you are logged into the site. Builds saved there are stored in the cloud and can be accessed from anywhere.
You can load a build by specifying a hash in the URL.
- eg. https://pob.cool/#build=https://pobb.in/WwTAYwulVav6

Limitations

Network access is through our CORS proxy, so all users have the same source IP. This will likely cause rate limiting.
For security reasons, requests containing the POESESSID cookie will be unconditionally rejected. Do not enter POESESSID in the PoB of this site.

Principle

We will not make any changes to the original PoB. This is because a lot of effort has been put into the PoB itself and we want the community to focus on developing the offline version.
- However, it does make changes in behavior that are possible without changing the code.

Development

Prerequisites

Install dependencies

npm ci

Run driver shell

Set up a development server for the PoB web driver alone.

npm run build -w packages/driver
npm run dev -w packages/driver

Run web app

Set up a web application development server. You need to build the driver first.

npm run dev -w packages/web

Under the hood

Running the original PoB Lua code.
Use a custom Lua 5.2 interpreter to run the code.
Using Emscripten to compile the PoB engine to WebAssembly.
A module equivalent to SimpleGraphic is written in C to bridge with the JS driver.
The JS renderer renders using WebGL.
packages/driver emulates PoB windows with vanilla JS.
packages/web is the React application that uses the driver.

pob-web's People

Contributors

Stargazers

Watchers

Forkers

woodyphil alistair1231 francoismentec

pob-web's Issues

Notes tab doesn't work corrently

One bug I noticed is the colour coding for the notes sections is acting very funny (colouring the words BEFORE the intended section)
Additionally the curser in the notes section is not accurate to where I click, it seems to think its about 1.5 lines above where I clicked.

Sorting out errors

Errors generated in Lua are displayed on the screen & notified to Sentry
Errors that depend on the user's environment are displayed on the screen & not notified to Sentry

Mobile support

The following items need to be considered

How to handle keyboard input
How to handle mouse-over
How to display on a small screen

We'll get to it after the desktop development is settled. Otherwise the work may be wasted.

After pressing Find best in Trader, the screen does not refresh automatically (No Session Mode)

Delete texture when no more needs

Missing border of dropdown widget

Actual:

Expected:

Fonts rendered nicely even when enlarged in the browser

Error in `Get Currency Conversion Rates`

/assets/worker-a2Y1A8Nb.js:1 Uncaught (in promise) Error: In download callback: Classes/TradeQuery.lua:74: attempt to index local 'obj' (a nil value)
stack traceback:
	Classes/TradeQuery.lua:74: in function 'callback'
	Launch.lua:306: in function <Launch.lua:305>
	[C]: in function 'xpcall'
	[string "-- pob-web: Path of Building Web..."]:96: in function 'PCall'
	Launch.lua:222: in function <Launch.lua:214>
    at Function.onError (index-D9iCzRnr.js:52:1943)
    at MessagePort.r (index-D9iCzRnr.js:47:1249)
    at MessagePort.r (index-D9iCzRnr.js:74:18355)
    at MessagePort.c (rocket-loader.min.js:1:9405)

Trader's Session Mode is not working

Wait for the font to finish loading before rendering

Couldn't render very long text line

e.g. build Base64 string

Ctrl-Tab to switch tabs and then back, Ctrl is held down

Ctrl is held down so the passive tree popup does not appear, pressing Ctrl fixes it.

Memory leak in TextReasterizer

https://chatgpt.com/c/66970d01-6649-4e30-b70e-e43346b542ad

Use texture atlas.
Use Skyline Bin-packing.
When a texture is full, throw it away and make a new one.

Selecting Chaos Inoculation gives error

steps:

1- Open new tree
2- Click on Chaos Inoculation keystone.

Running on Firefox 125.0.3 (64-bits)

Ability to switch debug/release build

Difficult to debug WASM errors without a Debug build.

Host any PoB version

Stop Emscripten's FS build and provide FS via BrowserFS.

r2/2.42.0/images.tsv
r2/2.42.0/root.zip
r2/2.42.0/root/asset.png ...

PobWindow is a bit strange in React's StrictMode

Components are rendered twice in StrictMode; WASM loads twice? WASM is loaded twice and affects LuaState somehow.

Bypass CORS with Chrome Extension

https://chatgpt.com/c/2233402b-9e2f-43b9-a31e-499a6f92fe40

Access to trade sites, for example, bypasses CORS with a server proxy.
There is a high possibility that the rate limited will be imposed by the access source IP.
Therefore, we bypass CORS with an extension.

Security: Is the security risk increased if the origin is limited to pob.cool? I understand that there is a risk of CSRF if pob.cool itself is rewritten by an attack.

Acendancy not selected is not darkened

Actual:

Expected:

Implement OpenURL API

Use web workers for lua execution

Modal dialog adds a none existent scrollbar spacing to backdrop

saadeghi/daisyui#3040

Garbage is drawn on the rectangle

Probably a problem with white 1x1 texture settings

Implement `Share` button on Build Sharing

It uses sub script.

Drawing of build code is inefficient

The build code is very wide and will not fit in the width of the texture atlas.
Scrolling the cursor in the code text box generates many texture atlases. This is because separate DrawTexts are emitted before and after the cursor.
We need to implement a GC to erase recently unused strings from the Texture Atlas, or come up with something else.