Giter VIP home page Giter VIP logo

Comments (10)

p0nce avatar p0nce commented on May 24, 2024

https://observablehq.com/@jobleonard/gaussian-kernel-calculater

from dplug.

p0nce avatar p0nce commented on May 24, 2024

it makes little difference it seems.
image
^highlights exagerated 8x.

Left: baseline 1331 4 taps
Right: handmade Magic Kernel 4 taps.
Still not anisotropic.

It seems the biggest visual issue is the bilinear sampling itself.

from dplug.

p0nce avatar p0nce commented on May 24, 2024

image
All cubic sampling (right) vs all linear sampling (left) on the 5 mipmap levels. Doing it on later levels would be a bit more expensive but also solves part of the issue. Agair both our mipmapping filter don't make a difference, I think those filters are wrong.

from dplug.

p0nce avatar p0nce commented on May 24, 2024
  • Instead of separate convolution with 1D near-gaussian, try a "round" kernel in the first place => fitting this kernel with exp(-xxvariance) exponential leads nowhere because our kernel is anisotropic.
    The function we fit is a 2D gaussian with a variance of 0.5493
image

from dplug.

p0nce avatar p0nce commented on May 24, 2024
  • Softer kernel (larger variance)? => bingo

  • Sharper kernel (lower variance)? => nope
    image
    With cubic-sampling and no noise.
    Left: exp(-x*x*05493 * 1.5)
    Right: exp(-x*x*05493 * 0.5)
    Now we got something.

  • Dichotomize to find best value between 1 and 0.1 for this factor. => 0.35

from dplug.

p0nce avatar p0nce commented on May 24, 2024

Basically making the mipmap blurrier works to mask anisotropy. That would be just for diffuse (emisive effect) since depth would probably suffer from changes like this.

from dplug.

p0nce avatar p0nce commented on May 24, 2024

Baseline | New mipmap kernel for diffuse + one cubic sample at highest level | New mipmap kernel for diffuse + two cubic samples at highest level

image

aaaaand the new kernel isn't especially nicer on Graillon. It's mostly just a bit blurrier.
Let's see how much cubicSample we need first.

from dplug.

p0nce avatar p0nce commented on May 24, 2024

2 samples of cubic > all samples of cubic (!!!) >> 1 samples of cubic >> all linear samples >> no futurePBREmissive
futurePBREmissive gets 2 samples of cubic for the higher mipmaps then.

from dplug.

p0nce avatar p0nce commented on May 24, 2024

mmmm, perhaps 0.5493 * 0.35 as variance was too small, try higher. =>no, not worth it

from dplug.

p0nce avatar p0nce commented on May 24, 2024

futurePBREmissive has changed in a small way

from dplug.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.