Bad fix for macOS bug? Revealed in Live 12 about dplug HOT 6 CLOSED

@toh-ableton I've given a new build to Oli with your kind informations :) it should fix it in Xcode 15 hosts. (Got the feedback it's all right now)

from dplug.

Uh, I'm not in Live 12 beta...
Certainly no repro with Sonoma 14.0 + any type of Live 11

• maybe with Sonoma 14.3? => nope

from dplug.

I believe the bug starts on this line:

The rect passed in is the dirty rect and can be larger than the view's bounds. If this computes a firstPixel that is outside _wfb's buffer

Apple mentions this in the AppKit release notes:

Some patterns that have historically worked will require adjustment:
[...]

• Filling the dirty rect of a view inside of -drawRect. A fairly common pattern is to simply rect fill the dirty rect passed into an override of NSView.draw(). The dirty rect can now extend outside of your view’s bounds. This pattern can be adjusted by filling the bounds instead of the dirty rect, or by setting clipsToBounds = true.
• Confusing a view’s bounds and its dirty rect. The dirty rect passed to .drawRect() should be used to determine what to draw, not where to draw it. Use NSView.bounds when determining the layout of what your view draws. (10905750)

from dplug.

To reproduce the host must be built with Xcode 15
A x86_64 built with LDC 1.28 also doesn't exhibit the issue for some unknown reason.

from dplug.

•  for good measure test the new build on 10.15, before drawRect about broke every year

from dplug.

Fixed in latest tag

from dplug.