Comments (7)
Thank you for all the work you put into this!
To answer the questions above:
The visual studio code extension has a language server and a language client part; this is something which the vs code team created to create decoupled components that can be reused. So, in theory, we should be able to, for example, create a new client in SublimeText and reuse the same server language server. Except for some parts that are specific to the vs code editor that are currently in the language server client (for example: the custom view that currently gives Aurelia HTML syntax information).
I've recently moved over the validations that were in the client language server part of the extension to the server part and did some refactoring to make creating validations easier. What we can do is migrate the current code to the vs code validations. And if there are any typescript validations move them to a TypeScript language service extension, so they can directly be reused in every editor that talks to TypeScript.
Or we can leave it as it is, and try to integrate it, but that might require parsing files once in the vs code extension and once in the lint tool.
I am currently also fighting a bit to find the time and first want to finish the intellisence/ smart autocomplete first. After that, I want to dive into this and get it better integrated or migrated.
Maybe we can fork or move the lint tool to the Aurelia GitHub, so we can find ways to provide support for it.
from template-lint.
Sad news, but understandable.
When i was doing FE development, i found it to be most useful Aurelia related tool - at that time VS code plugin wasn't even available, so i can't really compare these two (never used VS Code either).
@eriklieben, perhaps you could shed some light on the common and distinct linting related features of aurelia-template-lint vs Aurelia VSCode Extension. It would be fantastic, if VSCode extension could be refactored into "framework service" (like TypeScript language service), that could be consumed by Aurelia plugins for any IDE (or build tool for only linting purposes), not just for VSCode.
@MeirionHughes, thanks for sharing this fantastic tool!
from template-lint.
@MeirionHughes We're greatful for all the work you put into this. Let's hear from @eriklieben to see how he sees this with respect to the VS Code plugin. We'll probably end up accepting ownership of this in one way or another. I'd like to get Erik's thoughts.
from template-lint.
@MeirionHughes Do you want to just transfer this to the aurelia GitHub org? We can take the repo and then update the readme to indicate that we're going to work most of these ideas into the VS Code plugin. Thoughts?
from template-lint.
@EisenbergEffect can do; seems I can't transfer unless you give me permission on Aurelia to make repositories; or I transfer directly to you?
from template-lint.
I'll take it into my personal account and then move it to Aurelia. Thanks!
from template-lint.
can be closed
from template-lint.
Related Issues (20)
- Ensure matching if - else attributes HOT 1
- TypeError: Cannot read property 'Symbol(Symbol.iterator)' of undefined Ln -1 Col -1 HOT 4
- conflicting attributes even if I use template for the if binding HOT 2
- Anonymous interfaces embedded in other interfaces should be type-checked HOT 1
- Ignore feature
- Base class properties not found
- Integration with aurelia-validation
- npm dependency on gulp should be a devDependency HOT 3
- Optional properties inherited from interface not detected HOT 1
- Support type alias
- Support implicitly typed properties
- New rule for Aurelia plugins(and server side rendering): fail when using globals, that don't work with aurelia-pal-nodejs HOT 5
- Catch usages of "this" in bindings
- ViewEngineHooks
- Spread operator bug
- Binding access check when view model is in different folder
- False positive "duplicated id" combined with if.bind
- Publish new version (ie. from 0.9.25 to 0.9.26) HOT 20
- fs.readdir is not a function
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from template-lint.