Giter VIP home page Giter VIP logo

Comments (20)

MeirionHughes avatar MeirionHughes commented on June 20, 2024 1

Just noticed this; I've added aureliaeffect as owner to all the packages.

aurelia-template-lint
gulp-aurelia-template-lint
template-lint
gulp-template-lint

from template-lint.

EisenbergEffect avatar EisenbergEffect commented on June 20, 2024 1

Just got internet back after snow storm took it out for a day and a half :) I'm looking into this now. Might take a day or two since I need to look into details a bit more and see if there's anything special in the publish process. Thanks for your patience @silbinarywolf

from template-lint.

EisenbergEffect avatar EisenbergEffect commented on June 20, 2024 1

I'm hoping the fix is obvious to @fkleuver :) If not or if he doesn't get around to it, then I'll plan to tackle this in a few days.

from template-lint.

EisenbergEffect avatar EisenbergEffect commented on June 20, 2024 1

Thanks for taking time to look into this @fkleuver I was going to sit down today and figure it out...so your timing is impeccable 🤣

@silbinarywolf Can you try this out in your app and see if it gets you going again?

from template-lint.

EisenbergEffect avatar EisenbergEffect commented on June 20, 2024 1

I published 0.10.0.

from template-lint.

EisenbergEffect avatar EisenbergEffect commented on June 20, 2024 1

Yep, that's next :)

from template-lint.

silbinarywolf avatar silbinarywolf commented on June 20, 2024

Thanks! I appreciate you taking the time to do this in your own time!

from template-lint.

silbinarywolf avatar silbinarywolf commented on June 20, 2024

@EisenbergEffect Are we able to get this published soon? Just an ETA so I know when to expect this to be updated will make me happy :)

from template-lint.

silbinarywolf avatar silbinarywolf commented on June 20, 2024

Ah thats rough! We've had flooding / heavy rain down here too lately!
There's no urgency on this so don't feel the need to rush to it, I'd just like to have a lingering todo item covered off within the next month or so!

from template-lint.

EisenbergEffect avatar EisenbergEffect commented on June 20, 2024

Sadly, this repo doesn't build 😢I'm going to have to dig in and try to find out what's going on. Might take a bit of time.

from template-lint.

EisenbergEffect avatar EisenbergEffect commented on June 20, 2024

I've pushed a new version to master that updates some dependencies. The current issue appears to be that the TypeScript compiler APIs have changed. Since I'm less familiar with the internal AST APIs, I'm not sure what the correct way is to convert from the old code to the new code. The errors are in one file: source/rules/bindings.ts. Does anyone here have familiarity with this who could submit a PR? Also including @fkleuver since I know he's messed with TS compiler APIs a bit as well and may be able to make a quick fix. It's only six errors, very similar in nature, that need correction. I can dig further myself, but thought I would put it out to the group here to see if anyone already had this knowledge first.

from template-lint.

silbinarywolf avatar silbinarywolf commented on June 20, 2024

That's essentially the issue I hit while trying to update this. The AST APIs have all changed.

from template-lint.

fkleuver avatar fkleuver commented on June 20, 2024

It appeared to be a fairly straight-forward fix (that is, if things actually still work). See #192
@silbinarywolf @EisenbergEffect

I can't get the rests to run:
image

from template-lint.

silbinarywolf avatar silbinarywolf commented on June 20, 2024

Not sure what you mean by "get us going again"?

The current tagged version is functioning OK, it'll just be painful if somebody on my team hits the bug I fixed in my PR from a couple of months ago :) ie. unclosed HTML tags.

from template-lint.

EisenbergEffect avatar EisenbergEffect commented on June 20, 2024

I mainly meant, can you confirm if what's in master now works for you, now that we've updated the compiler and got it building again.

from template-lint.

silbinarywolf avatar silbinarywolf commented on June 20, 2024

Yep sure. I'll set aside some time this week to do this :)

from template-lint.

EisenbergEffect avatar EisenbergEffect commented on June 20, 2024

Awesome. Thank you @silbinarywolf !

from template-lint.

silbinarywolf avatar silbinarywolf commented on June 20, 2024

Its working fine for my use-case! However it's worth noting that we currently don't have typeChecking running over the project. (We've yet to fix up all the errors its throwing as we've installed the plugin ~3 years after the project was started)

EDIT: cc @EisenbergEffect

from template-lint.

EisenbergEffect avatar EisenbergEffect commented on June 20, 2024

Excellent. Thanks!

from template-lint.

silbinarywolf avatar silbinarywolf commented on June 20, 2024

@EisenbergEffect Thanks! Perhaps tag the Git repo with that version too :)

from template-lint.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.