Hello, I'm using Python, and trying to use the API.

I've got a Sandbox account, and I used pip to install Avalara.

However, the following code does not work: TypeError: 'str' object is not callable - it's looking at print(response.text())

Any suggestions?

from avalara import AvataxClient

client = AvataxClient('my test app',
'ver 0.0',
'my test machine',
'sandbox')

response = client.ping()

to view respnse text

print(response.text())

to view json version of the response

print(response.json())

to view the status code

print(response.status_code())

to view the raw response

print(response.raw())

Installed this package via pip yesterday and got an import error using from client import AvataxClient. from avalara import AvataxClient works.

I don't believe the Apache license is implemented correctly on this SDK. It is also missing from some of the distributed source files.

For people to be able to use and redistribute the SDK in their own code it needs to implement the Apache license correctly. I have open a pull request to address this. #67

SDK API call query_users claims about parameters in documentation (as well as in REST), but actually doesn't involve several of them:

https://github.com/avadev/AvaTax-REST-V2-Python-SDK/blob/master/src/client_methods.py#L6426-L6447

Hey does this work on Python2.7.14?

When a ConnectionError is raised using the AvataxClient (at least during an adjust_transaction) the following code errors because the ava_log_entry only contains an error key and no execution_time key...

>           if ava_log_entry["execution_time"] is None:
E           KeyError: 'execution_time'

From my reading, if running the wrapped func at line 39 raises an Exception the ava_log_entry will have no "execution_time" key.

Forgive me if I've missing something here, this is showing up in our unit tests and I'm no pythonista/pythoneer

https://developer.avalara.com/excise/

It would be great if we could use this module with Avatax Excise as well.

I'm trying to use line number shipping-1. Why? Not sure. That seems to be what the 1st party Avalara Shopify app does. And I need to mirror that.

ac = AvataxClient('Tax App 123', 'ver 2022.09')        
tb = TransactionBuilder(ac, 'COMANY_CODE_ABC', 'SalesOrder', 'CUSTOMER_XYZ')
tb.with_line(amount=10, quantity=2, item_code='FREIGHT', tax_code='FR020800', line_number='shipping-1')

 File "/usr/local/lib/python3.8/site-packages/avalara/transaction_builder_methods.py", line 153, in with_line
    self.line_num += 1
TypeError: can only concatenate str (not "int") to str

Would like to know what changed from version to version. Important to know whether updating will break my application.
Just having a commit history isn't very friendly for humans.

Happy to move this elsewhere if there's a formal process for submitting issues.

Problem statement

The TransactionBuilder doesn't support the taxIncluded attribute which is required
on a per-line item basis if used. See full docs here: https://developer.avalara.com/avatax/dev-guide/customizing-transaction/using-tax-included/

Desired Behavior

As a user of the transaction builder I would like to be able to use something like the following

builder.with_line(amount=100, quantity=1, tax_code=MY_TAX_CODE, tax_included=True)

or (less ideal)

(
  builder
    .with_line(amount=100, quantity=1, tax_code=MY_TAX_CODE)
    .with_tax_included()
)

Workaround

One can work around this by abandoning the TransactionBuilder or by breaking into the model a bit.
This could be done with conditions for item info, but a simple pass for all items is:

for item in builder.create_model["items"]:
  item["taxIncluded"] = True

Notes

It's worth noting two items related to this:

1. the builder currently requires tax_code which is also not a true requirement.
2. with_exempt_line is currently a single quantity, but almost entirely the same as add item

Suggestion for improving might be to do three, backwards-compatible steps to align all three:

• move tax_code to be optional (non-breaking) so that it is only added to the request if not-none
• with_exempt_line calls with_line with minimal alteration (quantity=1 for backwards compatibility, tax_code=None)
• add tax_included to with_line

I'd be happy to PR if you would be amenable.

It's a little confusing that the package is just client. This seems potentially prone to causing name collisions, and also hurts readability of code using this library.

It seems like it would be better if the import instead looked like e.g.:

from avalara import AvataxClient