avantstay / avantstay-ui Goto Github PK

 <Tooltip tip="abracadabra">
    <SomeFunctionalComponent />
</Tooltip>

Warning: Function components cannot be given refs. Attempts to access this ref will fail. Did you mean to use React.forwardRef()?

Check the render method of Tooltip.

So, first of all, I don't know if I'm missing something and if I am, sorry for this in advance.
Couldn't find anything related to this on the docs so here we go...

I'm trying to use your DateRangePicker component and it would be a huge deal if there was a way to fully control the date range state from the outside with something like ContextAPI.

A simplified version or the component I've wrapped the DateRangePicker is:

export const DatePicker = ({ range, label }: DatePickerProps) => {
  const [isOpen, setIsOpen] = useState<boolean>(() => false);
  const { startDate, endDate } = range;

  const toggling = () => setIsOpen(!isOpen);

  const onOptionClicked = (selectedRange: DateSelection) => {
    setRange({
      startDate: selectedRange?.startDate ? moment(selectedRange.startDate).startOf('day').toISOString() : '',
      endDate: selectedRange?.endDate ? moment(selectedRange.endDate).endOf('day').toISOString() : ''
    });
  };

  return (
      <DateRangePicker
        singleDateRange={false}
        show={isOpen}
        onChange={(selectedRange: DateSelection) => onOptionClicked(selectedRange)}
        onClickOut={() => setIsOpen(false)}
        startDate={startDate}
        endDate={endDate}
      />
  );
};

And I've been calling that component with:

  const {
    period,
    setPeriod,
  } = useFilterContext();
  
  <DatePicker range={period} setRange={setPeriod} />

So, my problem here is: if I change startDate and endState states externally using contextApi(in this case useFilterContext() the date picker internally still shows the previousState for those.

Shouldn't this be responsible for watching that kind of change and update accordingly?

BTW, I thought that this could've been an issue related to using React in strict mode since using UNSAFE_componentWillReceiveProps in strict mode is not recommended and may indicate bugs.

Also, is there a reason for using UNSAFE_componentWillReceiveProps instead of componentDidUpdate, memoization techniques or even moving it to static getDerivedStateFromProps?

Thanks you so much!

When using the FloatingContainer component, I've to set the width through className, but I think it could be calculated by default to the width of the containing element.