avluis / hentoid Goto Github PK

This isn't a bug, but not being able to zoom in/out in the hitomi.la webview is very difficult especially on devices with small resolution/dpi.

Adding pinch to zoom would be best but after I've done some research it seems it's not that simple. Here are some references;

http://stackoverflow.com/questions/5125851/enable-disable-zoom-in-android-webview

http://www.johntvolk.com/?p=1

affects version 1.1.5r5

AppCompatActivity internally employs AppCompatDelegate making the use of AppCompatDelegate redundant.

On devices with awkward screen ratios, low dpi, or small resolutions, link texts overflow to a linebreak due to text wrapping. When this happens the text is misaligned from the favicon.

Affects version: 1.1.2

Screenshot:

• unavailable for now.

Possible solutions:

• Provide an alternate layout for smaller dpi
• Add android:gravity="center" to the LinearLayouts holding the favicon-link pairs.

Affects version: 1.1.4

• This issue may be due to the interstitial ads that appear on hitomi.
• Issue occurs on any OS.

Affects version 1.1.4

Add about tab to nav bar.
More info about the app itself (if needed, really).
Link to @csaki 's blog and the Google+ Community page.

This is a user generated bug report provided upon request - comment chain.

User reports:
"Pururin downloads don't work; they just keep saying the 'Unhandled error reading image URLs' message. If it doesn't say that, the download stays at 0% forever."

A quick look at the generated bug report doesn't throw any flags and so I have opened this issue for more eyes to be able take a look at it - please note that bug reports can contain user data so access to this report will be done per request.

@csaki @neosubmarino you have access.

Priority: blocker

Pururin has updated the website and hentoid is now unable to download anything, from any device, using any connection.

This may be due to the page that says "checking your browser"

Affects version: 1.1.4
Tested on: 4.2.2, 4.4.2

Repro steps:

1. Navigate to downloads.
2. Change sorting by tapping 3-dot or hardware menu key.
3. Observe.
4. Relaunch app.

Note:

• Refreshing the downloads list does not remedy the issue.
• Switching to, and returning from a different activity does not remedy the issue.

I'm going to start with hitomi.la because it has a very unfriendly web design and its html structure is simpler than Fakku and Pururin.
Phases:
1 .- New html parser methods: Content list, Category lists (tags, artists, series, etc)
2 .- I was thinking to refactor the project structure. I'm going to create an interface than it'll have all logical business (get the html, parse to java object, get image list, etc).
3 .- Well, I was working in the activity (ContentListActivity) a long time ago, so I'm going to retake it.

( ͡° ͜ʖ ͡°)

Affects version: 1.0.5

Adverse effect: The user is given an error toast even if the app is operating normally and there is no problem. (see below)

Reference: http://developer.android.com/training/monitoring-device-state/connectivity-monitoring.html

Affects version 1.1.5 master

This is due to nhentai parser assuming that all images in the gallery are .jpg when they might not be.

This issue has been fixed in commit 8c3ee2a

When pururin returns an error 521 when hentoid is trying to collect links for download, an "unhandled error" notification is returned to the user.

When this error happens, an empty folder with the manga name is created in the downloads directory.

Affects version: 1.0.8

Frequency: 1/5. Issue happens depending on pururin server.

Repro steps:

1. Download several mangas from pururin.
2. Observe the device notifications.

Result: The download fails and an "unhandled error" notification is shown.

This serves as a guide for areas that need improvement.

• An about section has been created for the app and a mockup of what it should look like (as to improve its presentation) has been put together. Now it just need to be implemented.
• The updater can handle the updates and take care of the notifications - but the download library that powers it has a few issues with cached data - need to take the time to look into this before adding any other dependant features.
• There is a 'Check for Updates' button in the navigation bar from releases prior to the built-in updater - this should be moved into the preferences screen to clean up the navigation bar while still providing the user a manual way to query for updates.
• While on the topic of update checks - upon the introduction of the built-in updater, Toast messages are no longer used to indicate if an update is available or not - this is now handled by showing notifications in the notification bar instead. But when a user manually checks for an update, no feedback is currently provided - add some sort of feedback to indicate that the app is indeed checking for updates - in this case a simple Toast displaying "Checking for updates" once pressed, then a "No updates available" will work. If an update is available, then the built-in updater will show a notification instead.
• When a download is complete - a notification message is sent to the notification bar.
  When multiple downloads complete - multiple notification messages are sent to the notification bar.
  This behavior is seen on wearable devices as well if one is paired to the device.
  Merging completed notifications will clean up the notification bar and any other devices paired with the smartphone that show notifications.
• While browsing any of the three supported websites - the app provides floating action buttons (FAB) to navigate back to different sections of the app. I would like to hide these action buttons when the on-screen keyboard has been triggered - which usually means that the user is inputting text, which means the FAB are in the way. FABs on the Browser are now small enough to not get in the way.
• When a download is complete, the download list requires a refresh to display the new content: Have the download list automatically refresh once a download is complete.

Unable to download from Fakku anymore :(

In a webview activity, tapping and holding text will show the text selection CAB. In this CAB there is a menu overflow that has a web search option. Selecting this option will cause the app to crash.

Affects version: 1.0.8

Device os: 4.2.2

Frequency: 100%

Repro steps:

1. Launch app and proceed to any webview activity.
2. Tap and hold over text.
3. When the CAB appears, select the overflow menu and tap "web search".

Result: A crash report toast will appear and the app will relaunch.

Affects version 1.1.5 master

Fixed:

• mangas that include non-jpg images in it's gallery causes download errors.
• mangas with a siteid ending in '1' causes download errors.
• manga galleries bigger than 200 images may cause an error.
• nhentai cover images occasionally cannot be downloaded.
• Parsing nhentai image galleries can take too long.

The floating action buttons are a neat idea when the app is making use of a webView to show online content - but they get in the way.
Implementing them following the material design guidelines should improve their current look and behavior.

Note: Any work and research under this issue must be considered a workaround until @csaki implements an alternative layout, as suggested by issue #34 and as suggested from previous releases of the FakkuDroid app.

Prototype:

Default

From top left to bottom right:

• Toolbar
  • Up button
  • Refresh button
• Page body
• Disabled download FAB

On a manga page

• On valid manga pages, the download FAB enables by animating to an opaque view

Refreshing

The following behavior applies to all pages that is currently loading:

• The Refresh button is replaced with a Stop button
• A determinate progress bar appears into view underneath the Toolbar
• The Download FAB becomes translucent and disabled.

On any of the three states above, the user can scroll down and doing so will hide the Toolbar.

Default

Manga page

Loading

Behavior:

• The activity is a top level temporary activity that employs an "Up" button. Tapping the Up button will simply end the activity. Behavior based on Android guidelines.
• No navigational back button is employed on screen. The device "Back" button will be used to navigate back.
• The Toolbar shares space with the page body and does not block the page body.
  • Scrolling downwards will animate hide the toolbar upwards.
  • Scrolling upwards on any part of the page body will immediately animate show the toolbar downwards, blocking a small part of the page body until the page is completely scrolled up.
• The Refresh button will only be available on fully loaded pages.
• The Stop button replaces the Refresh button when the page is currently loading.
• The Progress bar appears temporarily on loading pages and disappears briefly after. The progress bar is always anchored to top whether the toolbar is shown or not.
• The Download FAB is always shown but translucent and disabled on invalid pages; opaque and enabled on valid manga pages. The only time the FAB is hidden is when the keyboard has been invoked. The FAB should also follow behavior defined here.
• Animations are important in getting the users attention. As stated in the material guidelines, "Motion provides meaning".

Resources:

• Changing menu items at runtime
• FloatingActionButton library
• To clarify, the behavior for the FAB and Toolbar is usually called a Quick Return Pattern: from my research, a Quick Return Pattern is not native to webView, and must be implemented.

On first launch Hentoid asks for the location to save downloads. In this activity there is a banner at the top that says Fakku. This is a remnant of the old FakkuDroid app.

Expected result: The banner should be appropriate for the app that now also supports Pururin and Hitomi. Possibly a banner that represents the three or a general one for Hentoid that shows neither of the three.

Screenshot:

• Affects version 1.1.5 master
• Affects intel and ARM based processors

Investigate DownloadManagerService.java method parseImageFiles(...)

Affects version: 1.1.5 master

Notes:

• Issue is not specific to which manga is downloaded.
• Issue can be resolved by tapping "View" on the failed manga download to visit the gallery page, and tap downloadFab again.
• Trying again without doing the above steps does not solve the issue.

Affects version: 1.0.8

Repro steps:

1. Go to downloads UI.
2. Advance to last page with content.
3. Tap next page button multuple times.
4. Observe toast.

Reference:
http://stackoverflow.com/questions/16621737/toast-messages-being-queued
http://stackoverflow.com/questions/12922516/how-to-prevent-multiple-toast-overlaps
spam toast sounds delicious.

^

When a download is complete - a notification message is sent to the notification bar.
When multiple downloads complete - multiple notification messages are sent to the notification bar.
This behavior is seen on wearable devices if one is paired.

Merging completed notifications will clean up the notification bar and any other devices paired with the smartphone that show notifications.

Affects version 1.0.3 - 1.0.4

Device resolution: 800x480

Screenshot: http://imgur.com/hl54q3T

Affects version: 1.1.4
Tested on: 4.2.2, 4.4.2

Repro steps:

1. Start download
2. Pause download
3. Disconnect device from internet
4. Resume download.

Affects version 1.1.4r2

Tested on: Samsung SM-G531H OS5.1.1

Screenshot:

Repro steps:

1. On first launch activity, tap "EXPLORE"
2. Select SD card location
3. Tap "CONFIRM".
4. Tap "SAVE".

Result: A toast appears stating "You don't have permission to write in that folder, try in another folder"

Expected result: The user should be able to select sd card as the save location.

Log

Reported here and there.

Repro steps:

1. Proceed to Downloads activity.
2. Type any search term in the toolbar.
3. In the keyboard, tap the search button. Usually indicated as a magnifying glass.

Result: Nothing happens.

Expected result: The keyboard should simply retract because search is initiated as soon as something is entered into the search field.

The toast states "this is the last page" which does not fit into the context of pressing the previous page button in the first page.

Affects version: 1.0.8

Affects version 1.1.5r5

Device info:
Samsung Galaxy Young (Y)
Android 4.0.3
230 x 432 ldpi

Steps to repro:

1. Launch app
2. Launch About activity through nav drawer.

Notes:

• Clearing data or reinstalling the app does not resolve the issue.
• The same device updated to android 4.2 does not reproduce the issue.
• No immediate condition pattern for issue reproduction.
• LOG file

This document is a design guideline for the internal update behavior. It's objective is to streamline the current functionality and provide an elegant and uninterrupting user experience.

Due to contextual behaviors, this document will be divided into two major contexts; Automatic updates, and manual checking for updates.

AUTOMATIC UPDATES

• On launch, App should automatically check for updates over wi-fi .
• IF enabled in preferences, app should check for updates over mobile data.
• User should not be informed in any way that the app is checking for updates. No toast or notifications.
• IF there is no update available, user should not be informed in any way. No toast or notifications.
• IF there is an update available, user should be informed by showing a system notification.
• Update process flow continues from there.

MANUAL CHECK FOR UPDATES

• There should be a "Check for updates" control in preferences UI.
• Manually checking for updates should override the "Updates over mobile data" preference.
• Tapping the item should immediately show "Checking for updates..." toast.
• IF there is no update available, user should be informed with a toast.
• IF there is an update available, user should be informed with a system notification.
• Update process flow continues from there.

Affects 1.1.5 master

Steps to reproduce:

1. Start downloading a manga.
2. Go to download manager and tap cancel on the downloading item.
3. Inspect save directory.

Affects version 1.1.5 master

Affects version 1.1.6r1

Repro steps:

1. Start a tsumino download. It is recommended to select content with over 300 pages.
2. Wait for download to finish.

Result: The download in progress may get interrupted before it is completed. Hentoid will state it has been completed with errors.

Expected result: If the session cookie expires while a download is in progress, the download should halt and alert the user.

Notes:

• Not device or OS dependent
• Session cookie duration is unknown.
• Once a download has been broken, it cannot be normally resumed even after re-doing the captcha.
• More details will follow after testing

When the app checks for updates and an update is available, a notification is delivered. When this notification is delivered, the status bar briefly shows the notification ticker. The ticker states "Tap to install the update!" before the update is downloaded and ready to be installed.

Result: The ticker states that the update is ready to install but the notification states that it is ready for download.

Expected result: The ticker should state that "An update is available!"

Affects version: 1.1.0 all revisions
Affects OS: 4.4.4 and below

Adverse effect: In OS 5.0 and above, the string passed to setTicker() is used by accessibility services and may cause confusion.

Screenshots:

Possible cause:
https://github.com/csaki/Hentoid/blob/8112c6c6d871f48c86e9a65b49af4b4713f1afcd/app/src/main/java/me/devsaki/hentoid/updater/UpdateCheck.java#L222

Along with the required Android 6.0 Runtime Permissions, I am introducing an app intro (or welcome screen, however you like to call it) in order to introduce the app to the user.
This will allow us to do the initial request for runtime permission(s), setting up the directory for downloads and finally (if needed) import prior downloads.

Progress so far:
Check the app-intro experimental optimize branch.

Going past pages with content shows "your downloads list is empty"

This document attempts to address issues about the search function in the Downloads UI that are not severe enough to be considered a bug but trivial enough to be considered.

Issues

• Deactivating the SearchView requires two taps of the "x" button.
• Hardware menu button opens Sort menu under any circumstance.
• Sorting is inaccessible once the SearchView is activated.
• Entering search terms with no matching result will show the closest or last matched result instead of a blank result. There are instances when the search function is used to see 'if' the manga is downloaded and in these cases it is necessary to return a blank result.

Screenshot of all the above behavior together:

Resolution:

• The SearchView should have an "Up" button that deactivates the SearchView.
• Add a dedicated sort menu button to the right of the search button.
• Hardware menu button should dismiss keyboard and open navigation drawer.
• The results should be blank if the search term does not match any of the downloaded mangas.

References:

• Creating a SearchView that looks like the material design guidelines - stackoverflow
  
• Icons such as a sort icon here and here - android material resources.

Affects version 1.1.3

Notes:

• It was working fine for hitomi before update.
• The changes made to allow the download button to work on Fakku work separately from the parsers for Hitomi and Pururin

Confirmed with ff devices:

Screenshots:

V 1.1.2	V 1.1.3

Any manga imported from fakkudroid v2 gets their timestamp set to when it was imported. This information is kept in appdata so reinstalling the app will mean this information is lost and reset again. Because of this, after importing, mangas from v2 would always stay on top when the downloads list is "ordered by date"

Affects version:
All Hentoid & Fakkudroid v3

Affects version 1.1.3 to 1.1.5 master
Affects OS: 4.4.2
Does not affect OS: 5.1.1

Edit: Abandoned

I need volunteers!
If you know your way with Java and/or Android, please contact me!
I can get you up to speed with the Android SDK and Android Studio if you need a refresher or don't know where to start - just get over here already~

Testers:

• @GlitcherWolf 😄
• @cukoid 🎉

Programmers:

• @csaki 🔎
• @wightwulf1944 🏆
• @avluis 👌

Build notes:

• In order to get the debug build, follow this link and tap on the Hentoid logo.
  This should throw an apk at you - please let me know if that is not the case.
• I will be making use of proguard from now on so please let me know of any crashes anywhere and see if you can grab the logcat right around the time that happens.
• Please make sure to clear your logs afterwards - start fresh before moving on with further testing.
• When you think you have a show stopping bug or a collection of them to share, message me so I can open an issue dedicated just for testing (don't want multiple issues on a build that is being actively tested).
• Logcat apps:
  CatLog
  aLogcat

Collaborators - please keep conversation here to a minimum, this will be used as an announcement post.

Logged in, subscribed, cannot view on reader, but works in web browser. Cannot download either, it will only download the first page.

Affects version 1.1.2

Affects version 1.1.4
Note: Due to changes in fakku's webpage.

Is Pururin going to be removed from the app? The forums was going all about how the owner went MIA and the supposed self sufficient server went down.

Affects version 1.1.5 master

Mangas such as this has a site id (135231) and causes download errors.

This has been fixed in commit eac2745

The current UpdateChecker simply checks if there is a new update available.

I would like to augment this with a built-in updater:
Check for updates on startup (as it currently does).
If an update is available, then it notifies of such (does this as well).
Then offers to download said update in the background.
Once the update is downloaded, options are offered to install the update.

In addition, I am planning to leverage off GitHub and use the current repository to host the update itself.

Affects version: 1.0.8

Repro steps:

1. Go to downloads UI.
2. Advance to last page with content.
3. Scroll down and take note of scroll position.
4. Tap next page button.
5. Notice current scroll position.

Note: Issue does not occur on first page and previous page button.