avojak / warble Goto Github PK

There is no title set for the main application window, so the app ID appears in the app switcher instead of the app name.

Describe the bug
Running the AppCenter flatpak on a system that uses a different GTK stylesheet (Adwaita) causes the app to look odd.

To Reproduce
Simply install the application on a non-elementary system.

Expected behavior
App should maintain it's elementary style and branding regardless of the platform it is run on.

Screenshots

Environment (please complete the following information):

• OS Version:

Linux abrar-desktop 5.16.0-zen1-1-zen #1 ZEN SMP PREEMPT Mon, 10 Jan 2022 20:12:01 +0000 x86_64 GNU/Linux
NAME="Arch Linux"
PRETTY_NAME="Arch Linux"
ID=arch
BUILD_ID=rolling
ANSI_COLOR="38;2;23;147;209"
HOME_URL="https://archlinux.org/"
DOCUMENTATION_URL="https://wiki.archlinux.org/"
SUPPORT_URL="https://bbs.archlinux.org/"
BUG_REPORT_URL="https://bugs.archlinux.org/"
LOGO=archlinux-logo

• Warble Version
  V1.1.1

Thank you for this great application.
While diving into the source code I realized it would be pretty nice to support not only english words but a variety of other languages.

For example, instead of having the file called dictionary.txt, it could be called dictionary..txt (same with words.txt), and then through a language selection menu it would be possible to switch languages.

I did do some research for my own language's word list and found this: https://github.com/enz/german-wordlist or https://gist.github.com/MarvinJWendt/2f4f4154b8ae218600eb091a5706b5f4. I could create two lists out of it, a dictionary with only 5 letter words and then a word list with roughly the same amount of words provided in the english set.

We then could to the exact same thing with french, spanish, or any other language that can be provided through a PR.
(ex. https://github.com/words/an-array-of-spanish-words, https://github.com/words/an-array-of-french-words)

When the menu icon button gains focus you can't deselect it. This causes the pop up menu to open whenever a user makes a guess.

cc -Isrc/com.github.avojak.warble.p -Isrc -I../src -Idata -I/usr/include/gtk-3.0 -I/usr/include/at-spi2-atk/2.0 -I/usr/include/at-spi-2.0 -I/usr/include/dbus-1.0 -I/usr/lib/dbus-1.0/include -I/usr/include/gio-unix-2.0 -I/usr/include/cairo -I/usr/include/libdrm -I/usr/include/pango-1.0 -I/usr/include/fribidi -I/usr/include/atk-1.0 -I/usr/include/pixman-1 -I/usr/include/freetype2 -I/usr/include/harfbuzz -I/usr/include/libpng16 -I/usr/include/gdk-pixbuf-2.0 -I/usr/include/libmount -I/usr/include/blkid -I/usr/include/uuid -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include -I/usr/include/gee-0.8 -I/usr/include/granite -I/usr/include/libhandy-1 -fdiagnostics-color=always -pipe -D_FILE_OFFSET_BITS=64 -w -g '-DGETTEXT_PACKAGE="com.github.avojak.warble"' -pthread -MD -MQ src/com.github.avojak.warble.p/meson-generated_Widgets_GameArea.c.o -MF src/com.github.avojak.warble.p/meson-generated_Widgets_GameArea.c.o.d -o src/com.github.avojak.warble.p/meson-generated_Widgets_GameArea.c.o -c src/com.github.avojak.warble.p/Widgets/GameArea.c
../src/Widgets/GameArea.vala: In function ‘warble_widgets_game_area_update_states’:
../src/Widgets/GameArea.vala:383:12: error: incompatible types when assigning to type ‘WarbleModelsState’ {aka ‘enum ’} from type ‘gconstpointer’ {aka ‘const void *’}
rows.get(current_row).get(entry.key).state = entry.value;
^
../src/Widgets/GameArea.vala:402:12: error: incompatible types when assigning to type ‘WarbleModelsState’ {aka ‘enum ’} from type ‘gconstpointer’ {aka ‘const void *’}
var new_state = entry.value;
^
ninja: build stopped: subcommand failed.

Hi. The icon next to the letter M in the bottom row of the keyboard in the app seems not to be working. What is the intended use of the button?

Is your feature request related to a problem? Please describe.

I'm a little slow, so I filled up a row and got "stuck" 😅 I read the directions but somehow it didn't click that I was meant to submit my answer once I'd filled up a row and not the full screen

Describe the solution you'd like

If a row is full, it would be nice to have some kind of on-screen suggestion or action to submit your answer

Describe alternatives you've considered

After a couple seconds you could throw a toast

I think what might be simplest though is fading in a button at the end of the row. go-jump is probably the most appropriate icon name for this (though it's a big ugly, sorry! I'll add that to my list of icons to fix up soon)

I for one can not distinguish between a correct letter in the correct place, and a correct letter in the wrong place.

Maybe a higher contrasting or dissimilar tile color like blue for one of the two.

Maybe I should learn Vala and GTK...

uname output:

Linux bluebox 5.15.11-arch2-1 #1 SMP PREEMPT Wed, 22 Dec 2021 09:23:54 +0000 x86_64 GNU/Linux

pacman -Qi warble | grep ^Version output:

Version         : 1.2.0-2

From elementary/appcenter-reviews#295 (review):

You only need to include OARS tags who have a value other than none. So if you don't have any content warnings to disclose, you can self close the tag like <content_rating type="oars-1.1" />

Hooray for shorter XML files!

Describe the bug

1. Can open using applications
2. lower part of window is off the bottom of the screen
3. cannot move window
4. cannot close applications

Environment (please complete the following information):

• OS Version: Ubuntu 20.04.3 LTS
• Warble Version: unknown; latest install version via Flatpak

Hey, just wanted to let you know that I updated the keycap style icon in elementary icons in case you wanted to use that for Warble's icon. It's a bit more rounded without the inset gradient. It looks like this:

You can find it here: https://github.com/elementary/icons/blob/master/categories/64/preferences-desktop-keyboard.svg

I'm unfortunately missing 128px at the moment, sorry!

Update elementary platform runtime from 6 to 6.1

elementary/appcenter-reviews#295 (review)

Remove copypasta network sandbox hole that shouldn't have even been there in the first place 🤦🏼‍♂️

elementary/appcenter-reviews#295 (review)

Describe the bug
Build failed.

To Reproduce

1. git clone https://github.com/avojak/warble.git
2. meson build --prefix=$HOME/.local/usr
3. ninja -C build install
4. See build fail message (please see attached file: 000ERR.txt)

Expected behavior
Successful build.

Environment (please complete the following information):

• OS Version: Debian GNU/Linux 10
• Warble Version: 1.2.0

Is your feature request related to a problem? Please describe.
Currently the playfield (both key and square) doesn't have a dark color when gtk_application_prefer_dark_theme is true, as illustrated below:

This leads to an unpleasant high contrast when dark mode is activated.

Describe the solution you'd like

As other GTK/native elementary OS applications choose to use a darker color for inputs, a lighter color for buttons, we can also follow their behavior.

• Squares should have a darker background than base (it's supposed to be deeper when considering a real-life game board)
• Keys should have a brighter background than base

Describe alternatives you've considered
Use native GTK components and color with semantic color names (gdk_color_parse)

I know this app is made for elementary OS, but considering it's on Flathub, it might be nice to be a little more cross-desktop friendly. 😉 Right now, the close button always appears on the left, but most other desktops have it set to the right (GNOME on Fedora, Ubuntu, Pop!_OS, etc.).

I believe this should be pretty easy to respect, as it should be built-in behavior in titlebars; if I get a minute, I can throw a PR your way as well. 😄

Need to add a toggle to switch colors to a high-contrast mode for accessibility.

Should also update the Help dialog to not make direct references to specific colors, and instead show the example alongside.

Need to determine:

1. Which colors to use
2. If there's a way to determine whether this should be enabled from the system (similar to dark style preference)

Describe the bug
Closing one Warble window closes all open instances.

To Reproduce

1. Open many Warble windows.
2. Close one of them.
3. They all fall down.

Expected behavior
Closing one window should only close that one window.

Environment (please complete the following information):

• OS Version: elementary OS 6.1
• Warble Version: 1.2.0

Additional context
I wonder also, how Warble instances are tracking separate internal state, and if you play multiple games across different window instances, if the gameplay statistics per window will either clobber each other, or aggregate.

elementary/appcenter-reviews#400 (review)

Describe the bug
I entered the word of the male organ and the program claims it isn't a word when it certainly is.

To Reproduce
Steps to reproduce the behavior:
Enter the name of the male organ.
Notice you can't.

Expected behavior
For the word to be recognized.

Screenshots

Environment (please complete the following information):

• OS Version: Fedora 36 KDE
• Warble Version: 1.3.1

Is your feature request related to a problem? Please describe.
Users should be able to reset their gameplay statistics.

Describe the solution you'd like
Upon viewing gameplay statistics, there could/should be a danger-level button on the other side of "close" that resets the gameplay stats.

Describe alternatives you've considered
The user can live forever in unending, agonizing toil of their imperfect scores being unresettable, and seethe in their imperfections indefinitely.

There's a bug where you can't start a new game while still on the first row of the game. If doesn't necessarily make sense to do so, but it should clear the screen still and not count as a loss.

First, thanks for releasing this game, I've been enjoying it a lot!

Describe the bug
I had a round recently where the correct answer was not being accepted as a real word:

I guess this is filtered out as a potentially problematic word, but was still able to come up as the answer.

Expected behavior
The allowed word list and possible answers list should be exactly the same, with no words appearing in one but not the other.

Environment (please complete the following information):

• OS Version: Elementary OS 6.1
• Warble Version 1.0.1

sercontent.com/6228901/151932317-638ecb81-7be2-4716-ab74-3f79d01abf3c.png)

On Kubuntu 20.04 (fully updated) installed using flatpak. Updated to 1.2.0 as suggested in OMG Ubuntu thread (https://www.omgubuntu.co.uk/2022/01/warble-wordle-game-clone-for-elementary-os).

Is your feature request related to a problem? Please describe.

When I saw the cute little keyboard buttons, I wanted to click them! :D

Describe the solution you'd like

I think it'd make sense for them to be buttons. This would also make the game more accessible e.g. with just the mouse and on touch devices.

Describe alternatives you've considered

You could not make them clickable, I guess 😂

Additional context

If you make the game playable with just the mouse/touch, you'd probably need to add a submit and backspace button to the UI, too.

Got some good feedback to increase the blur a bit for the translucent overlays.

elementary/appcenter-reviews#400 (review)