avpet / s3index Goto Github PK

It will be good if user can provide a custom CSS file, this way it can control 
the appearance of S3 index widget and list of columns to display. Your script 
should not return any CSS data, just a list of items with assigned CSS classes 
and the person, who embeds the widget into his/her webpage, will be able to 
decorate it.

Name your S3 file as "<b>hello" (without quotes), and try to display index. 
Somehow this file is considered as a directory, clicking on it leads to "Oops, 
an iternal error occured. Please try again later."

1.
- Try to enter some bucket name
- Click on validate, get an error
- Clear bucket name, hit enter
-> For few ticks, an error message will be shown (correct) but later it 
disappears and previous bucket name is displayed again.

2. Enter invalid bucket name and click on 'Next'
-> It looks like some default bucket data is used instead of displaying an 
error.

I suggest to add an optional configuration parameter, i.e. 'container', that 
will indicate what div will be used to render an S3 index. In this case we can 
have multiple indexes on the same page.

It's not a bug, but I think that embedding file name and page name into anchor 
part of URL looks ugly. If there is no need to keep this information and you 
are not parsing page's anchor to retrieve pagination and directory data, please 
replace all the links in generated index with 
<a href="javascript:;">..</a>. This way clicking on index item will preserve 
current page URL

Branch name: default

The service is ready for publishing. Could you please review its code?

Sincerely,
Vlad

Try to embed your widget into https page. IE will complain about 'only secure 
content is displayed' by default.