avto-dev / identity-laravel Goto Github PK

If I want create custom TypeIDEntity I must extend vendor class IDEntity that redefine methods getTypesMap & make. It's bad way. Will be great use config or different application environment.

If we want to create custom TypeIDEntity we must extend make method in IDEntity too. With property via can_autodetect we change only getTypesMap method. Of course, will be great if we mustn't extend vendor IDEntity and for this I created issue#2

In IDEntityChassis don't need to replace space between words to dash. Ex: LB130 9128018 is correct chassis format. Its symbol must have!

Describe the bug

If I make the following call:

$identity = IDEntity::make('UC6174226407');

I see a warning in the logs:

<warning>PHP Warning:  sprintf(): Too few arguments in /app/vendor/avto-dev/identity-laravel/src/Types/IDEntityCadastralNumber.php on line 41</warning>

If I don't use auto-detect, everything is fine:

$identity = IDEntity::make('UC6174226407', IDEntityInterface::ID_TYPE_BODY);

Expected behaviour

No warnings.