Putting metrics fails when POWERTOOLS_METRICS_NAMESPACE is not set about powertools-lambda-java HOT 3 CLOSED

First, I didn't really understand this code:

private static String defaultNameSpace() {
        MetricsContext context = MetricsLoggerHelper.metricsContext();
        return "aws-embedded-metrics".equals(context.getNamespace()) ?
                SystemWrapper.getenv("POWERTOOLS_METRICS_NAMESPACE") : context.getNamespace();
}

Looks to me that we should do the contrary: if the env var is empty, set a default, as you suggest.

But I'm not sure how the context namespace is actually set. I've found this which makes me think that "aws-embedded-metrics" is the default. So if it is the default, we try to replace it with the env var, otherwise, it means the user already changed the default somehow (how?) and we should use that.

What is missing here is the check on SystemWrapper.getenv("POWERTOOLS_METRICS_NAMESPACE". If null or empty, we should come back to the default.

from powertools-lambda-java.

Hey @roamingthings , thanks for the report! The requirement for the variable is documented, but it does seem a bit odd to explicitly 1/ check if the default hasn't been overriden, and then 2/ override it with an empty string. Inverting the whole thing as you suggest so we override if we have the env var, or use the default otherwise, seems more sensible, and wouldn't be a breaking change.

What do you think @jeromevdl - ?

from powertools-lambda-java.

This is now released under 1.18.0 version!

from powertools-lambda-java.