The log level is not restored to its initial version properly in logging module. <

Log level not restored at the end of execution about powertools-lambda-java HOT 2 CLOSED

jeromevdl commented on August 17, 2024

Log level not restored at the end of execution

from powertools-lambda-java.

Comments (2)

scottgerring commented on August 17, 2024

I fixed this in the linked branch, but I think the current behaviour in main is actually right.

When we invoke a function with a sampling rate, we decide per invocation whether or not to bump the level down to DEBUG, including more info for the current execution:

powertools-lambda-java/powertools-logging/src/main/java/software/amazon/lambda/powertools/logging/internal/LambdaLoggingAspect.java

Lines 111 to 116 in 628a2ca

 @Around(value = "callAt(logging) && execution(@Logging * *.*(..))", argNames = "pjp,logging") 

 public Object around(ProceedingJoinPoint pjp, 

 Logging logging) throws Throwable { 

 Object[] proceedArgs = pjp.getArgs(); 

 setLogLevelBasedOnSamplingRate(pjp, logging);

If we decide not to, we switch back to the "normal level":

powertools-lambda-java/powertools-logging/src/main/java/software/amazon/lambda/powertools/logging/internal/LambdaLoggingAspect.java

Lines 168 to 176 in 628a2ca

 if (samplingRate > sample) { 

 resetLogLevels(Level.DEBUG); 

 LOG.debug("Changed log level to DEBUG based on Sampling configuration. " + 

 "Sampling Rate: {}, Sampler Value: {}.", samplingRate, sample); 

 } else if (LEVEL_AT_INITIALISATION != LOG.getLevel()) { 

 resetLogLevels(LEVEL_AT_INITIALISATION); 

 } 

 }

So what's the normal level? At the moment in main it is the level that is set after the precedence of the different configuration options are taken into account.

powertools-lambda-java/powertools-logging/src/main/java/software/amazon/lambda/powertools/logging/internal/LambdaLoggingAspect.java

Lines 76 to 90 in 628a2ca

 if (POWERTOOLS_LOG_LEVEL != null) { 

 Level powertoolsLevel = Level.getLevel(POWERTOOLS_LOG_LEVEL); 

 if (LAMBDA_LOG_LEVEL != null) { 

 Level lambdaLevel = Level.getLevel(LAMBDA_LOG_LEVEL); 

 if (powertoolsLevel.intLevel() > lambdaLevel.intLevel()) { 

 LOG.warn("Current log level ({}) does not match AWS Lambda Advanced Logging Controls minimum log level ({}). This can lead to data loss, consider adjusting them.", 

 POWERTOOLS_LOG_LEVEL, LAMBDA_LOG_LEVEL); 

 } 

 } 

 resetLogLevels(powertoolsLevel); 

 } else if (LAMBDA_LOG_LEVEL != null) { 

 resetLogLevels(Level.getLevel(LAMBDA_LOG_LEVEL)); 

 } 

 LEVEL_AT_INITIALISATION = LOG.getLevel();

This feels like the right value to switch back to to me. If we change this to reflect the level before we consider the environment variables as in my linked PR, we'll see things like this:

First execution - WARN - taken from POWERTOOLS_LOG_LEVEL
Second execution - sampled - DEBUG
Third execution - ERROR - reset back to the configuration before the environment variables are configured - taken from log4j2.xml

@jeromevdl it's late and I feel like i've have missed something obvious :D For that, there is the PR ready to go ;)

from powertools-lambda-java.

jeromevdl commented on August 17, 2024

yes, the third step is not good, it should be reset to powertools log level, not log4j2.xml, we can close this issue as it's actually better like this.

from powertools-lambda-java.

Log level not restored at the end of execution about powertools-lambda-java HOT 2 CLOSED

Comments (2)

Related Issues (20)

Recommend Projects

React

Vue.js

Typescript

TensorFlow

Django

Laravel

D3

Recommend Topics

javascript

web

server

Machine learning

Visualization

Game

Recommend Org

Facebook

Microsoft

Google

Alibaba

D3

Tencent

	@Around(value = "callAt(logging) && execution(@Logging * .(..))", argNames = "pjp,logging")
	public Object around(ProceedingJoinPoint pjp,
	Logging logging) throws Throwable {
	Object[] proceedArgs = pjp.getArgs();

	setLogLevelBasedOnSamplingRate(pjp, logging);

	if (samplingRate > sample) {
	resetLogLevels(Level.DEBUG);

	LOG.debug("Changed log level to DEBUG based on Sampling configuration. " +
	"Sampling Rate: {}, Sampler Value: {}.", samplingRate, sample);
	} else if (LEVEL_AT_INITIALISATION != LOG.getLevel()) {
	resetLogLevels(LEVEL_AT_INITIALISATION);
	}
	}

	if (POWERTOOLS_LOG_LEVEL != null) {
	Level powertoolsLevel = Level.getLevel(POWERTOOLS_LOG_LEVEL);
	if (LAMBDA_LOG_LEVEL != null) {
	Level lambdaLevel = Level.getLevel(LAMBDA_LOG_LEVEL);
	if (powertoolsLevel.intLevel() > lambdaLevel.intLevel()) {
	LOG.warn("Current log level ({}) does not match AWS Lambda Advanced Logging Controls minimum log level ({}). This can lead to data loss, consider adjusting them.",
	POWERTOOLS_LOG_LEVEL, LAMBDA_LOG_LEVEL);
	}
	}
	resetLogLevels(powertoolsLevel);
	} else if (LAMBDA_LOG_LEVEL != null) {
	resetLogLevels(Level.getLevel(LAMBDA_LOG_LEVEL));
	}

	LEVEL_AT_INITIALISATION = LOG.getLevel();