Giter VIP home page Giter VIP logo

nuxt-modules's People

Contributors

fossabot avatar jasperbrumter avatar mannil avatar paulgv avatar renovate-bot avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar

nuxt-modules's Issues

gpt-ads-module - Potential Memory leak

Problem

The plugin injects gptAds to the application and the GptAd component adds to the $gptAds.slots array inside the mounted hook:

this.$gptAds.slots.push(adSlot);

The beforeDestroy() hook uses googletag.destroySlots method as it should.

const destroyed = googletag.destroySlots([this.adSlot]);

However there is no cleanup of this.$gptAds.slots when the component is removed, thus keeping the adSlot in memory, event after the component is destroyed.

Is this intentional ?

Possible solution

I think the adSlot should be also removed from this.$gptAds.slots.
For example:

const destroyed = googletag.destroySlots([this.adSlot]);
this.$gptAds.slots = this.$gptAds.slots.filter(adSlot => adSlot != this.adSlot);

gpt-ads-module not working!

Firstly i would like to thank you for this awesome work, but i wonder about how to use it!

Am trying to implement gpt-ads in my nuxt app but no output, no console errors literally nothing just empty div.

maybe i didn't understand the documentation so it would be a great thing if you provide to us a working example with all possible options.

for example am trying to implement this https://dfpgpt.appspot.com/g/_4$HfM6WF in my project, so whats the best way to make it work

Thanks in advance

DayJS Locale

I didn't find a way to use a different locale. How can i achieve that?

Dependency Dashboard

This issue lists Renovate updates and detected dependencies. Read the Dependency Dashboard docs to learn more.

Rate-Limited

These updates are currently rate-limited. Click on a checkbox below to force their creation now.

  • chore(deps): update dependency nuxt to v3
  • fix(deps): update dependency js-cookie to v3
  • ๐Ÿ” Create all rate-limited PRs at once ๐Ÿ”

Open

These updates have all been created already. Click a checkbox below to force a retry/rebase of any.

Detected dependencies

circleci
.circleci/config.yml
npm
package.json
  • lerna 3.12.0
packages/dayjs/package.json
  • dayjs ^1.7.5
  • eslint 5.13.0
  • eslint-config-airbnb-base 13.1.0
  • eslint-loader 2.1.2
  • eslint-plugin-import 2.16.0
  • eslint-plugin-jest 22.3.0
  • eslint-plugin-vue 5.2.1
  • jest 24.1.0
  • nuxt 2.4.3
  • request-promise-native 1.0.5
packages/gpt-ads/package.json
  • eslint 5.13.0
  • eslint-config-airbnb-base 13.1.0
  • eslint-loader 2.1.2
  • eslint-plugin-import 2.16.0
  • eslint-plugin-jest 22.3.0
  • eslint-plugin-vue 5.2.1
  • jest 24.1.0
  • jsdom 14.0.0
  • nuxt 2.4.3
  • request-promise-native 1.0.5
packages/lozad/package.json
  • intersection-observer ^0.10.0
  • lozad ^1.15.0
  • eslint 6.8.0
  • eslint-config-airbnb-base 14.1.0
  • eslint-loader 2.1.2
  • eslint-plugin-import 2.20.1
  • eslint-plugin-jest 22.3.0
  • eslint-plugin-vue 6.2.2
  • jest 26.0.1
  • jsdom 16.2.2
  • nuxt 2.12.2
  • request-promise-native 1.0.5
packages/multisite/package.json
  • cookie ^0.3.1
  • deepmerge 2.2.1
  • js-cookie ^2.2.0
  • eslint 5.13.0
  • eslint-config-airbnb-base 13.1.0
  • eslint-loader 2.1.2
  • eslint-plugin-import 2.16.0
  • eslint-plugin-jest 22.3.0
  • eslint-plugin-vue 5.2.1
  • nuxt 2.4.3
  • request-promise-native 1.0.5

  • Check this box to trigger a request for Renovate to run again on this repository

how to hide when ads in blank

I have some ad-unit
but it's not always pushing ads
sometimes it will be blank, and it's okay,
the question is, can I hide the component when there'is no ad?
'cause now it's a white block there
and i don't want to show when it is empty
you know, i want the content down below go up.
is there a config can do this?
(I tired collapseEmptyDivs: true, but it's not working?)
thanks.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.