axelrindle / github-version-checker Goto Github PK

I plan to add Gitlab Support.

Todo's

• Move Github code to separated package
• Add abstractions
• Gitlab REST API
• Gitlab GraphQL API

Example Queries

REST

GET https://gitlab.com/api/v4/projects/13083/repository/tags?order_by=version&sort=desc

GraphQL

{
  project(fullPath: "gitlab-org/gitlab-foss") {
    releases(first: 1) {
      nodes {
        tagName
        upcomingRelease
        links {
          selfUrl
        }
      }
    }
  }
}

Describe the bug
Broken down on Node.js version 9.x and below.

TypeError: "listener" argument must be a function
    at ClientRequest.once (events.js:340:11)
    at new ClientRequest (_http_client.js:174:10)
    at Object.request (http.js:39:10)
    at Object.request (https.js:245:15)
    at Object.get (https.js:249:21)
    at rest (/usr/lib/node_modules/homebridge-broadlink-rm-pro/node_modules/github-version-checker/lib/check.js:121:19)
    at module.exports (/usr/lib/node_modules/homebridge-broadlink-rm-pro/node_modules/github-version-checker/lib/check.js:164:5)
    at module.exports (/usr/lib/node_modules/homebridge-broadlink-rm-pro/node_modules/github-version-checker/lib/main.js:14:5)
    at checkForUpdates (/usr/lib/node_modules/homebridge-broadlink-rm-pro/test.js:12:3)
    at Object.<anonymous> (/usr/lib/node_modules/homebridge-broadlink-rm-pro/test.js:19:1)

To Reproduce
use Node.js 9.x

Expected behavior
don't throw error

Versions

Additional context

As discribed in the docs, Node.js v9.x don't support

https.get(url[, options][, callback])

Is there a plan to support this package for browser too?
Seems to be working only for Node.js

First off thanks for this little module.

Wanted to know why the complete release JSON is being pulled rather than just using the 'latest' URI? Is it because it doesn't include the prereleases?

ie. /repos/:owner/:repo/releases/latest

https://developer.github.com/v3/repos/releases/#get-the-latest-release

ReferenceError: version is not defined
at IncomingMessage.res.on (/usr/local/lib/node_modules/github-version-checker/lib/check.js:81:24)
at IncomingMessage.emit (events.js:198:15)
at endReadableNT (_stream_readable.js:1142:12)
at processTicksAndRejections (internal/process/task_queues.js:81:17)
[6/14/2019, 6:08:54 PM] Got SIGTERM, shutting down Homebridge...

github-version-checker = "version": "2.1.1"
^CZarfs-Mac-mini:~ zarf$ node -v
v11.13.0

From debugging, found = true, but since version is defined as a let within the for scope, it is undefined outside causing the reference error.

I was able to fix this by defining version ahead of the for loop. Here is my diff

diff check.js.orig check.js
72a73

  let version;

74c75
< let version = json[i];

    version = json[I];

John Talbot

Using a single gulpfile.js for one task should be enough.