ay2324s2-cs2103t-f14-3 / tp Goto Github PK

The issue is on the inconsistency of error message displayed when a large index number is added.

• Current Input:
  uc 9999999999999999999999999999999999999999999 n/alex

• Current Output:
  Invalid command format!
  uc: Updates the details of the person identified by the index number used in the displayed person list. Existing values will be overwritten by the input values.
  Parameters: INDEX (must be a positive integer) [n/NAME] [c/CLASS/GROUP] [e/EMAIL] [p/PHONE] [t/TELEGRAM ID] [g/GITHUB ID]
  Example: uc 1 p/91234567 e/[email protected]

• Expected Output:
  The person index provided is invalid.

Since there is a validation for invalid userID, is it possible to insert an improvement to this validation such that it can check for inputs that exceeds the maximum amount of ID that this application allows?

For example (this should be the expected output):



However (this is the current output):



Labels: severity.Low type.FeatureFlaw
original: KhoonSun47/ped#2

As a TA, I want to easily delete student contact details, to keep the toolkit current.

If I add an additional field at the end of the ‘ac’ command, it would be better to display an error message that I have add in too many fields.

For example:

• Current Input:
  ac n/John Doe c/F14-3 e/[email protected] p/91234567 t/@johndoe g/johnDoeGithub homework/CS2103 Assignment

• Current Output:
  GitHub ID should only contain alphanumeric characters and symbols, and it should not be blank

• Expected Output:
  Error message should be that too many fields have been added

One way to improve this could be checking the number of fields added. If the field added exceed the number of fields that your application can accept, throw an error message.



Labels: severity.Low type.FunctionalityBug
original: KhoonSun47/ped#1

• #32
• Adapt to new product (change commands, etc)

The issue is on adding a name that specifically needs a symbol in it, especially names with S/O and D/O.

Since this application deals with the attendance of the student, it would be better if the user can enter the legal name of a student so that the user can easily identify the student.

Without the ability to enter the legal name, it might cause some inconvenience to the user.

• Current Input:
  ac n/John S/O Doe c/F14-3 e/[email protected] p/91234567 t/@johndoe g/johnDoeGithub

• Current Output:
  Names should only contain alphanumeric characters and spaces, and it should not be blank

• Expected Output:
  This person should be added successfully to the application.

Since there is a validation to check for alphanumeric constraints in name, is it possible to improve upon this validation to add in symbols too?



Labels: severity.Medium type.FeatureFlaw
original: KhoonSun47/ped#3

Currently, the attendance is lost when the application is quit. We should update the serialisation so that the state is saved to the data file when the application closes.

It will be easier for the TAs to differentiate students from different class groups since they are highlighted.

... to keep the toolkit updated so I can keep track of new students.

The Attendees column is not scrollable, so the content is not viewable in a smaller window. Take for example someone with the scale of their computer set to large, or with a lower resolution display, some content is potentially inaccessible.

Steps to replicate:

• Set height of window to smallest possible height.
• Type in command ls and press enter.
• Try accessing Attendance for week 13 without resizing the window.

Labels: severity.Medium type.FeatureFlaw
original: naozee/ped#1

... , so I can be aware of who is missing lessons.

Currently, the i/ prefix allows the list of indices to be empty. However, since the whole point of mark command is to mark absentees, we should disallow an empty list of indices. Currently, it will return an zero size ArrayList, and the execute will loop over nothing, effectively a no-op.

I think we can simply throw ParseException when this happens.

This is just a very tiny UI bug. When entered ls T11-2, the list turns black after the person cards are listed. I'm not sure what the expected UI is supposed to look like but I feel that the UI will look nicer if the colour of the empty parts of the list matches the theme of the product.

The screenshot below shows the results after entering the ls [CLASS_GROUP] command.

Labels: type.FeatureFlaw severity.VeryLow
original: agreatdayy/ped#1

As a TA, I want to easily view all student contact details, to keep the toolkit current.

Includes my website links, picture of myself, and my individual portfolio md file.

typing list into the command box throws an unknown command.

Labels: type.FeatureFlaw severity.High
original: dwangwk/ped#2

Notes that are too long are truncated, resulting in the user not being able to view the note information

Labels: type.FeatureFlaw severity.Medium
original: dwangwk/ped#4

Returning the error message asking for a non-zero unsigned integer poorly written. The range for a 32 bit unsigned integer would be 1 to 4,294,967,295. But here, 2,147,483,648 falls within that range. Perhaps a better error message would be that an invalid index was given.

Labels: severity.VeryLow type.FunctionalityBug
original: dwangwk/ped#5

Since the update command creates a new person with the edited details, we need to copy over the newly added member variables such as notes and attendance.

isSamePerson should check if 2 Persons have the same email, phone, telegram, or github values.
If one of the persons have empty telegram or github values, then that field should not be considered in the check.

Changes the look of the TA Toolkit from the address book's theme

Unable to scroll to the bottom of the students page, unable to see past the 7th entry despite having more entries and the scroll bar being at the bottom. This occurs after the ls command is used.

Labels: type.FeatureFlaw severity.High
original: dwangwk/ped#3

Add 2 names to a contact in the json file.

It's read as the bottom name.

But 2 name fields should be invalid so by right the json file should not be loaded according to the documentation.

Labels: severity.Low type.FunctionalityBug
original: naozee/ped#2

Long strings in small placeholders such as email and phone results in the data being truncated and inaccessible

Labels: type.FunctionalityBug severity.Low
original: dwangwk/ped#1

Some TAs may not have access to student's phone numbers if students are unwilling to share their phone numbers.

As a TA, I want to easily edit student contact details, so I can keep student contacts updated

• #11
• #17
• #21
• #24
• #26

As a TA, I want to easily view students from a particular class to get a quick overview.

As a TA, I want to view a student’s detailed information in another panel, so that I can see all the information related to a student clearly.