ayatanaindicators / ayatana-indicator-power Goto Github PK

See...
UbuntuBudgie/budgie-indicator-applet#15 (comment)

When installing ayatana-indicator-power the glib schema processing fails to compile the schema:

Processing triggers for libglib2.0-0:amd64 (2.55.2-2ubuntu1) ...
/usr/share/glib-2.0/schemas/org.ayatana.indicator.power.gschema.xml:4:1  Error on line 4 char 1: <enum id='icon-policy-enum'> already specified.  This entire file has been ignored.

I have got:

The Ayatana Power Indicator does not support evoking the
power statistics application of your desktop environment, yet.

Please report this to the developers at:
https://github.com/ArcticaProject/ayatana-indicator-power/issues

g_type_class_add_private and friends + some others throw warnings

The power indicator is only needed on a local machine, it does not make that much sense having it in remote sessions. This should be handled via libRDA [1]

[1] https://github.com/ArcticaProject/librda

The menu often displays "estimating..." for multiple hardware items. We need to address this.

See AyatanaIndicators/libayatana-common#60.

... this file should really be in lomiri-sounds (or what its name will be)...

Failed to create IDO object is shown instead of battery status:

This is on Debian unstable, ayatana-indicator-power=23.6.1-1 (same error with 23.6.0-1)

In PR #33, we adpopted various changes required for Lomiri / Ubuntu Touch. These changes bring some name space issues (and the power indicator already had some namespace legacy itself, as well).

The following namings need to be reconsidered and possibly changed:

x-canonical-snap-decisions
src/notifier.c: 331: notify_notification_set_hint(nn, "x-canonical-snap-decisions", g_variant_new_string("true"));

x-canonical-non-shaped-icon
src/notifier.c: 332: notify_notification_set_hint(nn, "x-canonical-non-shaped-icon", g_variant_new_string("true"));

x-canonical-private-affirmative-tint
src/notifier.c: 333: notify_notification_set_hint(nn, "x-canonical-private-affirmative-tint", g_variant_new_string("true"));

x-canonical-snap-decisions-timeout
src/notifier.c: 334: notify_notification_set_hint(nn, "x-canonical-snap-decisions-timeout", g_variant_new_int32(INT32_MAX));
tests/test-notify.cc: 70: static constexpr char const * HINT_TIMEOUT {"x-canonical-snap-decisions-timeout"};

com.canonical.Unity.Screen
src/brightness.c: 342: * DBus Chatter: com.canonical.Unity.Screen
src/brightness.c: 377: "com.canonical.Unity.Screen",
src/brightness.c: 378: "/com/canonical/Unity/Screen",
src/brightness.c: 379: "com.canonical.Unity.Screen",

com.ubuntu.touch.system
src/brightness.c: 25: #define SCHEMA_NAME "com.ubuntu.touch.system"

com.ubuntu.touch.AccountsService.Sound
CMakeLists.txt: 72: if(EXISTS "/usr/share/accountsservice/interfaces/com.ubuntu.touch.AccountsService.Sound.xml")
src/CMakeLists.txt: 37: com.ubuntu.touch
src/CMakeLists.txt: 39: /usr/share/accountsservice/interfaces/com.ubuntu.touch.AccountsService.Sound.xml)

check difference between UBports' indicator-power and ayatana-indicator-power (and forward-port their changes)

This piece of the code should use the new pkg-config variable for detecting the sound path.

src/deviceinfo-flashlight.c is missing copyright header

(WARNING) The coverage exclusion region start flag LCOV_EXCL_START
on line 73 did not have corresponding LCOV_EXCL_STOP flag
in file test/ayatana-indicator-power/src/device.c.

Move the zenity_warning function to libayatana-common and depend this project on that.

Trying to use the flashlight toggle widget action on a Volla Phone (yggdrasil) with Ubuntu Touch 20.04 (r283) simply leaves the following in journalctl -f:

Nov 01 13:40:48 ubuntu-phablet repowerd[3356]: DefaultStateMachine[c1]: handle_user_activity_extending_power_state
Nov 01 13:40:48 ubuntu-phablet lomiri[2402]: g_variant_type_peek_string: assertion 'g_variant_type_check (type)' failed
Nov 01 13:40:48 ubuntu-phablet lomiri[2402]: g_variant_type_string_is_valid: assertion 'type_string != NULL' failed
Nov 01 13:40:48 ubuntu-phablet ayatana-indicat[2317]: g_simple_action_activate: assertion 'simple->parameter_type == NULL ? parameter == NULL : (parameter != NULL && g_variant_is_of_type (parameter, simple->parameter_type))' failed

Version: 22.2.0-1ubports1+0~20220308175505.5+ubports20.04~1.gbp651c13

If one clicks on the "Power Settings" menu item in a desktop environment that is unknown to the power indicator, it evokes a zenity dialog box saying so ... and then exits.

Currently there is no way to disable testing. I have attached a patch that fixes this issue:

    cd ${pkgname}
    patch -Np1 -i ../0002_add-testing-option.patch
    cmake -DCMAKE_INSTALL_PREFIX=/usr -DCMAKE_INSTALL_LIBEXECDIR=lib -Denable_tests=OFF
    make DESTDIR=${pkgdir} install

0002_add-testing-option.patch.zip

some autotools left-over, it seems...