aydenp / passencoder Goto Github PK

Hello,
not sure it is an issue, or a limitation :

this package seem to not working properly under Ubuntu.
is it a mistake in my code + configuration ?
or is it a limitation from apple, which request to have a MAC under MACOS to sign the json wallet pass ?

if it is a bug : then, I can send details, configuration, and code.

thanks

The pass documentation from Apple says that localizable resources should be stored in subdirectories, but when one adds a file with a custom name such as, "en.lproj/pass.strings" the operation fails, since the "en.lproj" subdirectory doesn't exist.

On the ReadMe, the requirements are 'iOS 10.0+ / macOS 10.12+ / tvOS 10.0+ / watchOS 3.0+'

In fact, this cannot run on anything other than macOS.
The Process object, used to sign the Pass Manifest, can't be used on anything other than macOS, as seen here

It looks like every method here is synchronous, despite many performing tasks that aren't immediate. These methods should be identified and replaced with methods that support both callbacks and Swift concurrency.

Hello, this is my first time using Swift Package manager to hopefully I am doing things right. I have added your dependency and within PassEncoder I am getting the following issues which I think are preventing it from building properly so my other classes can't use it.

Currently the PassEncoder is directly fed files that are directly encoded, and can only be used once.

In the future, it would be desirable to have a model which is created in advance and then passed into an instance of PassEncoder which can perform setup and hold any common settings.

This allows for reusing data to create passes, such as a template with a few files with slightly different information.

In the README, it's stated, "...this package requires macOS 10.12+...SPM does not support setting minimum deployment targets..."

Well, it does now, so let's specify that and make it easier to use this library!

The PassEncoder.encode(signingInfo:) method uses the static PassSigner singleton (and not a signer that's passed in). However, the singleton signer is declared as a let instance, which means that the configuration example in the README:

PassSigner.shared.appleWWDRCertURL = URL(fileURLWithPath: PATH_TO_WWDR_CERT.PEM)

will not compile. Moreover, that singleton is not declared as public and therefore can't even be accessed by code outside the module.

Since #4 we have two ways to add files by Data (rather than one already on disk):

• func addFile(named:,from:)
• func addData(named:,from:)

The difference is that the first creates a temporary file on-disk, where the second does it entirely in memory. This is a workaround because the first doesn't support subdirectories (#6).

Ideally, only one of these should exist. Based on the outward appearance of the API, I would vote for the second which doesn't write to disk. This will also be important for #9, where these models may be reused.

There is no reason this needs to be a singleton. Ideally it should be owned by PassEncoder or entirely separate.