azerothcore / mod-cfbg Goto Github PK

View Code? Open in Web Editor NEW

This project forked from winfidonarleyan/mod-cfbg

14.0 6.0 42.0 189 KB

Cross-faction Battleground for AzerothCore

License: MIT License

Shell 0.22% C++ 99.78%

azerothcore-module azerothcore hacktoberfest

mod-cfbg's Introduction

AzerothCore module

CrossFaction Battleground

Latest build status with azerothcore:

Module currently requires:

Need AC commit d40e8946 or newer.

About module

This module based patch https://gist.github.com/irancore/10913800. But, all mechanics of change of fraction and so on is remade. Faction change occurs only for BG and nowhere else.

Features:

Change you faction in bg for balance faction.

Config option (CFBG.conf.dist)

###################################################################################################
#   CrossFaction BattleGround
#   
#   CFBG.Enable
#       Description: Enable mixed alliance and horde in one battleground 
#       Default: 1
#
#   CFBG.Include.Avg.Ilvl.Enable
#       Description: Enable check average item level for bg
#       Default: 1
#

CFBG.Enable = 1
CFBG.Include.Avg.Ilvl.Enable = 1
CFBG.Players.Count.In.Group = 3

How to install

Simply place the module under the modules folder of your AzerothCore source folder.
Re-run cmake and launch a clean build of AzerothCore
Make sure your Battleground.InvitationType is set to 0 in worldserver.conf
Done :)

Edit module configuration (optional)

If you need to change the module configuration, go to your server configuration folder (where your worldserver or worldserver.exe is), copy CFBG.conf.dist to CFBG.conf and edit that new file.

Usage

Enable system CFBG.Enable = 1
Enter BG

Credits

Winfidonarleyan (Author of the module)
Viste (Port Irancore's code to AC)
Irancore (Author original code for TrinityCore)
AzerothCore repository
Discord AzerothCore

mod-cfbg's People

Contributors

Stargazers

Watchers

mod-cfbg's Issues

SPAM ANNOUNCE BATTLEGROUND

With this module, this issue occurs.

More info here:
azerothcore/azerothcore-wotlk#2714

[ERROR] BG would never start

Hello @Winfidonarleyan ,

I implement this today, this is my configuration using rev c05fa1a0a915ab90e8d7731ad0f8f3b2ff2e7731:

But, ingame the BG would never start.

Any idea?.

Thanks for your time.

Various warsong achivements doesn't work for changed faction player

What client do you play on?

enUS

Faction

Alliance
Horde

Content Phase:

Current Behaviour

Original report: chromiecraft/chromiecraft#1032 chromiecraft/chromiecraft#2454

Captured Flag in WSG in under 75 seconds, (64 seconds) Did not get the achievmenet for doing so. This after flag was dropped and respawned.
If you are alliance and drop in horde team in WSG and kill flag carrier it will not count for achievement Supreme Defender

Tester:

The issue is confirmed. Various achivements doesn't work for changed faction player

Quick Cap ID202 ID1502
Supreme Defender ID206 ID1252
Not In My House ID203 ID1251

Expected Behaviour

Should work

Source

No response

Steps to reproduce the problem

.debug bg

Extra Notes

AC rev. hash/commit

chromiecraft/azerothcore-wotlk@fc4b5a9

Operating system

Ubuntu 20.04

Modules

Customizations

None

Server

ChromieCraft

Config not being read

the conf is not being read , confirmed on my server Debian 9
By default the module is disabled

build error after 2b3d46b

Build error after 2b3d46b

debian 10


/root/azerothcore/modules/mod-cfbg/src/CFBG_SC.cpp:126:130: fatal error: only virtual member functions can be marked 'override'
    bool CanSendMessageQueue(BattlegroundQueue* queue, Player* leader, Battleground* bg, PvPDifficultyEntry const* bracketEntry) override
                                                                                                                                 ^~~~~~~~
1 error generated.
make[2]: *** [src/server/scripts/CMakeFiles/scripts.dir/build.make:8973: src/server/scripts/CMakeFiles/scripts.dir/__/__/__/modules/mod-cfbg/src/CFBG_SC.cpp.o] Error 1
make[2]: *** Waiting for unfinished jobs....
make[1]: *** [CMakeFiles/Makefile2:966: src/server/scripts/CMakeFiles/scripts.dir/all] Error 2
make: *** [Makefile:136: all] Error 2

Error new Version

Severity Code Description Project File Line Suppression State
Error LNK1181 cannot open input file '..\scripts\Release\scripts.lib' worldserver E:\Lionwowi\src\server\worldserver\LINK 1
Error C2679 binary '[': no operator found which takes a right-hand operand of type 'ObjectGuid' (or there is no acceptable conversion) scripts C:\Users\porya\Documents\GitHub\azerothcore-wotlk1\modules\mod-cfbg-master\src\CFBG.cpp 796
Error (active) E0304 no instance of function template "CFBG::getRandomRace" matches the argument list scripts C:\Users\porya\Documents\GitHub\azerothcore-wotlk1\modules\mod-cfbg-master\src\CFBG.cpp 283
Error (active) E0304 no instance of function template "CFBG::getRandomRace" matches the argument list scripts C:\Users\porya\Documents\GitHub\azerothcore-wotlk1\modules\mod-cfbg-master\src\CFBG.cpp 292
Error (active) E0304 no instance of function template "CFBG::getRandomRace" matches the argument list scripts C:\Users\porya\Documents\GitHub\azerothcore-wotlk1\modules\mod-cfbg-master\src\CFBG.cpp 297
Error (active) E0304 no instance of function template "CFBG::getRandomRace" matches the argument list scripts C:\Users\porya\Documents\GitHub\azerothcore-wotlk1\modules\mod-cfbg-master\src\CFBG.cpp 303
Error (active) E0304 no instance of function template "CFBG::getRandomRace" matches the argument list scripts C:\Users\porya\Documents\GitHub\azerothcore-wotlk1\modules\mod-cfbg-master\src\CFBG.cpp 308
Error (active) E0304 no instance of function template "CFBG::getRandomRace" matches the argument list scripts C:\Users\porya\Documents\GitHub\azerothcore-wotlk1\modules\mod-cfbg-master\src\CFBG.cpp 325
Error (active) E0304 no instance of function template "CFBG::getRandomRace" matches the argument list scripts C:\Users\porya\Documents\GitHub\azerothcore-wotlk1\modules\mod-cfbg-master\src\CFBG.cpp 332
Error (active) E0304 no instance of function template "CFBG::getRandomRace" matches the argument list scripts C:\Users\porya\Documents\GitHub\azerothcore-wotlk1\modules\mod-cfbg-master\src\CFBG.cpp 339
Error (active) E0304 no instance of function template "CFBG::getRandomRace" matches the argument list scripts C:\Users\porya\Documents\GitHub\azerothcore-wotlk1\modules\mod-cfbg-master\src\CFBG.cpp 377
Error (active) E0304 no instance of function template "CFBG::getRandomRace" matches the argument list scripts C:\Users\porya\Documents\GitHub\azerothcore-wotlk1\modules\mod-cfbg-master\src\CFBG.cpp 381
Error (active) E0304 no instance of function template "CFBG::getRandomRace" matches the argument list scripts C:\Users\porya\Documents\GitHub\azerothcore-wotlk1\modules\mod-cfbg-master\src\CFBG.cpp 385
Error (active) E0304 no instance of function template "CFBG::getRandomRace" matches the argument list scripts C:\Users\porya\Documents\GitHub\azerothcore-wotlk1\modules\mod-cfbg-master\src\CFBG.cpp 389
Error (active) E0304 no instance of function template "CFBG::getRandomRace" matches the argument list scripts C:\Users\porya\Documents\GitHub\azerothcore-wotlk1\modules\mod-cfbg-master\src\CFBG.cpp 393
Error (active) E0304 no instance of function template "CFBG::getRandomRace" matches the argument list scripts C:\Users\porya\Documents\GitHub\azerothcore-wotlk1\modules\mod-cfbg-master\src\CFBG.cpp 397
Error (active) E0304 no instance of function template "CFBG::getRandomRace" matches the argument list scripts C:\Users\porya\Documents\GitHub\azerothcore-wotlk1\modules\mod-cfbg-master\src\CFBG.cpp 401
Error (active) E0304 no instance of function template "CFBG::getRandomRace" matches the argument list scripts C:\Users\porya\Documents\GitHub\azerothcore-wotlk1\modules\mod-cfbg-master\src\CFBG.cpp 424
Error (active) E0304 no instance of function template "CFBG::getRandomRace" matches the argument list scripts C:\Users\porya\Documents\GitHub\azerothcore-wotlk1\modules\mod-cfbg-master\src\CFBG.cpp 430
Error (active) E0304 no instance of function template "CFBG::getRandomRace" matches the argument list scripts C:\Users\porya\Documents\GitHub\azerothcore-wotlk1\modules\mod-cfbg-master\src\CFBG.cpp 436
Error (active) E0415 no suitable constructor exists to convert from "uint64" to "ObjectGuid" scripts C:\Users\porya\Documents\GitHub\azerothcore-wotlk1\modules\mod-cfbg-master\src\CFBG.cpp 521
Error (active) E0417 more than one conversion function from "ObjectGuid" to "uint64" applies: scripts C:\Users\porya\Documents\GitHub\azerothcore-wotlk1\modules\mod-cfbg-master\src\CFBG.cpp 590
Error (active) E0135 namespace "ObjectAccessor" has no member "FindPlayerInOrOutOfWorld" scripts C:\Users\porya\Documents\GitHub\azerothcore-wotlk1\modules\mod-cfbg-master\src\CFBG.cpp 699
Error (active) E0135 namespace "ObjectAccessor" has no member "FindPlayerInOrOutOfWorld" scripts C:\Users\porya\Documents\GitHub\azerothcore-wotlk1\modules\mod-cfbg-master\src\CFBG.cpp 715
Error (active) E0304 no instance of overloaded function "std::unordered_map<_Kty, _Ty, _Hasher, _Keyeq, _Alloc>::find [with _Kty=uint64, _Ty=uint32, _Hasher=std::hash, _Keyeq=std::equal_to<size_t>, _Alloc=std::allocator<std::pair<const uint64, uint32>>]" matches the argument list scripts C:\Users\porya\Documents\GitHub\azerothcore-wotlk1\modules\mod-cfbg-master\src\CFBG.cpp 789
Error (active) E0349 no operator "[]" matches these operands scripts C:\Users\porya\Documents\GitHub\azerothcore-wotlk1\modules\mod-cfbg-master\src\CFBG.cpp 792
Error (active) E0349 no operator "[]" matches these operands scripts C:\Users\porya\Documents\GitHub\azerothcore-wotlk1\modules\mod-cfbg-master\src\CFBG.cpp 794
Error (active) E0349 no operator "[]" matches these operands scripts C:\Users\porya\Documents\GitHub\azerothcore-wotlk1\modules\mod-cfbg-master\src\CFBG.cpp 796
Error C3668 'CFBG_BG::CanSendMessageQueue': method with override specifier 'override' did not override any base class methods scripts C:\Users\porya\Documents\GitHub\azerothcore-wotlk1\modules\mod-cfbg-master\src\CFBG_SC.cpp 126
Error C3668 'CFBG_Player::CanJoinInBattlegroundQueue': method with override specifier 'override' did not override any base class methods scripts C:\Users\porya\Documents\GitHub\azerothcore-wotlk1\modules\mod-cfbg-master\src\CFBG_SC.cpp 149
Error C4263 'bool CFBG_Player::CanJoinInBattlegroundQueue(Player *,uint64,BattlegroundTypeId,uint8,GroupJoinBattlegroundResult &)': member function does not override any base class virtual member function scripts C:\Users\porya\Documents\GitHub\azerothcore-wotlk1\modules\mod-cfbg-master\src\CFBG_SC.cpp 149
Error C4264 'bool PlayerScript::CanJoinInBattlegroundQueue(Player *,ObjectGuid,BattlegroundTypeId,uint8,GroupJoinBattlegroundResult &)': no override available for virtual member function from base 'PlayerScript'; function is hidden scripts C:\Users\porya\Documents\GitHub\azerothcore-wotlk1\modules\mod-cfbg-master\src\CFBG_SC.cpp 204
Error C2440 '=': cannot convert from 'ObjectGuid' to 'uint32' scripts C:\Users\porya\Documents\GitHub\azerothcore-wotlk1\modules\KillStreak-Module-master\src\mod_killstreak.cpp 72
Error C2440 '=': cannot convert from 'ObjectGuid' to 'uint32' scripts C:\Users\porya\Documents\GitHub\azerothcore-wotlk1\modules\KillStreak-Module-master\src\mod_killstreak.cpp 73
Error C2664 'Player *ObjectAccessor::FindPlayer(const ObjectGuid)': cannot convert argument 1 from '_Ty2' to 'const ObjectGuid' scripts C:\Users\porya\Documents\GitHub\azerothcore-wotlk1\modules\mod-cfbg-master\src\CFBG.cpp 521
Error C2664 'void ByteBuffer::appendPackGUID(uint64)': cannot convert argument 1 from 'ObjectGuid' to 'uint64' scripts C:\Users\porya\Documents\GitHub\azerothcore-wotlk1\modules\mod-cfbg-master\src\CFBG.cpp 590
Error C2039 'FindPlayerInOrOutOfWorld': is not a member of 'ObjectAccessor' scripts C:\Users\porya\Documents\GitHub\azerothcore-wotlk1\modules\mod-cfbg-master\src\CFBG.cpp 699
Error C3861 'FindPlayerInOrOutOfWorld': identifier not found scripts C:\Users\porya\Documents\GitHub\azerothcore-wotlk1\modules\mod-cfbg-master\src\CFBG.cpp 699
Error C2039 'FindPlayerInOrOutOfWorld': is not a member of 'ObjectAccessor' scripts C:\Users\porya\Documents\GitHub\azerothcore-wotlk1\modules\mod-cfbg-master\src\CFBG.cpp 715
Error C3861 'FindPlayerInOrOutOfWorld': identifier not found scripts C:\Users\porya\Documents\GitHub\azerothcore-wotlk1\modules\mod-cfbg-master\src\CFBG.cpp 715
Error C2672 'std::_Hash<std::_Umap_traits<_Kty,_Ty,std::_Uhash_compare<_Kty,_Hasher,_Keyeq>,_Alloc,false>>::find': no matching overloaded function found scripts C:\Users\porya\Documents\GitHub\azerothcore-wotlk1\modules\mod-cfbg-master\src\CFBG.cpp 789
Error C2440 'initializing': cannot convert from 'ObjectGuid' to 'const _Kty &' scripts C:\Users\porya\Documents\GitHub\azerothcore-wotlk1\modules\mod-cfbg-master\src\CFBG.cpp 789
Error C3536 'searchGUID': cannot be used before it is initialized scripts C:\Users\porya\Documents\GitHub\azerothcore-wotlk1\modules\mod-cfbg-master\src\CFBG.cpp 791
Error C2679 binary '==': no operator found which takes a right-hand operand of type 'std::_List_iterator<std::_List_val<std::_List_simple_types<_Ty>>>' (or there is no acceptable conversion) scripts C:\Users\porya\Documents\GitHub\azerothcore-wotlk1\modules\mod-cfbg-master\src\CFBG.cpp 791
Error C2679 binary '[': no operator found which takes a right-hand operand of type 'ObjectGuid' (or there is no acceptable conversion) scripts C:\Users\porya\Documents\GitHub\azerothcore-wotlk1\modules\mod-cfbg-master\src\CFBG.cpp 792
Error C2679 binary '[': no operator found which takes a right-hand operand of type 'ObjectGuid' (or there is no acceptable conversion) scripts C:\Users\porya\Documents\GitHub\azerothcore-wotlk1\modules\mod-cfbg-master\src\CFBG.cpp 794

CFBG.Players.Count.In.Group ??? default option?

#   CFBG.Players.Count.In.Group
#       Description: Maximum players in party for enter queue
#       Default: 3
#

Why is it default: 3 and not default: 5??

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

Warsong flag's visual bugs

What client do you play on?

enUS

Faction

Alliance
Horde

Content Phase:

Current Behaviour

Original reports: chromiecraft/chromiecraft#2378 chromiecraft/chromiecraft#2377

Spoiler

In this scenario the flag was only picked up by the Horde. But the interface shows that the Alliance has picked the Horde flag up, too.

See chat. The Alliance captured the Horde flag, but the interface shows that the Horde is still carrying the Alliance flag. It seems that the interface did not reset after the Alliance flag has been returned.

There are two Alliance flags on the map.

Sometimes it happens in WSG that there are no visual indicators for someone being the flag carrier.

Tester:

Spoiler

If flag was returned to base by crossfaction player. On next pickup there will be 2 active icons regardless of amount captured flags. On screenshot below Amis is holdong horde flag, but iterface shows both flags. Anden is crossfaction.
On flag drop by Race-changed player sometimes interface doesn't updates
Flags changing their colors near each other if holding by race-changed player.

2021-11-24.16-51-33.mp4

Race-changed player see wrong flag
Race-changed player doesn't see flag/buff and sometimes vice versa
Interface showing wrong attack icon for. Damn it doesn't show mouse on screenshots, but just beleive me.

Expected Blizzlike Behaviour

Source

No response

Steps to reproduce the problem

Join WSG
Wait for interface glitches during the game

Note: I just played about a hand full of WSGs. Such glitches appeared in each game, if I am remembering correctly.

Extra Notes

No response

AC rev. hash/commit

chromiecraft/azerothcore-wotlk@00dc369

Operating system

Windows 10

Modules

Customizations

None

Server

ChromieCraft

problems when capturing the flag

You being like Horde and join in the WSG and join the alliance team, when you are going to capture the Flag of the horde, you are unable to capture it.

Anyone else with this problem?

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

TODO queue system

How this module should work

1. With option `CFBG.BalancedTeams`

Option CFBG.BalancedTeams

Check average player level for bg

Option CFBG.BalancedTeams.Class.LowLevel

Add new check balance with number of Hunters per team

Option CFBG.BalancedTeams.Class.LevelDiff

Only taking into account characters having level >= BgMaxLevel - LevelDiff
for example in a 10-19 BG, if this value is set to 2, then it will consider only
players of level 17, 18, 19 (>= 19-2)

2. With option `CFBG.EvenTeams.Enabled`

Option CFBG.EvenTeams.Enabled

0 - (Disabled, one team can have one extra player if an odd number of players queues)
1 - (Enabled. Get even teams.)

Option CFBG.EvenTeams.MaxPlayersThreshold

Team member quantity until the EvenTeams rule is valid
5 - (Quantity of players per team after the EvenTeams rule will be ignored)
0 - (No treshold)

BG queue 0/4

CURRENT BEHAVIOUR:

EXPECTED BLIZZLIKE BEHAVIOUR:

Should never show an announcement when 0 players are queued

STEPS TO REPRODUCE THE PROBLEM:

set this conf in worldserver.conf:

Battleground.QueueAnnouncer.Limit.MinLevel = 30
Battleground.QueueAnnouncer.Limit.MinPlayers = 3
Battleground.QueueAnnouncer.SpamProtection.Delay = 60

enable the CFBG module and set this conf:

CFBG.Enable = 1
CFBG.BalancedTeams = 1
CFBG.Include.Avg.Ilvl.Enable = 1
CFBG.Players.Count.In.Group = 1
CFBG.EvenTeams.Enabled = 1
CFBG.EvenTeams.MaxPlayersThreshold = 7

Queue a BG with a 19
Leave
Queue again

EXTRA NOTES:

Type here.

AC HASH/COMMIT:

chromiecraft/azerothcore-wotlk@0d69922

OPERATING SYSTEM:

Ubuntu 20.04

MODULES:

OTHER CUSTOMIZATIONS:

None.

SERVER:

ChromieCraft

Missing 4 commits from winfi

TODO, copy them if needed https://github.com/Winfidonarleyan/mod-cfbg/commits/master

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

Arathi Basin 4/4 players queued won't start with EvenTeams = 1

IF the minPlayersPerTeam for Arathi Basin is 2 (so 4 players are required in total)
AND the CFBG.EvenTeams.Enabled config is set to 1 (enabled)
AND 4 players queue
THEN the BG will not start until a 5th player will queue

EXPECTED BEHAVIOUR: it should start with 4/4 players queued

cc @Helias @Winfidonarleyan

Alterac Valley minibosses can't be attacked

Winfidonarleyan#3

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

Config not being read

Been an issue since modules release , I create modules and conf files to work on many modules, especially I fixed over 40 azerothcore module configs , this one errors , no changes everything default all mit credits left ,errors errors errors . Bad module bad code

`AC>.reload conf
AC>Re-Loading config settings...

Module config: Invalid or missing configuration file : /home/wowtorn/rocketAC/etc/CFBG.conf
Module config: Verify that the file exists and has '[worldserver]' written in the top of the file!
Module config: Use default settings!

Will clear logs table of entries older than 1209600 seconds every 10 minutes.
WORLD: VMap support included. LineOfSight:1, getHeight:1, indoorCheck:1 PetLOS:1
AnticheatModule Loaded.

[IDEA] Choose race joining the Battleground

I don't know if it's possible, but I think so.
I would show a "gossip menu" before "Enter Battle" to choose the race before joining the battleground.
This system improves the interaction between players and battlegrounds, if we make this "showing gossip menu" generic, we could use it for several options/improvements.

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

No me sale en el server Azerothcore-Wotlk me da varios errores

Me salen varios errores al tratar de añadir el módulo cfbg al repositorio.

Not compatible with AzerothCore after ObjectGuid PR

I didn't make a lot of tests and investigation so far but I can't compile the latest azerothcore version with this module, I think it's related to the ObjectGuid PR so I ask help to @UltraNix for this 🙏 .

Errors:

 99%] Building CXX object src/server/scripts/CMakeFiles/scripts.dir/__/__/__/modules/mod-cfbg/src/CFBG.cpp.o
[ 99%] Building CXX object src/server/scripts/CMakeFiles/scripts.dir/__/__/__/modules/mod-cfbg/src/CFBG_SC.cpp.o
/home/helias/Documenti/sources/azth-helias/modules/mod-cfbg/src/CFBG.cpp:528:58: fatal error: no viable conversion from 'unsigned long' to 'ObjectGuid'
        if (Player* _player = ObjectAccessor::FindPlayer(itr.second))
                                                         ^~~~~~~~~~
/home/helias/Documenti/sources/azth-helias/src/server/game/Entities/Object/ObjectGuid.h:109:7: note: candidate constructor (the implicit copy constructor) not viable: no known conversion from 'unsigned long' to 'const ObjectGuid &' for 1st argument
class ObjectGuid
      ^
/home/helias/Documenti/sources/azth-helias/src/server/game/Entities/Object/ObjectGuid.h:109:7: note: candidate constructor (the implicit move constructor) not viable: no known conversion from 'unsigned long' to 'ObjectGuid &&' for 1st argument
/home/helias/Documenti/sources/azth-helias/src/server/game/Entities/Object/ObjectGuid.h:123:18: note: explicit constructor is not a candidate
        explicit ObjectGuid(uint64 guid) : _guid(guid) { }
                 ^
/home/helias/Documenti/sources/azth-helias/src/server/game/Entities/Object/ObjectGuid.h:234:18: note: explicit constructor is not a candidate
        explicit ObjectGuid(uint32 const&) = delete;                // no implementation, used to catch wrong type assignment
                 ^
/home/helias/Documenti/sources/azth-helias/src/server/game/Globals/ObjectAccessor.h:71:41: note: passing argument to parameter 'guid' here
    Player* FindPlayer(ObjectGuid const guid);
                                        ^
1 error generated.
make[2]: *** [src/server/scripts/CMakeFiles/scripts.dir/build.make:8344: src/server/scripts/CMakeFiles/scripts.dir/__/__/__/modules/mod-cfbg/src/CFBG.cpp.o] Errore 1
make[2]: *** Attesa per i processi non terminati....
/home/helias/Documenti/sources/azth-helias/modules/mod-cfbg/src/CFBG_SC.cpp:149:169: fatal error: non-virtual member function marked 'override' hides virtual member function
    bool CanJoinInBattlegroundQueue(Player* player, uint64 /*BattlemasterGuid*/ , BattlegroundTypeId /*BGTypeID*/, uint8 joinAsGroup, GroupJoinBattlegroundResult& err) override
                                                                                                                                                                        ^
/home/helias/Documenti/sources/azth-helias/src/server/game/Scripting/ScriptMgr.h:974:32: note: hidden overloaded virtual function 'PlayerScript::CanJoinInBattlegroundQueue' declared here: type mismatch at 2nd parameter ('ObjectGuid' vs 'uint64' (aka 'unsigned long'))
    [[nodiscard]] virtual bool CanJoinInBattlegroundQueue(Player* /*player*/, ObjectGuid /*BattlemasterGuid*/, BattlegroundTypeId /*BGTypeID*/, uint8 /*joinAsGroup*/, GroupJoinBattlegroundResult& /*err*/) { return true; }
                               ^
1 error generated.
make[2]: *** [src/server/scripts/CMakeFiles/scripts.dir/build.make:8359: src/server/scripts/CMakeFiles/scripts.dir/__/__/__/modules/mod-cfbg/src/CFBG_SC.cpp.o] Errore 1
make[1]: *** [CMakeFiles/Makefile2:1363: src/server/scripts/CMakeFiles/scripts.dir/all] Errore 2
make: *** [Makefile:130: all] Errore 2

Strange condition

At this line:

mod-cfbg/src/CFBG.cpp

Line 383 in 11101b4

 if ((aliFree > hordeFree && bgqueue->m_QueuedGroups[bracket_id][BG_QUEUE_CFBG].empty())) 

we've alifree > hordefree condition that is quite strange there, is it really needed?

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

Guild invite abusable [$15 awarded]

GIVEN THAT the Crossfaction-guild option is DISABLED
and I am an Ally character
AND I join BG
AND I'm playing as Horde player inside the BG
THEN during the BG, I can't join any Ally guild (wrong)
AND I can join Horde guilds (wrong)

EXPECTED BEHAVIOUR: I should only be able to join my own faction's guilds

The $15 bounty on this issue has been claimed at Bountysource.

Arathi Basin faction switching from male human warrior to male orc warrior and winning 1600-0 does not award an achievement [$15]

Originally reported chromiecraft/chromiecraft#305

WHAT CLIENT DO YOU PLAY ON?

enGB
enUS
other (specify)

FACTION

Alliance
Horde

CONTENT PHASE:

Generic
1-19
20-29
30-39

CURRENT BEHAVIOUR:

When entering Arathi Basin as a male human warrior and being changed to a male orc warrior for cross faction, even after winning 1600-0 you do not receive an achievement known as "Arathi Basin Perfection".

EXPECTED BLIZZLIKE BEHAVIOUR:

Cross faction bgs are not blizzlike but what is blizzlike is to receive an achievement after doing what is necessary for it regardless of faction.
https://us.battle.net/support/en/article/32063

STEPS TO REPRODUCE THE PROBLEM:

Enter Arathi Basin as a male human warrior
Be faction swapped into a male orc warrior
Win Arathi Basin 1600-0 ~~making sure to only cap 1 base~~
Observe results

EXTRA NOTES:

There was no issue with internet or latency at the time, all issues I've noticed seem to be from cross faction problems.

I reproduced this issue on local AC with mod-cfbg enabled

After faction change Arathi Basing Perfection is not granted. On the other side, achievements like Arathi Basin Victory are granted:
https://www.youtube.com/watch?v=SNb3eKEUOAM

I checked also if Arathi Basin Perfection is granted to side without faction change. It is:
https://www.youtube.com/watch?v=6UrY8-_cwhw

It might be useful to change minimum number of players per team for arathi basin bg with this sql command:

update battleground_template set MinPlayersPerTeam = 1 where ID = 3;

To revert it back:

update battleground_template set MinPlayersPerTeam = 5 where ID = 3;

AC HASH/COMMIT:

chromiecraft/azerothcore-wotlk@8bacb39

OPERATING SYSTEM:

Ubuntu 20.04

MODULES:

OTHER CUSTOMIZATIONS:

None.

SERVER:

ChromieCraft

There is a $15 open bounty on this issue. Add to the bounty at Bountysource.

Joining an existing BG [$10 awarded]

Sometimes new Battlegrounds start even if there are already other Battlegrounds that have free slots.

Happens mostly when a lot of players queued at the same time (for example when a BG just finished).

The $10 bounty on this issue has been claimed at Bountysource.

Crossfaction arenas aswell

Could it be possible to add crossfaction in rated arenas too?
like an alliance inviting a horde to his arena team and queuing 2x2/3x3/5x5
maybe with an option to change or keep race appeareance

New feature: player command to check how many players are queued per bracket/BG [$40]

.cfbg showqueue

- 10-19 Warsong Gulch: 3/4
- 39-39 Arathi Basin: 3/6
- 30-39 Warsong Gulch: 2/4

note: only show BGs where there is at least 1 player in queue

Did you fix this issue? Go claim the $40 bounty on Bountysource.

Crash in CFBG_SC.cpp:173

@Helias @Winfidonarleyan

Thread 10 "worldserver" received signal SIGSEGV, Segmentation fault.
[Switching to Thread 0x7fffa67fd700 (LWP 8818)]
std::_Hashtable<Player*, std::pair<Player* const, bool>, std::allocator<std::pair<Player* const, bool> >, std::__detail::_Select1st, std::equal_to<Player*>, std::hash<Player*>, std::__detail::_Mod_range_hashing, std::__detail::_Default_ranged_hash, std::__detail::_Prime_rehash_policy, std::__detail::_Hashtable_traits<false, false, true> >::_M_find_before_node (this=0x148ff48 <CFBG::instance()::instance+184>, __n=17, __k=<optimized out>, __code=140734899729408) at /usr/bin/../lib/gcc/x86_64-linux-gnu/9/../../../../include/c++/9/bits/hashtable.h:1545
1545		  if (this->_M_equals(__k, __code, __p))
#0  std::_Hashtable<Player*, std::pair<Player* const, bool>, std::allocator<std::pair<Player* const, bool> >, std::__detail::_Select1st, std::equal_to<Player*>, std::hash<Player*>, std::__detail::_Mod_range_hashing, std::__detail::_Default_ranged_hash, std::__detail::_Prime_rehash_policy, std::__detail::_Hashtable_traits<false, false, true> >::_M_find_before_node (this=0x148ff48 <CFBG::instance()::instance+184>, __n=17, __k=<optimized out>, __code=140734899729408) at /usr/bin/../lib/gcc/x86_64-linux-gnu/9/../../../../include/c++/9/bits/hashtable.h:1545
#1  std::_Hashtable<Player*, std::pair<Player* const, bool>, std::allocator<std::pair<Player* const, bool> >, std::__detail::_Select1st, std::equal_to<Player*>, std::hash<Player*>, std::__detail::_Mod_range_hashing, std::__detail::_Default_ranged_hash, std::__detail::_Prime_rehash_policy, std::__detail::_Hashtable_traits<false, false, true> >::_M_find_node (this=0x148ff48 <CFBG::instance()::instance+184>, __bkt=17, __key=<optimized out>, __c=140734899729408) at /usr/bin/../lib/gcc/x86_64-linux-gnu/9/../../../../include/c++/9/bits/hashtable.h:655
#2  std::__detail::_Map_base<Player*, std::pair<Player* const, bool>, std::allocator<std::pair<Player* const, bool> >, std::__detail::_Select1st, std::equal_to<Player*>, std::hash<Player*>, std::__detail::_Mod_range_hashing, std::__detail::_Default_ranged_hash, std::__detail::_Prime_rehash_policy, std::__detail::_Hashtable_traits<false, false, true>, true>::operator[] (this=0x148ff48 <CFBG::instance()::instance+184>, __k=<optimized out>) at /usr/bin/../lib/gcc/x86_64-linux-gnu/9/../../../../include/c++/9/bits/hashtable_policy.h:697
#3  std::unordered_map<Player*, bool, std::hash<Player*>, std::equal_to<Player*>, std::allocator<std::pair<Player* const, bool> > >::operator[] (this=0x148ff48 <CFBG::instance()::instance+184>, __k=<optimized out>) at /usr/bin/../lib/gcc/x86_64-linux-gnu/9/../../../../include/c++/9/bits/unordered_map.h:985
#4  CFBG::ShouldForgetInListPlayers (this=0x148fe90 <CFBG::instance()::instance>, player=0x7fff65b4b400) at /root/env/chromiecraft/azerothcore-wotlk/modules/mod-cfbg/src/CFBG.cpp:555
#5  CFBG::UpdateForget (this=0x148fe90 <CFBG::instance()::instance>, player=0x7fff65b4b400) at /root/env/chromiecraft/azerothcore-wotlk/modules/mod-cfbg/src/CFBG.cpp:760
#6  0x000000000091fa61 in CFBG_Player::OnBeforeUpdate (this=0x7ffff35aecd0, player=0x7fff65b4b400, diff=<optimized out>) at /root/env/chromiecraft/azerothcore-wotlk/modules/mod-cfbg/src/CFBG_SC.cpp:173
#7  0x00000000006d6043 in ScriptMgr::OnBeforePlayerUpdate (this=<optimized out>, player=0x7fff65b4b400, p_time=10) at /root/env/chromiecraft/azerothcore-wotlk/src/server/game/Scripting/ScriptMgr.cpp:1529
#8  0x00000000004e399f in Player::Update (this=0x7fff65b4b400, p_time=10) at /root/env/chromiecraft/azerothcore-wotlk/src/server/game/Entities/Player/Player.cpp:1592
#9  0x0000000000688463 in Map::Update (this=0x7fffbb2d7440, t_diff=0, s_diff=10) at /root/env/chromiecraft/azerothcore-wotlk/src/server/game/Maps/Map.cpp:736
#10 0x000000000069702c in MapUpdateRequest::call (this=0x7fff66183a60) at /root/env/chromiecraft/azerothcore-wotlk/src/server/game/Maps/MapUpdater.cpp:31
#11 0x00000000006969aa in MapUpdater::WorkerThread (this=0x147cf10 <MapManager::instance()::instance+224>) at /root/env/chromiecraft/azerothcore-wotlk/src/server/game/Maps/MapUpdater.cpp:142
#12 0x00007ffff71d1d84 in ?? () from /usr/lib/x86_64-linux-gnu/libstdc++.so.6
#13 0x00007ffff72eb609 in start_thread (arg=<optimized out>) at pthread_create.c:477
#14 0x00007ffff6ebf293 in clone () at ../sysdeps/unix/sysv/linux/x86_64/clone.S:95

[GAME-BREAKING] Prior party/raid group breaks the crossfaction

While playing Ally, after a Wintergrasp game I was in a raid group with another Ally.

We both joined the CFBG and were in different teams.

PROBLEMS:

we were still in the group
we were unable to leave the group
we were unable to attack each other
we were seeing each other life and map position
we were not seeing our own teammates' group

There is a $20 open bounty on this issue. Add to the bounty at Bountysource.

Error Module new version azerothcore

Severity Code Description Project File Line Suppression State
Error C2664 'Player *ObjectAccessor::FindPlayer(const ObjectGuid)': cannot convert argument 1 from '_Ty2' to 'const ObjectGuid' scripts C:\Users\porya\Documents\GitHub\azerothcore-wotlk1\modules\mod-cfbg\src\CFBG.cpp 528
Error C2664 'void ByteBuffer::appendPackGUID(uint64)': cannot convert argument 1 from 'ObjectGuid' to 'uint64' scripts C:\Users\porya\Documents\GitHub\azerothcore-wotlk1\modules\mod-cfbg\src\CFBG.cpp 597
Error C2039 'FindPlayerInOrOutOfWorld': is not a member of 'ObjectAccessor' scripts C:\Users\porya\Documents\GitHub\azerothcore-wotlk1\modules\mod-cfbg\src\CFBG.cpp 706
Error C3668 'CFBG_Player::CanJoinInBattlegroundQueue': method with override specifier 'override' did not override any base class methods scripts C:\Users\porya\Documents\GitHub\azerothcore-wotlk1\modules\mod-cfbg\src\CFBG_SC.cpp 149
Error C3861 'FindPlayerInOrOutOfWorld': identifier not found scripts C:\Users\porya\Documents\GitHub\azerothcore-wotlk1\modules\mod-cfbg\src\CFBG.cpp 706
Error C2039 'FindPlayerInOrOutOfWorld': is not a member of 'ObjectAccessor' scripts C:\Users\porya\Documents\GitHub\azerothcore-wotlk1\modules\mod-cfbg\src\CFBG.cpp 722
Error C3861 'FindPlayerInOrOutOfWorld': identifier not found scripts C:\Users\porya\Documents\GitHub\azerothcore-wotlk1\modules\mod-cfbg\src\CFBG.cpp 722
Error C4263 'bool CFBG_Player::CanJoinInBattlegroundQueue(Player *,uint64,BattlegroundTypeId,uint8,GroupJoinBattlegroundResult &)': member function does not override any base class virtual member function scripts C:\Users\porya\Documents\GitHub\azerothcore-wotlk1\modules\mod-cfbg\src\CFBG_SC.cpp 149
Error C4264 'bool PlayerScript::CanJoinInBattlegroundQueue(Player *,ObjectGuid,BattlegroundTypeId,uint8,GroupJoinBattlegroundResult &)': no override available for virtual member function from base 'PlayerScript'; function is hidden scripts C:\Users\porya\Documents\GitHub\azerothcore-wotlk1\modules\mod-cfbg\src\CFBG_SC.cpp 204
Error C2672 'std::_Hash<std::_Umap_traits<_Kty,_Ty,std::_Uhash_compare<_Kty,_Hasher,_Keyeq>,_Alloc,false>>::find': no matching overloaded function found scripts C:\Users\porya\Documents\GitHub\azerothcore-wotlk1\modules\mod-cfbg\src\CFBG.cpp 797
Error C2440 'initializing': cannot convert from 'ObjectGuid' to 'const _Kty &' scripts C:\Users\porya\Documents\GitHub\azerothcore-wotlk1\modules\mod-cfbg\src\CFBG.cpp 797
Error C3536 'searchGUID': cannot be used before it is initialized scripts C:\Users\porya\Documents\GitHub\azerothcore-wotlk1\modules\mod-cfbg\src\CFBG.cpp 799
Error C2679 binary '==': no operator found which takes a right-hand operand of type 'std::_List_iterator<std::_List_val<std::_List_simple_types<_Ty>>>' (or there is no acceptable conversion) scripts C:\Users\porya\Documents\GitHub\azerothcore-wotlk1\modules\mod-cfbg\src\CFBG.cpp 799
Error C2679 binary '[': no operator found which takes a right-hand operand of type 'ObjectGuid' (or there is no acceptable conversion) scripts C:\Users\porya\Documents\GitHub\azerothcore-wotlk1\modules\mod-cfbg\src\CFBG.cpp 800
Error C2679 binary '[': no operator found which takes a right-hand operand of type 'ObjectGuid' (or there is no acceptable conversion) scripts C:\Users\porya\Documents\GitHub\azerothcore-wotlk1\modules\mod-cfbg\src\CFBG.cpp 803
Error C2679 binary '[': no operator found which takes a right-hand operand of type 'ObjectGuid' (or there is no acceptable conversion) scripts C:\Users\porya\Documents\GitHub\azerothcore-wotlk1\modules\mod-cfbg\src\CFBG.cpp 810

no member named 'GetTeamStartLoc' in 'Battleground'

Fatal Error on compile:

/root/env/azerothcore-wotlk/modules/mod-cfbg/src/CFBG.cpp:338:9: fatal error: no member named 'GetTeamStartLoc' in 'Battleground'
bg->GetTeamStartLoc(teamId, x, y, z, o);
~~ ^

Help installing this

Hey im rookie on modules but when I read the install instruction it felt easy so I tried but failed.

Anyway when I make a new build of acore with this mod in the module folder I get this error

Error LNK2019 unresolved external symbol "void __cdecl Addmod_cfbg_masterScripts(void)" (?Addmod_cfbg_masterScripts@@yaxxz) referenced in function "void __cdecl AddScripts(void)" (?AddScripts@@yaxxz) worldserver E:\Server 2\1WoW Server WOTLK\Build\src\server\worldserver\scripts.lib(ScriptLoader.obj) 1

I dont know how any of this really works, u know what I did wrong?

join bg bug!

join bg bug !

i changed in to battleground_template random bg min players team to 2vs2 but join bg buged!

for fix and join bg: if you use command: debug bg 1

os: windows

version: azerothcore/azerothcore-wotlk@51aac38

Update configs options in the README

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

Alterac Valley - Horde/Alliance NPCs Unfriendly to Faction-Swapped Players

Original report: chromiecraft/chromiecraft#1953

What client do you play on?

enUS

Faction

Alliance
Horde

Content Phase:

Current Behaviour

I'm horde, but got into BG as alliance, and when I joined, as alliance guards that were alliance were unfriendly to me.

This is maybe logic as they're alliance faction and I'm still horde even tho I'm in grp as alliance.

Tester: installed CFBG and confirmed. This was with an orc character changed to human. The Ally NPCs didn't attack me, and I couldn't attack them either, but they did show as unfriendly.

Also checked with Allies swapped to Horde. This is a nelf swapped to tauren:

This NPC (Smith Rezgar) starts a couple of quests I think, so being unfriendly is more than just a cosmetic issue.

Expected Blizzlike Behaviour

Crossfaction is non blizzlike so nothing better to expect.

Source

No response

Steps to reproduce the problem

Enter AV as crossfaction and see

Extra Notes

No response

AC rev. hash/commit

chromiecraft/azerothcore-wotlk@b2f0893

Operating system

Ubuntu 20.04

Modules

Customizations

None

Server

ChromieCraft

Bug: CFBG causes you to obtain achievements from both factions and can brick achievements. [$35 awarded]

I cannot get this because I have multiple achievments from both sides;

https://www.wowhead.com/achievement=1172/master-of-warsong-gulch#

https://www.wowhead.com/achievement=202/quick-cap

https://www.wowhead.com/achievement=1502/quick-cap

The $35 bounty on this issue has been claimed at Bountysource.

BG balance system is bugged

Running with:

CFBG.Include.Avg.Ilvl.Enable = 1
CFBG.BalancedTeams.Class.MaxLevel = 29
CFBG.Players.Count.In.Group = 1
CFBG.EvenTeams.MaxPlayersThreshold = 7

The balance system is sometimes not working properly as it creates teams that are completely wrong:

Example scenario 1:

4 players queue Warsong Gulch: 44, 44, 46, 49

Expected result: the system should create two teams of 49 and 44 vs 46 and 44

Actual result: the system (sometimes) creates two teams of 49 and 46 vs 44 and 44]

Completely wrong.

Example scenario 2:

4 players queue Warsong Gulch: 43, 44, 48, 49

Expected result: the system should create two teams of 49 and 43 vs 48 and 44

Actual result: the system (sometimes) creates two teams of 49 and 48 vs 44 and 43]

Completely wrong.

Not reproducible

Both the scenario mentioned above happened for real. Unfortunately it is not easy to reproduce this issue but it keeps happening from time to time, it is not rare and it is extremely annoying. An investigation must be made in order to spot and fix the cause.

battle stand does not work properly

chromiecraft/chromiecraft#384

There is a $20 open bounty on this issue. Add to the bounty at Bountysource.

Join as a Group doesn't work [$100]

Joining as a group (party) does not work.

It would be nice if it can work and somehow try (but of course cannot guarantee) to maintain the original group members within the same team.

EDIT: there is a bounty on this issue. To consider it fixed, it MUST be properly tested and ALL corner cases should work. Including all different configurations enabled, for example:

CFBG.BalancedTeams = 1
CFBG.Include.Avg.Ilvl.Enable = 1
CFBG.Players.Count.In.Group = 2
CFBG.EvenTeams.Enabled = 1
CFBG.EvenTeams.MaxPlayersThreshold = 5

There is a $100 open bounty on this issue. Add to the bounty at Bountysource.

Cfbg

In member function 'void CFBG::randomRaceMorph(uint8*, uint32*, TeamId, uint8, uint8)':
/home/azerothcore-wotlk/modules/mod-cfbg-master/src/CFBG.cpp:250:80: error: no m atching function for call to 'CFBG::getRandomRace()'
*race = getRandomRace({ RACE_ORC, RACE_TAUREN, RACE_TROLL } );
^
In file included from /home/azerothcore-wotlk/modules/mod-cfbg-master/src/CFBG.c pp:6:
/home/azerothcore-wotlk/modules/mod-cfbg-master/src/CFBG.h:126:11: note: candida te: 'template uint8 CFBG::getRandomRace(const uint8 (&)[N]) '
uint8 getRandomRace(const uint8 (&races)[N]);
^~~~~~~~~~~~~
/home/azerothcore-wotlk/modules/mod-cfbg-master/src/CFBG.h:126:11: note: templ ate argument deduction/substitution failed:
/home/azerothcore-wotlk/modules/mod-cfbg-master/src/CFBG.cpp:250:80: note: mis matched types 'unsigned char' and 'Races'
*race = getRandomRace({ RACE_ORC, RACE_TAUREN, RACE_TROLL } );
^
/home/azerothcore-wotlk/modules/mod-cfbg-master/src/CFBG.cpp:259:95: error: no m atching function for call to 'CFBG::getRandomRace()'
*race = getRandomRace({ RACE_ORC, RACE_TAUREN, RACE_TROLL, RACE_BLOODELF });
^
In file included from /home/azerothcore-wotlk/modules/mod-cfbg-master/src/CFBG.c pp:6:
/home/azerothcore-wotlk/modules/mod-cfbg-master/src/CFBG.h:126:11: note: candida te: 'template uint8 CFBG::getRandomRace(const uint8 (&)[N]) '
uint8 getRandomRace(const uint8 (&races)[N]);
^~~~~~~~~~~~~
/home/azerothcore-wotlk/modules/mod-cfbg-master/src/CFBG.h:126:11: note: templ ate argument deduction/substitution failed:
/home/azerothcore-wotlk/modules/mod-cfbg-master/src/CFBG.cpp:259:95: note: mis matched types 'unsigned char' and 'Races'
*race = getRandomRace({ RACE_ORC, RACE_TAUREN, RACE_TROLL, RACE_BLOODELF });
^
/home/azerothcore-wotlk/modules/mod-cfbg-master/src/CFBG.cpp:264:82: error: no m atching function for call to 'CFBG::getRandomRace()'
*race = getRandomRace({ RACE_ORC, RACE_TROLL, RACE_BLOODELF });
^
In file included from /home/azerothcore-wotlk/modules/mod-cfbg-master/src/CFBG.c pp:6:
/home/azerothcore-wotlk/modules/mod-cfbg-master/src/CFBG.h:126:11: note: candida te: 'template uint8 CFBG::getRandomRace(const uint8 (&)[N]) '
uint8 getRandomRace(const uint8 (&races)[N]);
^~~~~~~~~~~~~
/home/azerothcore-wotlk/modules/mod-cfbg-master/src/CFBG.h:126:11: note: templ ate argument deduction/substitution failed:
/home/azerothcore-wotlk/modules/mod-cfbg-master/src/CFBG.cpp:264:82: note: mis matched types 'unsigned char' and 'Races'
*race = getRandomRace({ RACE_ORC, RACE_TROLL, RACE_BLOODELF });
^
/home/azerothcore-wotlk/modules/mod-cfbg-master/src/CFBG.cpp:270:72: error: no m atching function for call to 'CFBG::getRandomRace()'
*race = getRandomRace({ RACE_TROLL, RACE_BLOODELF });
^
In file included from /home/azerothcore-wotlk/modules/mod-cfbg-master/src/CFBG.c pp:6:
/home/azerothcore-wotlk/modules/mod-cfbg-master/src/CFBG.h:126:11: note: candida te: 'template uint8 CFBG::getRandomRace(const uint8 (&)[N]) '
uint8 getRandomRace(const uint8 (&races)[N]);
^~~~~~~~~~~~~
/home/azerothcore-wotlk/modules/mod-cfbg-master/src/CFBG.h:126:11: note: templ ate argument deduction/substitution failed:
/home/azerothcore-wotlk/modules/mod-cfbg-master/src/CFBG.cpp:270:72: note: mis matched types 'unsigned char' and 'Races'
*race = getRandomRace({ RACE_TROLL, RACE_BLOODELF });
^
/home/azerothcore-wotlk/modules/mod-cfbg-master/src/CFBG.cpp:275:70: error: no m atching function for call to 'CFBG::getRandomRace()'
*race = getRandomRace({ RACE_ORC, RACE_BLOODELF });
^
In file included from /home/azerothcore-wotlk/modules/mod-cfbg-master/src/CFBG.c pp:6:
/home/azerothcore-wotlk/modules/mod-cfbg-master/src/CFBG.h:126:11: note: candida te: 'template uint8 CFBG::getRandomRace(const uint8 (&)[N]) '
uint8 getRandomRace(const uint8 (&races)[N]);
^~~~~~~~~~~~~
/home/azerothcore-wotlk/modules/mod-cfbg-master/src/CFBG.h:126:11: note: templ ate argument deduction/substitution failed:
/home/azerothcore-wotlk/modules/mod-cfbg-master/src/CFBG.cpp:275:70: note: mis matched types 'unsigned char' and 'Races'
*race = getRandomRace({ RACE_ORC, RACE_BLOODELF });
^
/home/azerothcore-wotlk/modules/mod-cfbg-master/src/CFBG.cpp:291:68: error: no m atching function for call to 'CFBG::getRandomRace()'
*race = getRandomRace({ RACE_ORC, RACE_TAUREN });
^
In file included from /home/azerothcore-wotlk/modules/mod-cfbg-master/src/CFBG.c pp:6:
/home/azerothcore-wotlk/modules/mod-cfbg-master/src/CFBG.h:126:11: note: candida te: 'template uint8 CFBG::getRandomRace(const uint8 (&)[N]) '
uint8 getRandomRace(const uint8 (&races)[N]);
^~~~~~~~~~~~~
/home/azerothcore-wotlk/modules/mod-cfbg-master/src/CFBG.h:126:11: note: templ ate argument deduction/substitution failed:
/home/azerothcore-wotlk/modules/mod-cfbg-master/src/CFBG.cpp:291:68: note: mis matched types 'unsigned char' and 'Races'
*race = getRandomRace({ RACE_ORC, RACE_TAUREN });
^
/home/azerothcore-wotlk/modules/mod-cfbg-master/src/CFBG.cpp:298:83: error: no m atching function for call to 'CFBG::getRandomRace()'
*race = getRandomRace({ RACE_ORC, RACE_TAUREN, RACE_BLOODEL F });
^
In file included from /home/azerothcore-wotlk/modules/mod-cfbg-master/src/CFBG.c pp:6:
/home/azerothcore-wotlk/modules/mod-cfbg-master/src/CFBG.h:126:11: note: candida te: 'template uint8 CFBG::getRandomRace(const uint8 (&)[N]) '
uint8 getRandomRace(const uint8 (&races)[N]);
^~~~~~~~~~~~~
/home/azerothcore-wotlk/modules/mod-cfbg-master/src/CFBG.h:126:11: note: templ ate argument deduction/substitution failed:
/home/azerothcore-wotlk/modules/mod-cfbg-master/src/CFBG.cpp:298:83: note: mis matched types 'unsigned char' and 'Races'
*race = getRandomRace({ RACE_ORC, RACE_TAUREN, RACE_BLOODEL F });
^
/home/azerothcore-wotlk/modules/mod-cfbg-master/src/CFBG.cpp:305:70: error: no m atching function for call to 'CFBG::getRandomRace()'
*race = getRandomRace({ RACE_ORC, RACE_BLOODELF });
^
In file included from /home/azerothcore-wotlk/modules/mod-cfbg-master/src/CFBG.c pp:6:
/home/azerothcore-wotlk/modules/mod-cfbg-master/src/CFBG.h:126:11: note: candida te: 'template uint8 CFBG::getRandomRace(const uint8 (&)[N]) '
uint8 getRandomRace(const uint8 (&races)[N]);
^~~~~~~~~~~~~
/home/azerothcore-wotlk/modules/mod-cfbg-master/src/CFBG.h:126:11: note: templ ate argument deduction/substitution failed:
/home/azerothcore-wotlk/modules/mod-cfbg-master/src/CFBG.cpp:305:70: note: mis matched types 'unsigned char' and 'Races'
*race = getRandomRace({ RACE_ORC, RACE_BLOODELF });
^
/home/azerothcore-wotlk/modules/mod-cfbg-master/src/CFBG.cpp:340:110: error: no matching function for call to 'CFBG::getRandomRace()'
*race = getRandomRace({ RACE_HUMAN, RACE_DWARF, RACE_GNOME, RACE_NIGHTELF, RACE_DRAENEI });
^
In file included from /home/azerothcore-wotlk/modules/mod-cfbg-master/src/CFBG.c pp:6:
/home/azerothcore-wotlk/modules/mod-cfbg-master/src/CFBG.h:126:11: note: candida te: 'template uint8 CFBG::getRandomRace(const uint8 (&)[N]) '
uint8 getRandomRace(const uint8 (&races)[N]);
^~~~~~~~~~~~~
/home/azerothcore-wotlk/modules/mod-cfbg-master/src/CFBG.h:126:11: note: templ ate argument deduction/substitution failed:
/home/azerothcore-wotlk/modules/mod-cfbg-master/src/CFBG.cpp:340:110: note: mi smatched types 'unsigned char' and 'Races'
*race = getRandomRace({ RACE_HUMAN, RACE_DWARF, RACE_GNOME, RACE_NIGHTELF, RACE_DRAENEI });
^
/home/azerothcore-wotlk/modules/mod-cfbg-master/src/CFBG.cpp:344:83: error: no m atching function for call to 'CFBG::getRandomRace()'
*race = getRandomRace({ RACE_HUMAN, RACE_DWARF, RACE_DRAENE I });
^
In file included from /home/azerothcore-wotlk/modules/mod-cfbg-master/src/CFBG.c pp:6:
/home/azerothcore-wotlk/modules/mod-cfbg-master/src/CFBG.h:126:11: note: candida te: 'template uint8 CFBG::getRandomRace(const uint8 (&)[N]) '
uint8 getRandomRace(const uint8 (&races)[N]);
^~~~~~~~~~~~~
/home/azerothcore-wotlk/modules/mod-cfbg-master/src/CFBG.h:126:11: note: templ ate argument deduction/substitution failed:
/home/azerothcore-wotlk/modules/mod-cfbg-master/src/CFBG.cpp:344:83: note: mis matched types 'unsigned char' and 'Races'
*race = getRandomRace({ RACE_HUMAN, RACE_DWARF, RACE_DRAENE I });
^
/home/azerothcore-wotlk/modules/mod-cfbg-master/src/CFBG.cpp:348:86: error: no m atching function for call to 'CFBG::getRandomRace()'
*race = getRandomRace({ RACE_DWARF, RACE_NIGHTELF, RACE_DRA ENEI });
^
In file included from /home/azerothcore-wotlk/modules/mod-cfbg-master/src/CFBG.c pp:6:
/home/azerothcore-wotlk/modules/mod-cfbg-master/src/CFBG.h:126:11: note: candida te: 'template uint8 CFBG::getRandomRace(const uint8 (&)[N]) '
uint8 getRandomRace(const uint8 (&races)[N]);
^~~~~~~~~~~~~
/home/azerothcore-wotlk/modules/mod-cfbg-master/src/CFBG.h:126:11: note: templ ate argument deduction/substitution failed:
/home/azerothcore-wotlk/modules/mod-cfbg-master/src/CFBG.cpp:348:86: note: mis matched types 'unsigned char' and 'Races'
*race = getRandomRace({ RACE_DWARF, RACE_NIGHTELF, RACE_DRA ENEI });
^

Compile faild

azerothcore/azerothcore-wotlk@2c6a692

003b09c

Windows 2019

Error C2065 'SMSG_CHAT_SERVER_MESSAGE': undeclared identifier modules D:\azerothcore\modules\mod-cfbg\src\CFBG.cpp 951

/src/CFBG.cpp:338:9: fatal error: no member named 'GetTeamStartLoc' in 'Battleground'

i used the newest azerothcore version,
when i build it , fatal error.

Original faction preference is not kept

GIVEN THAT there are 3 Alliance players and 1 Horde player
AND they all queue a certain BG

EXPECTED BEHAVIOUR: the 1 Horde player should join as Horde, there is no reason to put him in the Alliance

CURRENT BEHAVIOUR: teams appear to be random, sometimes the 1 Horde player goes into the Alliance

More specifically: the original faction of the player should be kept. Moving a player to the other faction should happen only when necessary

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

BG scoreboard does not show the current faction

Expected behaviour:

BG scoreboard should show the right faction (the faction that the player is currently playing in the BG)

Current behaviour:

BG scoreboard showing the player's original faction

This also affects the Warsong Gulch Flag showed in the map

There is a $40 open bounty on this issue. Add to the bounty at Bountysource.

[SUGGESTION] RESET COOLDOWN IN BATTLEGROUND [$20 awarded]

My suggestion is to add an option in the crossfaction .conf, for each Battleground that enters resets the Cooldown of items and spells.

The $20 bounty on this issue has been claimed at Bountysource.

Reddening of items after death

In battle when they die
Their item turns red
They need to repair this fix
Please

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

Teams should be balanced according to player level (and item level)

We are using

CFBG.Include.Avg.Ilvl.Enable = 1

but it does not seem to create balanced teams.

We started a 3 vs 3 BG at 10-19 where the teams were:

TEAM A: 3 players at level 10, 11 and 12
TEAM B: 2 players at level 13, 18 and 19

so it was completely unbalanced xD

I think we need a new config, such as

CFBG.BalancedTeams = 1

when enabled, teams should be balanced with levels AND by item level.

So that when a new player queues, it will end up with the team having the lowest character level (sum of all players).
If the level is the same, it will end up to the team having the lowest item level (sum of all players).

CFBG balance

The level of the players inside a battleground is not always balanced.

Scenario

4 characters

lvl 10
lvl 11
2x lvl 19

The first character lvl 10 join BG, one lvl 19 join BG -> result lvl 10 vs lvl 19

The other two join but the lvl 11 click on "Enter battle" for first -> in this case the CFBG see that the weak faction is the lvl 10 one, so it puts the lvl 11 with the lvl 10 and later it puts the lvl 19 with the other lvl 19

result -> 2x lvl 19 vs lvl 10,11

I reproduced this using the conf EvenTeams and LowLevelBalance enabled.

Deformation bug

When the shape changes in battle
Now the wolf bear or whatever
To become it
This comes out of the battle,
Its shape is fixed

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

Compilation errors.

Hello, Im using AzerothCore rev. 5f9ef5be830b+ 2021-11-10 11:01:04 +0000 (master branch) (Unix, debug, Static),

Other Modules :

mod-1v1-arena
mod-eluna-lua-engine
mod-learn-spells
mod-skip-dk-starting-area
mod-transmog.

First I had this error

I tried to fix it by changing SetFaction to setFaction and the I had this error.

Can Anybody help ? I don't want to do further changements.

10+ players in warsong per faction [$15]

Originally reported chromiecraft/chromiecraft#335

WHAT CLIENT DO YOU PLAY ON?

enGB
enUS
other (specify)

FACTION

Alliance
Horde

CONTENT PHASE:

Generic
1-19
20-29
30-39

CURRENT BEHAVIOUR:

10+ players in warsong.

EXPECTED BLIZZLIKE BEHAVIOUR:

Max players per faction is 10.

STEPS TO REPRODUCE THE PROBLEM:

EXTRA NOTES:

Not sure how this happened.
Happen for both faction.

AC HASH/COMMIT:

chromiecraft/azerothcore-wotlk@9d4eebc

OPERATING SYSTEM:

Ubuntu 20.04

MODULES:

OTHER CUSTOMIZATIONS:

None.

SERVER:

ChromieCraft

There is a $15 open bounty on this issue. Add to the bounty at Bountysource.

[Suggestion] Lessen system messages

In the modules current state, there is one announcement per player which joins a battleground.
For example, if there are 4 characters queued and the bg pops open, there will be 4 announcements at once.

I suggest a tiny delay, to limit the announcement per BG to the actual number of players.

Also, if a bg ends, many players will instantly rejoin the queue. If there are not enough players instantly to pop the next bg, the module should wait for - lets say for example - 5 seconds after the number of queued players changes.

Compilation Failure

Azerothcore based current build

azerothcore / mod-cfbg Goto Github PK

mod-cfbg's Introduction

AzerothCore module

CrossFaction Battleground

Module currently requires:

About module

Features:

Config option (CFBG.conf.dist)

How to install

Edit module configuration (optional)

Usage

Credits

mod-cfbg's People

Contributors

Stargazers

Watchers

Forkers

mod-cfbg's Issues

What client do you play on?

Faction

Content Phase:

Current Behaviour

Expected Behaviour

Source

Steps to reproduce the problem

Extra Notes

AC rev. hash/commit

Operating system

Modules

Customizations

Server

What client do you play on?

Faction

Content Phase:

Current Behaviour

Expected Blizzlike Behaviour

Source

Steps to reproduce the problem

Extra Notes

AC rev. hash/commit

Operating system

Modules

Customizations

Server

How this module should work

1. With option CFBG.BalancedTeams

2. With option CFBG.EvenTeams.Enabled

STEPS TO REPRODUCE THE PROBLEM:

EXTRA NOTES:

AC HASH/COMMIT:

OPERATING SYSTEM:

MODULES:

OTHER CUSTOMIZATIONS:

SERVER:

WHAT CLIENT DO YOU PLAY ON?

FACTION

CONTENT PHASE:

CURRENT BEHAVIOUR:

EXPECTED BLIZZLIKE BEHAVIOUR:

STEPS TO REPRODUCE THE PROBLEM:

EXTRA NOTES:

AC HASH/COMMIT:

OPERATING SYSTEM:

MODULES:

OTHER CUSTOMIZATIONS:

SERVER:

What client do you play on?

Faction

Content Phase:

Current Behaviour

Expected Blizzlike Behaviour

Source

Steps to reproduce the problem

Extra Notes

AC rev. hash/commit

Operating system

Modules

Customizations

Server

Example scenario 1:

1. With option `CFBG.BalancedTeams`

2. With option `CFBG.EvenTeams.Enabled`