azerothcore / mod-guild-zone-system Goto Github PK

View Code? Open in Web Editor NEW

9.0 11.0 13.0 1.16 MB

AzerothCore Module

Home Page: http://www.azerothcore.org

License: GNU General Public License v3.0

CMake 2.54% Shell 4.78% C++ 91.85% C 0.82%

core-module azerothcore-module azerothcore

mod-guild-zone-system's Introduction

AzerothCore

mod-guild-zone-system

This is a module for AzerothCore

Latest build status with azerothcore:

Features:

Allows Guild Masters to Purchase/Sell Zones.
Once purchased, Guild Masters and Guild members can port to your designated Guild House location set for that Zone.

This module currently requires:

AzerothCore v1.0.1+

How to install

Simply place the module under the modules folder of your AzerothCore source folder.
Re-run cmake and launch a clean build of AzerothCore
Navigate to modules, apply the SQL files in the correct databases.

Usage

Spawn NPC ID 55005 .npc a 55005
Create a guild .guild create MyCharacter "MyGuild"
Talk to the NPC

Uninstall

To remove the SQL, use these queries in the world database:

-- The example of the creature --
DELETE FROM `creature_template` WHERE entry=55005;

-- All creatures for guild houses --
DELETE FROM `creature` WHERE id1=55005;

DROP TABLE `guildhouses`;

Credits

Bloodication: Original author probably
Poszer: Port into a module

AzerothCore: repository - website - discord chat community

mod-guild-zone-system's People

Contributors

Stargazers

Watchers

Forkers

irome devovh dholex tbcstar suprsokr dad-4i legends-of-azeroth nelnamara bogir shadowburn-entertainment haelius99 feng380 shoro2

mod-guild-zone-system's Issues

What does this module do?

So this module allows you to buy 1 zone for your guild to teleport from a list of unaccessible zones.

Once all the zones have been bought, no more guild houses 🤣

A zone can be sold but only manually.

That's all lol

Cost of a 1k gold does not work

if a guildmaster is going to buy the house even though he doesn't have the required money (1k gold) it is sold, since the only thing the module does is modify the money (player->ModifyMoney(-10000000);) and it doesn't check the existing amount of the player.

There is also the possibility of a bug with the increase in money, I buy the area with 0 money and sell it for 500 gold, I trade it to another pj and do the same operation.

The ideal would be to check the existing money in the bank of the brotherhood if it is equal to 1k buy, and when selling the same as the money, go to the bank of the brotherhood

@acidmanifesto

mod-guild-zone-system + mod-guildhouse

maybe a merger between those two modules I get a good one

Sql needs to be checked

COLUMN spawndist now is wander_distance

Wrong field

There is no mindmg field in the Creature Template table

1054 - Unknown column 'mindmg' in 'field list'

Barbz' suggestions

For anyone interested in this module, it's a good basis but it's far from being good at the moment. Just a few suggestions coming to my mind right now

Each zone is empty, deprived of NPCs, gameobjects etc... The zones could have NPCs already spawned for the guilds. It would require quite a lot of "world building" to fill all the zones with the same NPCs.
Other solution: give the player the ability to spawn NPCs and gameobjects with items/spells, more flexibility, more customization, less worldbuilding work but harder to implement
A zone should be buyable only for X time, configurable in the conf. Then can be bought again before the timer ends for the guild members. Default: 1 month
Maybe add the possibility of phasing like in the other mod-guildhouse ? but could be simply a config option as the absence of phasing (and the limited amount of zones) is also quite interesting
Allow the user to buy the zones with a custom currency/token instead of gold (configurable or have the vendor sell the tokens against gold)
Put an innkeeper for hearthstones :P and put a portal to go back

Revert SQL changes

Run this on your world DB if you want to revert the module's SQL:

-- The example of the creature --
DELETE FROM `creature_template` WHERE entry=55005;

-- All creatures for guild houses --
DELETE FROM `creature` WHERE id=55005;

DROP TABLE `guildhouses`;

Compilation error

/home/wow/aznuevo/modules/mod-guild-zone-system/src/guildmaster.cpp:77:24: error: no member named 'MonsterWhisper' in 'Creature'
_creature->MonsterWhisper(MSG_INCOMBAT, player);
~~~ ^
/home/wow/aznuevo/modules/mod-guild-zone-system/src/guildmaster.cpp:87:24: error: no member named 'MonsterWhisper' in 'Creature'
_creature->MonsterWhisper(MSG_NOGUILDHOUSE, player);
~~~ ^
/home/wow/aznuevo/modules/mod-guild-zone-system/src/guildmaster.cpp:122:24: error: no member named 'MonsterWhisper' in 'Creature'
_creature->MonsterWhisper(MSG_NOFREEGH, player);
~~~ ^
/home/wow/aznuevo/modules/mod-guild-zone-system/src/guildmaster.cpp:145:28: error: no member named 'MonsterWhisper' in 'Creature'
_creature->MonsterWhisper(msg, player);
~~~ ^
/home/wow/aznuevo/modules/mod-guild-zone-system/src/guildmaster.cpp:160:24: error: no member named 'MonsterWhisper' in 'Creature'
_creature->MonsterWhisper(msg, player);
~~~ ^
/home/wow/aznuevo/modules/mod-guild-zone-system/src/guildmaster.cpp:175:24: error: no member named 'MonsterWhisper' in 'Creature'
_creature->MonsterWhisper(MSG_GHOCCUPIED, player);
~~~ ^
/home/wow/aznuevo/modules/mod-guild-zone-system/src/guildmaster.cpp:183:20: error: no member named 'MonsterWhisper' in 'Creature'
_creature->MonsterWhisper(MSG_CONGRATULATIONS, player);
~~~ ^
/home/wow/aznuevo/modules/mod-guild-zone-system/src/guildmaster.cpp:196:24: error: no member named 'MonsterWhisper' in 'Creature'
_creature->MonsterWhisper(msg, player);
~~~ ^
/home/wow/aznuevo/modules/mod-guild-zone-system/src/guildmaster.cpp:238:24: error: no member named 'MonsterWhisper' in 'Creature'
_creature->MonsterWhisper(MSG_NOTINGUILD, player);
~~~ ^

Compiled on ubuntu server 20.04, clang 10
AZ rev: b4a14214ca57611f023859c7d4a115b9815effb1

Use Old Gossip API

uses the old gossip api not work for the lastest version of azerothcore