aziraphale / email-address-validator Goto Github PK

I mentioned it in #3 already, but to make sure it's not forgotten, here's a proper issue.

https://packagist.org/packages/aziraphale/email-address-validator currently lists version 2.0.0 from 2015 only. A new git tag should be created to make the recent changes available via composer.

There are multiple problems with the tests:

• phpunit is not in the dev requirements
• phpunit is required at the top (shouldn't be needed when phar or autoloading is used)
• EmailAddressValidator is required at the top (should be autoloaded via composer)
• Tests call EmailAddressValidator::check_email_address() but should be calling EmailAddressValidator::checkEmailAddress()

Even though the email spec say the local part should be at max 64 characters, the comment says servers are encouraged to accept more than 64. This library is used by Dokuwiki to validate emails. Todoist uses emails where the local part is longer than 64 characters. Given that there are "valid" emails longer than 64 characters, this should be removed, increased, or at least adjustable by a parameter. It is better to let an "invalid" email through than to block a valid email. An invalid email will fail regardless upon being sent (as if it is valid format but just hasn't been created). A "valid" email getting rejected prevents it from being used at all with no possibility of a workaround.

Here is the line in question:

We're currently using a patched version of the old Google Code version which has an option to allow local addresses (see 02700828f76adcfc63a9dafe75ffa941cdb9831b).

It would be possible to implement this in your version by passing a second parameter to checkEmailAddress() and checkDomainPotion() but I wonder if making this static was such a good idea...