Archive command should also archive cancelled task about plaintasks HOT 7 CLOSED

Hi!
It was me who implemented cancelled task functionality; and I must admit that archive feature was missed deliberately.

I understand there might be different workflows and meanings, but, in my view, cancelled task doesn't means 'basta', it means that currently or in near future this can't be done or doesn't need to be done, but sometime or in some specific context cancelled task might be done.

So I don't want to say that functionality is needless, I'm saying that without ability to see from which project cancelled task was, archiving those task is kinda pointless, isn't it?

There is plan for this: 'in archive list, prefix task with project name, add specific scope for project prefixes'. So let's just wait until this will be implemented, shall we?

from plaintasks.

I merged this pull request cause for now it fills buggy that archive command can not archive cancelled tasks.
But also agree with @vovkkk, when I've got some time to add some semantic meaning to done and cancelled tasks then we can archive them to separate projects. done tasks can go to the archive project at the bottom while cancelled tasks can go to another project name "Pending" at the bottom their respective project.

It feels like we need some sort of testing, in order to be able more features at the moment or we're gonna break things here and there all the time. it started as simple plugin with 3 commands and now people are asking for more and more features. I'll to keep it clean and simple but some of those great ideas are hard to resist.

from plaintasks.

Okay, after all, I'm even glad you merged it, so we will move forward faster :)

@hindol did you try to archive when you have few done and cancelled tasks?

 ✔ 1 @done (12-11-24 18:29)
 ✘ 2 @cancelled (12-11-24 18:29)
 ✔ 3 @done (12-11-24 18:29)
 ✘ 4 @cancelled (12-11-24 18:29)

For me it ruin almost entire list...

I thought about this for removing:

tfr = done_tasks + canc_tasks
tfr.sort()
for t in reversed(tfr):
    self.view.erase(edit, self.view.full_line(t))

But it brings another bug: unnecessary line breaks...
upd: I mean unnecessary line breaks in archive list after archiving another task(s).

from plaintasks.

@vovkkk Unfortunately, you are right. Things do break when I have a few done and a few cancelled tasks mixed together. I have created a fix for the same. Will be sending _you_ a pull request first. Test and tell me if it still has problems.

from plaintasks.

@hindol I'm actually confused where better to comment :) (there're three places now: two pr's and this thread)

Yes, it seems still has problems:

Try to create new list, new task, mark as done, archive.
For me it doesn't run archive command.
If you already have archive list and few archivable tasks it demands to press ctrl+shift+a twice (at least) to archive them all.

Also, I think it was actually better to place tuples in two different lists, so we had more flexibility, interact with them separately if it will be necessary in future (of course, I may be wrong).

from plaintasks.

@vovkkk In the earlier approach where you merged two lists and sorted, I am not able to find _unnecessary line breaks_. How do I reproduce the problem?

For me, this version works without problems for both newly created lists and old lists.

from plaintasks.

For me, this version works without problems for both newly created lists and old lists.

Yeah, me too! Cheerio!

About line breaks - nevermind, I just didn't change adding, so it silly added both done_tasks and canc_tasks even if one of them was empty.

from plaintasks.