azrood / dctbot Goto Github PK

We need to update this.

New monthly url are :

http://www.dctrad.fr/app.php/releases/{year}/{month}

Issue in dealabs :

2020-04-17 19:26:38,948 Bot: |                 discord.ext.tasks |    ERROR | Internal background task failed.
Traceback (most recent call last):
  File "/home/ady/.local/lib/python3.6/site-packages/discord/ext/tasks/__init__.py", line 68, in _loop
    await self.coro(*args, **kwargs)
  File "/sftp/dctbot/incoming/dctbot/cogs/dealabs.py", line 41, in auto_free_games
    free_game_list = await get_free_games()
  File "/sftp/dctbot/incoming/dctbot/cogs/dealabs.py", line 26, in get_free_games
    for r in res
  File "/sftp/dctbot/incoming/dctbot/cogs/dealabs.py", line 27, in <listcomp>
    if "jeu" in r[0].text
IndexError: list index out of range

In line :

your should use expansion (*args) :
like : https://discordpy.readthedocs.io/en/latest/ext/commands/commands.html#variable

asyn def foo(ctx, *args):

In doing so, args will be a list (of variable lenght).
That is what you want to do.

The way you did it (with keyword-only argument), ie def foo(ctx, date, *, args="")
puts all your parameters (after date) in a single string.

And then you need to split it :

So basically, what you do is forcing python to make a single string, and not a list.
And then, split that string, to get back to a list...

🤣

typo in :

J'en connais qui a vu la mort devant en face !

bonjourmadame fails when video.

I managed to get the last 2 items from feedburner (see attachments) with following code :

#!/usr/bin/python3
# -*-coding:utf-8 -*-
import requests
from bs4 import BeautifulSoup

madames = "http://feeds2.feedburner.com/BonjourMadame"
res = requests.get(madames)
soup = BeautifulSoup(res.text, "lxml")

items = soup.find_all('item', limit=2)

print("Video item")
print("------------------------------------------------------------")
print(items[0].prettify())
print("============================================================")
print("============================================================")
print("Image item")
print("------------------------------------------------------------")
print(items[1].prettify())

See attachment (first item has no img tag but a video one).
out.txt

We have to test it, but I think the tests :

in gifadd and gifdelete are not needed anymore, since we use the decorator @commands.is_owner

https://discordpy.readthedocs.io/en/latest/ext/commands/api.html#discord.ext.commands.Bot.is_owner

Since aiohttp is a dependacy of discord.py, and it's not source of more import problems or anything, we should probably start replacing requests.get() calls by async aiohttp calls.

Maybe we should use "has_role" decorator in help, team, and clear

To replace if else checks like :

if ctx.author.top_role >= bot.role_dcteam:

We should rename dcteam_id to main_guild_id or something

WARNING ⚠️
We will have to update secret.py on server, otherwise it will BREAK

I love this
1a8e1bb

It's really smart and interesting, but it's not working ! 🤣🤣

Problem with boolean value stored as string :

    "ph": {
        "public": true,
        "url": "https://media1.tenor.com/images/c9fd95f1d85889081532373d16432727/tenor.gif"
    },
    "quadran": {
        "public": "true",
        "url": "https://media1.tenor.com/images/3a7eeaf4e2a1fdfd0d00167f58b54c69/tenor.gif?itemid=12896767"
    },

Replace "roles" with "general" in

Replace 10 by 24 hours (frequency)

Also :

with date lib
test date.today().weekday() value to see if not Saturday or Sunday

date.weekday()

On pourrait peut-être faire title, url = await latests_madame() ?
avec lates_madame() qui ferait un return title, url ?

title, on le trouverait avec un item.find('title')

Pour afficher le titre (genre "Madame Vendredi où l’amour de l’art.")

après, suffirait de l'envoyer (séparément de l'image) avec un 2ème send.
(soit comme ça, en texte, soit en faisant un set_footer sur un embed vide.

Qu'en penses-tu ?