Light

azurapi / azurapi-js Goto Github PK

View Code? Open in Web Editor NEW

33.0 9.0 4.0 12.27 MB

Open Source Unofficial json based api that returns Azur Lane data

License: GNU General Public License v3.0

JavaScript 95.74% TypeScript 4.25% Shell 0.01%

azur-lane api azur lane azurlane shipgirls waifu shipfus azurlane-api

azurapi-js's People

Contributors

Stargazers

Watchers

Forkers

tsukugi thelord999808 sp3cker mevas

azurapi-js's Issues

[BUG] `ships.get("Enterprise")` returns two ships – no way to specify which ship you meant.

To Reproduce
This code:

import { AzurAPI } from "@azurapi/azurapi";

(() => {
  const client = new AzurAPI();

  console.log(client.ships.get("Enterprise"));
})();

logs:

[
  {
    wikiUrl: 'https://azurlane.koumakan.jp/wiki/Enterprise_(Royal_Navy)',
    id: '557',
    _gid: 20232,
    _sid: [ 202321, 202322, 202323, 202324 ],
    _code: 557,
    names: {
      en: 'Enterprise',
      code: 'HMS Enterprise',
      cn: '进取',
      jp: 'エンタープライズ',
      kr: '엔터프라이즈'
    },
...
},
{
    wikiUrl: 'https://azurlane.koumakan.jp/wiki/Enterprise',
    id: '077',
    _gid: 10706,
    _sid: [
      107061, 107062,
      107063, 107064,
      900184, 900252,
      900335
    ],
    _code: 77,
    names: {
      en: 'Enterprise',
      code: 'USS Enterprise',
      cn: '企业',
      jp: 'エンタープライズ',
      kr: '엔터프라이즈',
      tw: '企業'
    },
...
}
]

Expected behavior
This is actually 100% correct behavior.
However, there's no way to further narrow down between ships. I think it'd be best if we allow for .get to take check the names.code property as a search term to distinctify the ships.

Recommend Projects

React

A declarative, efficient, and flexible JavaScript library for building user interfaces.
Vue.js

🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
Typescript

TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
TensorFlow

An Open Source Machine Learning Framework for Everyone
Django

The Web framework for perfectionists with deadlines.
Laravel

A PHP framework for web artisans
D3

Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

javascript

JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
web

Some thing interesting about web. New door for the world.
server

A server is a program made to process requests and deliver data to clients.
Machine learning

Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
Visualization

Some thing interesting about visualization, use data art
Game

Some thing interesting about game, make everyone happy.

Recommend Org

Facebook

We are working to build community through open source technology. NB: members must have two-factor auth.
Microsoft

Open source projects and samples from Microsoft.
Google

Google ❤️ Open Source for everyone.
Alibaba

Alibaba Open Source for everyone
D3

Data-Driven Documents codes.
Tencent

China tencent open source team.