Description

Connectivity sample still sends x-ms-flighting-udf-execution-manually-enabled.

Repro steps

Use connectivity sample.

Expected behavior

No need for x-ms-flighting-udf-execution-manually-enabled.

Actual behavior

x-ms-flighting-udf-execution-manually-enabled is sent.

Logs

   10/5/2018 2:13:45 PM> Sending message: {"SensorValue":"true"} Properties: { 'DigitalTwins-Telemetry': '1.0','DigitalTwins-SensorHardwareId': 'SAMPLE_SENSOR_MOTION','CreationTimeUtc': '2018-10-05T21:13:45.3363177Z','x-ms-client-request-id': '2d0a1d07-5065-43e2-9421-61ec3fedd7ad','x-ms-flighting-udf-execution-manually-enabled': 'true', }

Description

Hi, While running following command (dotnet run ProvisionSample), getting response status :-
Response Status: 403, Forbidden {"error":{"code":"403.600.000.001","message":"System error."}}

Repro steps

Please provide the steps required to reproduce the problem.

1. dotnet run ProvisionSample

2. authenticated with azure login.

3. error --Response Status: 403, Forbidden {"error":{"code":"403.600.000.001","message":"System error."}}

Expected behavior

should be get connectionstring

Description

baseUrl in settings without a trailing dash breaks api calls

Repro steps

see above

Expected behavior

It should work with or without

Actual behavior

It doesn't

Logs

If applicable, please provide any logs or output from the sample.

Known workarounds

Add a trailing /

Related information

• Operating system
• CoreCLR version (run dotnet --version)

Description

As provisionSample.yaml file does not contain size setting for IoT Hub resource, default value of XSmall (XS) size is used during POST request to /api/v1.0/resources endpoint, which means that underlying IoT Hub resource is being created in free tier. As there is limitation of one free IoT Hub per subscription, this provisioning ends with error in case there was free IoT Hub already deployed to subscription before.

Repro steps

Deploy free IoT Hub instances to Azure subscription and afterwards run Digital Twins provision Sample

Expected behavior

Add and discuss option to select size of IoT Hub within sample and quickstart docs

Known workarounds

Add size propety to ResourceDescription class + add size setting to provisionSample.yaml file in following way:

• name: Quickstart Building
  type: Venue
  resources:
  • type: IoTHub
    size: M (available option XS, S, M, L, XL, XXL)

• Operating system
  N/A
• CoreCLR version (run dotnet --version)
  N/A

Please review this article. There might be opportunity to simplify sample project and documentation.

https://docs.microsoft.com/en-us/azure/key-vault/service-to-service-authentication

This is how I modified sample to get it to run in the context of logged in user.

        private static async Task<HttpClient> SetupHttpClient(ILogger logger, AppSettings appSettings)
        {
            var httpClient = new HttpClient(new LoggingHttpHandler(logger))
            {
                BaseAddress = new Uri(appSettings.BaseUrl),
            };

            var tokenProvider = new AzureServiceTokenProvider();
            var accessToken = await tokenProvider.GetAccessTokenAsync("0b07f429-9f4b-4714-9392-cc5e8e80c8b0");

            //var accessToken = (await Authentication.GetToken(logger, appSettings));
            httpClient.DefaultRequestHeaders.Add("Authorization", "Bearer " + accessToken);
            httpClient.DefaultRequestHeaders.Add("x-ms-flighting-udf-execution-manually-enabled", "true");
            return httpClient;
        }

@sup-s, you might be interested in this as well.

Description

I have both the data generator and the occupancy checker running. For the entire runtime of both, it never showed up as being good, it was always

"Name: Focus Room A1
Id: 9b8d36b1-5873-480b-bd8c-216245dbcac3
Value: Room is not available or air quality is poor"

Offline discussion in the bug bash room seemed to indicate that perhaps the range values were too sensitive and should be adjusted so people are more inclined to get a result in which the room is just right.

Repro steps

I ran through the steps documented here: https://review.docs.microsoft.com/en-us/azure/digital-twins/tutorial-facilities-udf?branch=pr-en-us-54424
(and the prerequisites)

Description

It would be useful not have to rerun devicelogin auth as often as is required currently.

Repro steps

Run any command (eg dotnet run GetAvailableAndFreshSpaces) more than once in short succession.

Expected behavior

Only the first should cause devicelogin

Actual behavior

Each call requires it

I think there is some opportunity to apply more OO patterns.

Description

I'm on the following page: https://github.com/Azure-Samples/digital-twins-samples-csharp/blob/master/occupancy-quickstart/readme.md

The "Update appsettings.json using a text editor" should refer to it as appSettings.json to be consistent on casing.
The following commands have a couple of issue:

Run the app (and see usage)
dotnet restore
cd src
dotnet run

dotnet restore has to be run from within src, so the first two lines should be reversed in order. Also, the "dotnet run" doesn't actually run the app as would be implied by "Run the app", it just shows the usage.

Additionally, it would be helpful for the initial part of this sample to be linking to the tutorial that lets you create the Digital Twins instance.

Could not find a part of the path 'C:\Sources\2018-10-05-bugbash\digital-twins-samples-csharp\occupancy-quickstart\src\bin\Debug\netcoreapp2.1\actions\provisionSample.yaml'.

Exception: System.IO.DirectoryNotFoundException: Could not find a part of the path 'C:\Sources\2018-10-05-bugbash\digital-twins-samples-csharp\occupancy-quickstart\src\bin\Debug\netcoreapp2.1\actions\provisionSample.yaml'.
   at System.IO.FileStream.ValidateFileHandle(SafeFileHandle fileHandle)
   at System.IO.FileStream.CreateFileOpenHandle(FileMode mode, FileShare share, FileOptions options)
   at System.IO.FileStream..ctor(String path, FileMode mode, FileAccess access, FileShare share, Int32 bufferSize, FileOptions options)
   at System.IO.StreamReader..ctor(String path, Encoding encoding, Boolean detectEncodingFromByteOrderMarks, Int32 bufferSize)
   at System.IO.StreamReader..ctor(String path)
   at Microsoft.Azure.DigitalTwins.Samples.Actions.ProvisionSample(HttpClient httpClient, ILogger logger) in C:\Sources\2018-10-05-bugbash\digital-twins-samples-csharp\occupancy-quickstart\src\actions\provisionSample.cs:line 19
   at Microsoft.Azure.DigitalTwins.Samples.Program.Main(String[] args) in C:\Sources\2018-10-05-bugbash\digital-twins-samples-csharp\occupancy-quickstart\src\program.cs:line 49