Giter VIP home page Giter VIP logo

Comments (3)

dcristoloveanu avatar dcristoloveanu commented on September 27, 2024

Hi @yaweiw

I think what should happen here in BUFFER_Create is that we should succeed even if the size is 0. Then in cases where the code that uses BUFFER does not want to care what the size of the buffer being created is, the BUFFER_Create calls succeed even if the size is 0.

In order to streamline contributing the change:

  • Let's have the PR against develop
  • Please make sure to update the .md requirement doc for buffer in the devdoc folder in order to state that BUFFER_Create with 0 size shall succeed
  • Please add a unit test in the BUFFER test suite under tests.

I'll look for your PR so I can review it in a timely fashion.

Thanks for contributing,
/Dan

from azure-c-shared-utility.

yaweiw avatar yaweiw commented on September 27, 2024

@dcristoloveanu , ok

from azure-c-shared-utility.

dcristoloveanu avatar dcristoloveanu commented on September 27, 2024

This fix been merged.

from azure-c-shared-utility.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.