Comments (3)
Hi @yaweiw
I think what should happen here in BUFFER_Create is that we should succeed even if the size is 0. Then in cases where the code that uses BUFFER does not want to care what the size of the buffer being created is, the BUFFER_Create calls succeed even if the size is 0.
In order to streamline contributing the change:
- Let's have the PR against develop
- Please make sure to update the .md requirement doc for buffer in the devdoc folder in order to state that BUFFER_Create with 0 size shall succeed
- Please add a unit test in the BUFFER test suite under tests.
I'll look for your PR so I can review it in a timely fashion.
Thanks for contributing,
/Dan
from azure-c-shared-utility.
@dcristoloveanu , ok
from azure-c-shared-utility.
This fix been merged.
from azure-c-shared-utility.
Related Issues (20)
- azure-c-shared-utility/CMakeFiles/aziotsharedutil.dir/adapters/tlsio_openssl.c fails to build on Alpine HOT 4
- Does this code cause a memory leak? HOT 1
- How to port ”xio http proxy” in C-SDK HOT 4
- 25 Warnings in IOT code HOT 8
- OpenSSL3 compatibility HOT 1
- OpenSSL3 compatability - with OPENSSL_NO_DEPRECATED_3_0 defined, still buggy HOT 2
- socketio_berkeley: recv with MSG_NOSIGNAL causes errno 22 (EINVAL) HOT 1
- Access Violation in "uws_client.c" HOT 2
- Unable to Clone on Windows HOT 2
- Misleading error message in adapters\tlsio_openssl.c : on_underlying_io_open_complete HOT 3
- Building on ARM64 shows "target architecture: GENERIC" HOT 1
- uws_client: No indication that WebSocket has been closed, if close is initiated by server. HOT 2
- INCLUDES DESTINATION issue
- hard requirement on CURL HOT 1
- Segmentation fault caused by initiate_socket_connection in adapters/socketio_berkeley.c when DNS resolution failed HOT 2
- Unit tests are disabled for socketio_berkeley
- url decode not working for forms post that contain spaces. HOT 3
- openSSL 1.1.1n handhshake returning error code 2 HOT 3
- PKCS#8 not supported for Windows
- Error during speech-to-text conversion: tlsio_appleios_destroy called while not in TLSIO_STATE_CLOSED. HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from azure-c-shared-utility.