After the 0.3.0 release, I'm getting this error running eslint.

TypeError: Cannot read property 'location' of undefined
    at .../node_modules/eslint-plugin-monorepo/lib/rules/no-internal-import.js:63:38

I think one of the checks just needs to be moved up. I'll push up a proposed fix.

Sometimes in a monorepo one will forget to add a dependency to a package's package.json and it will continue to work because the dependency was hoisted from another package, or it is installed in the root. This means the package cannot be individually installed so should be prevented.

I'm trying out this rule and it's not doing flagging anything. I suspect that's because I'm using npm workspaces? Note that eslint-plugin-monorepo-cop is working for me.

Our repo is structured into yarn workspaces like this:

• applications/app1
• applications/app2
• common/c1
• common/c2

The desired rule is that applications might import from packages common/c1 and common/c2, but never from another application. In other words, in app1 there must never be an import from app2.

Currently we use depencency-cruiser for such advanced checks. Sounds like a good use case for this plugin though.

Error while loading rule 'monorepo/no-internal-import': unable to find monorepo packages
Error: Error while loading rule 'monorepo/no-internal-import': unable to find monorepo packages
    at exports.default (/Users/haroen/git/eslint-config-algolia/node_modules/eslint-plugin-monorepo/lib/get-packages.js:44:9)
    at Object.create (/Users/haroen/git/eslint-config-algolia/node_modules/eslint-plugin-monorepo/lib/rules/no-internal-import.js:32:44)
    at Object.keys.forEach.ruleId (/Users/haroen/git/eslint-config-algolia/node_modules/eslint/lib/linter.js:925:44)
    at Array.forEach (<anonymous>)
    at Linter._verifyWithoutProcessors (/Users/haroen/git/eslint-config-algolia/node_modules/eslint/lib/linter.js:865:35)
    at preprocess.map.textBlock (/Users/haroen/git/eslint-config-algolia/node_modules/eslint/lib/linter.js:994:35)
    at Array.map (<anonymous>)
    at Linter.verify (/Users/haroen/git/eslint-config-algolia/node_modules/eslint/lib/linter.js:993:42)
    at Linter.verifyAndFix (/Users/haroen/git/eslint-config-algolia/node_modules/eslint/lib/linter.js:1085:29)
    at processText (/Users/haroen/git/eslint-config-algolia/node_modules/eslint/lib/cli-engine.js:179:32)

I get this when running the linting in a project that doesn't have a monorepo because I want to put it in a sharable config. It would be nice if the plugin would just bail out in case there's no monorepo

I ran eslint --fix on my monorepo and it correctly identified a relative import as an error but did not fix it, even though this plugin says the relative import error is autofixable.

My understanding of this rule is that it's meant to prevent packages in the monorepo from importing files that exist locally, but would not be present after publishing to NPM.

It's also preventing valid internal imports of files that we know do get published to NPM, e.g. anything that is listed in the files array of package.json. For example if we know that package-a has files: ["lib"] in it's package.json, we should be able to tell that an import like import foo from 'package-a/lib/foo.js' is safe.

Would you be open to a flag that allowed these sort of internal imports?

get-monorepo-packages now support yarn 1.4.2+ workspaces format

feat: support yarn 1.4.2+ workspaces format

"workspaces": {
  "packages": ["packages/*"],
}

• nohoist in Workspaces | Yarn Blog

If eslint-plugin-import is not installed the plugin will throw the following error:

Resolve error: unable to load resolver "node".  monorepo/no-relative-import

when trying to resolve an import statement.

I not sure why installing eslint-plugin-import solves this issue (maybe incompatible with @typescript-eslint?). Is there a better way to fix this?