Giter VIP home page Giter VIP logo

lajolla_public's People

Contributors

alstonxiao avatar arthur-x avatar bachili avatar cjkkkk avatar jf514 avatar ken2576 avatar th3charlie avatar tonyzyt2000 avatar weichenliu avatar yashbelhe avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar

lajolla_public's Issues

Questions about building the project

At first I clone the whole project, following the guide in the readme. My system is MacOS BigSur. Running

mkdir build

cmake ..

make -j8

There is a long error, the key part is

ld: warning: ignoring file ../embree/lib-linux/libembree3.so, building for macOS-x86_64 but attempting to link with file built for unknown-unsupported file format ( 0x7F 0x45 0x4C 0x46 0x02 0x01 0x01 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 )
ld: warning: ignoring file ../embree/lib-linux/libembree3.so, building for macOS-x86_64 but attempting to link with file built for unknown-unsupported file format ( 0x7F 0x45 0x4C 0x46 0x02 0x01 0x01 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 )
Undefined symbols for architecture x86_64:
"_rtcAttachGeometry", referenced from:
register_embree_op::operator()(Sphere const&) const in liblajolla_lib.a(shape.cpp.o)
register_embree_op::operator()(TriangleMesh const&) const in liblajolla_lib.a(shape.cpp.o)
decltype(auto) std::__1::__variant_detail::__visitation::__base::__dispatcher<0ul>::__dispatch<std::__1::__variant_detail::__visitation::__variant::__value_visitor<register_embree_op>&&, std::__1::__variant_detail::__base<(std::__1::__variant_detail::_Trait)1, Sphere, TriangleMesh> const&>(std::__1::__variant_detail::__visitation::__variant::__value_visitor<register_embree_op>&&, std::__1::__variant_detail::__base<(std::__1::__variant_detail::_Trait)1, Sphere, TriangleMesh> const&) in liblajolla_lib.a(shape.cpp.o)

I thought it was the problem that the libembree.dylib is not included in the project, so I modified the original cmakelist.txt.
CMakeLists.txt
With this cmakelists, I can build the project successfully without running the tests on intersection. However, that is where embree makes effect. The error log is the same as above.

ld: warning: ignoring file ../embree/lib-linux/libembree3.so, building for macOS-x86_64 but attempting to link with file built for unknown-unsupported file format ( 0x7F 0x45 0x4C 0x46 0x02 0x01 0x01 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 )
ld: warning: ignoring file ../embree/lib-linux/libembree3.so, building for macOS-x86_64 but attempting to link with file built for unknown-unsupported file format ( 0x7F 0x45 0x4C 0x46 0x02 0x01 0x01 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 )
Undefined symbols for architecture x86_64:
"_rtcAttachGeometry", referenced from:
register_embree_op::operator()(Sphere const&) const in liblajolla_lib.a(shape.cpp.o)
register_embree_op::operator()(TriangleMesh const&) const in liblajolla_lib.a(shape.cpp.o)
decltype(auto) std::__1::__variant_detail::__visitation::__base::__dispatcher<0ul>::__dispatch<std::__1::__variant_detail::__visitation::__variant::__value_visitor<register_embree_op>&&, std::__1::__variant_detail::__base<(std::__1::__variant_detail::_Trait)1, Sphere, TriangleMesh> const&>(std::__1::__variant_detail::__visitation::__variant::__value_visitor<register_embree_op>&&, std::__1::__variant_detail::__base<(std::__1::__variant_detail::_Trait)1, Sphere, TriangleMesh> const&) in liblajolla_lib.a(shape.cpp.o)

I thought it may be caused by search order. Following the guide in the discord, I swap the order between lib-linux and lib-macos in the FindEmbree.cmake, but nothing happens. I now even wonder what the real problem is.

Wrong function parameter order of eval() and pdf_sample_bsdf()

In material.h:

Spectrum eval(const Material &material,
              const Vector3 &dir_in,
              const Vector3 &dir_out,
              const PathVertex &vertex,
              const TexturePool &texture_pool,
              TransportDirection dir = TransportDirection::TO_LIGHT);

where we feed dir_in with dir_view and feed dir_out with dir_light (see path_tracing.h).

However in material.cpp:

Spectrum eval(const Material &material,
              const Vector3 &dir_light,
              const Vector3 &dir_view,
              const PathVertex &vertex,
              const TexturePool &texture_pool,
              TransportDirection dir) {
    return std::visit(eval_op{dir_light, dir_view, vertex, texture_pool, dir}, material);
}

the order is changed. Same situation to pdf_sample_bsdf().

It does not necessarily cause an error but indeed causes confusion.

Issues with building the project.

Hi, I want to mention that when I tried to build all, an error keeps jumping put: fatal error LNK1181: 'cannot open input file 'Release\lajolla_lib.lib'.

Then I tried to build lajolla_lib project, the following error occurs: error C2440: '<function-style-cast>': cannot convert from 'initializer list' to 'fl_exception'. I located to the error and found out that:

微信图片_20230111022419

If I change filename.c_str() into filename.generic_string() and then rebuild the whole solution, it turns out that everything works fine. So I guess these two lines may have to be revised?

微信截图_20230111023249

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.