Even-though comment lines like this contain function name including ():

* @see PollTestCase::_pollGenerateEdit().

it always gives a notice:

Line 135: @see should always be followed by a filename, a URL, class/interface name (optionally including method), or a function name including (). (Backdrop Docs) [comment_comment_see]

The latest Drupal 7 release of coder was version 7.x-2.6.
The current release of coder (works with all Drupal versions) is version 8.3.9

Should we create another release of coder_review that matches one of these Drupal version numbers, so that everyone knows which version of drupal's coder project this coder_review project aligns with? (I've been having a really hard time trying to track down where this was forked from, and what from the Drupal project has or has not already been included)

If we do change the version number, we should also rename the current branch to match.

Havent looked at this yet.

Related to Backdrop core issue: backdrop/backdrop-issues#4441

See also:

• https://www.drupal.org/project/drupal/issues/2993575
• https://www.drupal.org/project/coder/issues/3151838
• https://mobile.twitter.com/s_bergmann/status/1269917026107248641
• php/php-src#5685

Should we create a new branch to hold the updated version of PHPCS?
See #12

I am trying to get PHP_CodeSniffer working with Backdrop. So far I've got it installed on OS level by taking the following steps:

sudo pear channel-update pear.php.net
sudo pear install PHP_CodeSniffer
sudo ln -sv /var/www/docroot/modules/coder_review/coder_sniffer/Backdrop $(pear config-get php_dir)/PHP/CodeSniffer/Standards
sudo phpcs --config-set installed_paths /var/www/docroot/modules/coder_review/coder_sniffer
sudo phpcbf --config-set installed_paths /var/www/docroot/modules/coder_review/coder_sniffer

and now the both the phpcs -i and phpcbf -i commands output:

The installed coding standards are Squiz, Zend, MySource, PSR1, PEAR, PSR2, PSR12 and Backdrop

However, Backdrop is not picking up PHP_CodeSniffer and the status page still shows:

Coder Review 
PHP_CodeSniffer not installed. 
Coder review uses PHP_CodeSniffer to perform better code review checks; Code_Sniffer is not a requirement, but it is helpful. Use "drush install-php-code-sniffer" to help install.

Also running simple phpcs --standard=Backdrop -e command outputs the error:

docker@cli:/var/www/docroot/modules$ phpcs --standard=Backdrop -e

Fatal error: Class 'Generic_Sniffs_Strings_UnnecessaryStringConcatSniff' not found in /var/www/docroot/modules/coder_review/coder_sniffer/Backdrop/Sniffs/Strings/UnnecessaryStringConcatSniff.php on line 30

Call Stack:
    0.0011     371072   1. {main}() /usr/local/bin/phpcs:0
    0.0045     531672   2. PHP_CodeSniffer\Runner->runPHPCS() /usr/local/bin/phpcs:18
    0.0232     901376   3. PHP_CodeSniffer\Runner->init() /usr/local/lib/php/PHP/CodeSniffer/src/Runner.php:70
    0.0309    1138136   4. PHP_CodeSniffer\Ruleset->__construct() /usr/local/lib/php/PHP/CodeSniffer/src/Runner.php:332
    0.1454    1187120   5. PHP_CodeSniffer\Ruleset->registerSniffs() /usr/local/lib/php/PHP/CodeSniffer/src/Ruleset.php:217
    0.1455    1187120   6. PHP_CodeSniffer\Autoload::loadFile() /usr/local/lib/php/PHP/CodeSniffer/src/Ruleset.php:1156
    0.1458    1214456   7. include('/var/www/docroot/modules/coder_review/coder_sniffer/Backdrop/Sniffs/Strings/UnnecessaryStringConcatSniff.php') /usr/local/lib/php/PHP/CodeSniffer/autoload.php:167

docker@cli:/var/www/docroot/modules$ 

Any further hints would be appreciated on how to get PHP_CodeSniffer working with Backdrop.

For the notices that include references to documentation, an incorrect domain name is used. The one that is used (backdrop.org) is for a BDSM site.
Also, the specific references are for drupal.org nodes, not backdropcms.org nodes, so just changing the domain name is not enough.

Havent looked at that yet.

This needs test fixes

• I downloaded to modules/contrib/coder_review
• enabled coder_review
• the ops column on /admin/module are now all code review

Related drupal issues:

• D7 PHPCS 3.2.x https://www.drupal.org/project/coder/issues/2953138
• D7 PHPCS 2.2.x https://www.drupal.org/project/coder/issues/2342611
• D8 PHPCS 3.3.x https://www.drupal.org/project/coder/issues/2863898

There are 5 branches on this repo that look as though they were accidentally pushed here (instead of to the author's forks).

If these branches exist both here and on the author's fork, then it will be safe to remove them from this repo. If not, we should keep them until they are either moved to the fork, merged, or closed, so that the work is not lost.

• fix-backdrop-link
• serundeputy-patch-1
• ignore-vendor
• cs
• review