badili / erpnext Goto Github PK

In Print Documents, the Letterhead is not appearing in the PDF. Check

• Invoice
• Delivery Note

• If you're attaching unquoted items, you shouldn't need to show $0 value items in the quotation.
• Serial No is yet missing in the Excel Spreadsheet.

Purchase Order Receipt - Price List, Accepted Quantity, Purchase Order#

Hey,

I was looking through the code to add new get items from other doc types. I know we moved this to Phase 2, but can we do at least one document (i.e. Quotation from Supplier Quotation?)

get_items_from_bom: function() {
    var d = new frappe.ui.Dialog({
        title: __("Get Items from BOM"),
        fields: [
            {"fieldname":"bom", "fieldtype":"Link", "label":__("BOM"),
                options:"BOM", reqd: 1, get_query: function(){
                    return {filters: { docstatus:1 }}
                }},
            {"fieldname":"warehouse", "fieldtype":"Link", "label":__("Warehouse"),
                options:"Warehouse", reqd: 1, label:"For Warehouse"},
            {"fieldname":"fetch_exploded", "fieldtype":"Check",
                "label":__("Fetch exploded BOM (including sub-assemblies)"), "default":1},
            {fieldname:"fetch", "label":__("Get Items from BOM"), "fieldtype":"Button"}
        ]
    });
    d.get_input("fetch").on("click", function() {
        var values = d.get_values();
        if(!values) return;
        values["company"] = cur_frm.doc.company;
        frappe.call({
            method: "erpnext.manufacturing.doctype.bom.bom.get_bom_items",
            args: values,
            callback: function(r) {
                if(!r.message) {
                    frappe.throw(__("BOM does not contain any stock item"))
                } else {
                    $.each(r.message, function(i, item) {
                        var d = frappe.model.add_child(cur_frm.doc, "Material Request Item", "items");
                        d.item_code = item.item_code;
                        d.description = item.description;
                        d.warehouse = values.warehouse;
                        d.uom = item.stock_uom;
                        d.qty = item.qty;
                    });
                }
                d.hide();
                refresh_field("items");
            }
        });
    });
    d.show();
},

Supplier quotation screen, dropdown from make button is for customer quotation instead of Purchase order. The reason being is that the customer wants a flow that is easy to follow, so the next doc to be created should be the next one in the process regardless of if it is based on Sales or Buying.

Sales Invoice - Warehouse, Sales Order, Delivery Note, Payment Due Date, Quantity, Customer, Item

This should be allowed in the import list, and in the main fields, so that we can track against which Supplier Quotation, has the Customer Quotation been generated.

Hi Wangoru,

Forgot one modification. At the Delivery Note section, the substitute part no, should replace the item code. As the shipping authorities will look only at the items that are being shipped off, they won't care what was the original part number from the customer and so forth.

Can we do a script, that when the delivery note is generated from a Sales Order, the Substituted Part number (if there is any), automatically replaces the Item Code. This should also work for uploaded files, especially at the delivery note stage.

Just like how we have the Unquoted Items in the Supplier Quotation, we need to have the Unquoted Items in the Customer Quotation.

So basically Customer Quotation will be compared to the RFQ.

Here is another minor or major issue, I am not sure. So lets say we have added a price list to Supplier Quotation SQ-0001, using pricing list PL001. Now I want to add or change the prices for Item ABC. If I upload the Supplier Quotation again, it is not be updated in the price list, the price list value yet stays the same. Instead I have to create an entirely new price list PL002 and upload information into that.

• Date is not formatted correctly, appearing as a row of digits instead of DD/MM/YYYY
• Total and Grand Total should have $ before the values
• Serial No is yet missing in the Excel Spreadsheet.

Received/Delivered Qty and Balance qty fields to display Purchase order and Sales order. This is important, so that we can track what is pending, and what has been delivered (via Delivery Note). The main doc to be compared against should be the Sales Order (because that is the final document without any modifications)

We need the make function to connect the Supplier Quotation with the Customer Quotation. Reason being is that the prices for the Customer Quotation is being taken from the price lists + pricing rules.

So lets take Al Futtaim for example, as a supplier they offer a 25% discount on the list price. Now when we try quoting for another customer, let's say we put 10% margin on the quotation, the pricing information should be taken from the supplier quotation (i.e. with 25% discount) and a margin added on top of that with 10% margin.

Right now, it works by taking the price list and adding the margin on top of the price list (the pricing rules for the discount is not being applied.

Either that, or have an option to attach unquoted items seperately as an option:

You could have two options:

Attach Excel Spreadsheet - Change to Attach Excel Quotation
Attach Unquoted Items

Change the Payment Request Name to Proforma Invoice.

And add the down-payment percentage field, show only the down-payment percentage as calculated from the total price.

Delivery Note - Against Sales Order, Warehouse

Just a question, and I am sure there is something in the Vanilla ERP.

Just like how I am comparing the Delivery Order Quantity with the amounts in the Delivery Receipts, shouldn't the same functionality be in Purchase Order and Purchase Receipts? Either that or I am not using the right report.

Could you point me to the right report to use for this function.

https://discuss.erpnext.com/t/how-to-make-customer-issue-from-customer-form/4719

This might be useful to do, once we have completed with everything.

Sales Order screen, dropdown from make button is for Purchase Order. Similar request was raised in a previous request.

I know we discussed using the change header field, but the client feels that it is a bit too technical and wants to make it easier. So after Sales Order, the next step would be to create a Proforma Invoice (there is no need of an excel file here, as it would just be PDF). Exact same as the Proforma Invoice is right now with the down payment amount field.

Please review these odd errors. The fields were in the CSV files, but for some reason not being detected.

Item Name should be kept default in all Filter Screens, and the client wants to know how they can seamlessly search for multiple Item Names, instead of a single item name.

When we are sending only one document, it works perfectly fine. But if we are trying to send multiple documents (Excel Spreadsheet, Unquoted Items for Example, it doesn't work at all.

This is critical.

This button is already there. Now if we are getting new items from the Purchase Order (after creating New Supplier Quotation), the items are not being populated, but it the Supplier Name is being populated.

Emails work when using PDF attachment with Unquoted Excel file (or any other attachments), but do not work, when we use the Excel quotation

Reason being is that the Excel files are getting Added and Removed automatically. Please see the attached screenshot

"Get new Items" in new Purchase order screen, customer quotaion, sales order to be added (For the Item Population)

Please review this odd error because of decimal places, it halts the entire process.

For the moment, the Price List is not updated from the uploaded Quotation File, or doesn't create a new price list based on the quotation. The problem here is that we cannot use the main Item Price List, because there might be different prices quoted in different quotations for the same Item Number.

This is very important, because we could have the user change the date. My suggestion is to make the date non mandatory, and the system should fill the date automatically (not allow before and after dates)