bandirom / django-template Goto Github PK

According to compose file specification, the version attribute become deprecated and should not be included in Compose file implementations.

Here is an example of affected code:

version: "3.7"

x-variables: &variables
  ENV_STAGE: local

services:
  web:
  ...

Pull request with all version attributes removed is attached.
#32

According to modern best practices and PEP-517, Python projects should contain pyproject.toml file at the root of project, which contains build system requirements and configuration for other tools, like linters, tests and etc. Also, defining setup.cfg is a good way to create declarative config and specify all dependencies and metadata.
The usage of both pyproject.toml and setup.cfg simplifies project building and installation in editable mode for different environments using extras options.

Also, it is a best practice to separate tests code and source code using different directories art the root. In such case, it's easy to store and use different types of tests (e2e, integration, unit, etc.) at one place.

In addition to these project structure upgrades, packages installation to to specific directory and copying this content to /usr/bin/ of final layer of image could lead to misbehaviour of entrypoints of installed packages. In order to build python packages in one layer and install them in final, pip wheel should be used to create binaries of dependencies and pip install --no-index --find-links=<wheels_path> to install that binaries in final layer.

Pull request with all suggested enhancements and fixes is attached: #34