Giter VIP home page Giter VIP logo

spiralmatrixsharp's People

Contributors

bangjunyoung avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar

Forkers

zahidsqldba07

spiralmatrixsharp's Issues

Function `ofArray` not used.

It seems that function ofArray in src/SpiralMatrixSharp/FSharp.fs is not used. Regardless of that, a rectangular array does not spread elements in correct order.

// It fails with expected output: [| [|3;4|]; [|7;8|]; [|0;0|]; [|0;0|] |]
[<Fact>]
let ``Test ofArray function`` () =
    let output = [| [|1;2|]; [|3;4|]; [|5;6|]; [|7;8|] |] |> array2D
    Assert.Equal(output, Array2D.ofArray 4 2 [|1..8|])

I think array should be a square one, so better to accept an argument and check it, like:

let ofArray (side: int) source =
    if Array.length source <> pown side 2 then
        invalidArg "source" "must be a square array"

    let array2D = Array2D.zeroCreate side side
    source
    |> Array.iteri (fun i elem -> array2D.[i / side, i % side] <- elem)

    array2D

with test:

[<Fact>]
let ``Test ofArray function`` () =
    let expected = [| [|1;2;3|]; [|4;5;6|]; [|7;8;9|] |] |> array2D   
    Assert.Equal(expected, Array2D.ofArray 3 [|1..9|])

    Assert.Throws<System.ArgumentException>(
        fun () -> Array2D.ofArray 3 [|1..7|] |> ignore) 
    |> ignore

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.