Giter VIP home page Giter VIP logo

cancancan_issue's Introduction

Cancancan Security issue

Steps to reproduce:

  1. Clone the repo git clone https://github.com/barttenbrinke/cancancan_issue.git
  2. Run bundle install
  3. Run rails db:migrate
  4. Open http://localhost:3000/working_documents_controller/new
  5. You should get a CanCan::AccessDenied exception, as cancancan checks can?(:new, Document) and you are not allowed in.
  6. Open http://localhost:3000/broken_documents_controller/new
  7. You should get a CanCan::AccessDenied exception, however cancancan just checks can?(:read, Document) and you are allowed to continue.

The Working Documents controller has:

class WorkingDocumentsController < ApplicationController
  authorize_resource class: Document

The Broken Documents controller has:

class BrokenDocumentsController < ApplicationController
  authorize_resource :document

Ability has:

class Ability
  include CanCan::Ability

  def initialize(session)
    can :read, Document
  end
end

I believe this is a bug and a security issue.

cancancan_issue's People

Watchers

 avatar  avatar  avatar

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.