basssiiie / openrct2-parkratinginspector Goto Github PK

Describe the bug
On the latest stable version (0.3.5.1) the plugin does not work, and throws an error in the console.

To reproduce
Steps to reproduce the behavior:

1. Download the latest Linux .AppImage (version 0.3.5.1)
2. Install the plugin
3. Start a new scenario or load a save game
4. Try to open the plugin
5. Plugin does not open

Expected behavior
The plugin should open and work

Screenshots
Rather than screenshots, have this console output. I compiled my own version so it shows a stack trace, but normally it only shows the first line:

[ParkRatingInspector] TypeError: undefined not callable (property 'parseInt' of [object Function])
   -> i(): line 58
   -> <anonymous>: line 31
   -> <anonymous>: line 39
   -> <anonymous>: line 364
   -> W(): line 501
   -> <anonymous>: line 520
   -> <anonymous>: line 531
   -> window(): line 801
   -> <anonymous>: line 802

The (non-minified) relevant code is:

    function i(s, c, h) {
        if (void 0 === c && (c = 0), void 0 === h && (h = 0), void 0 === s) return [ c, h ];
        if ('number' == typeof s) return [ s, 2 ];
        var l = s.trim(), f = l.length;
        if (f > 1) {
            var v = f - 1, y = void 0, x = l[v];
            if ('w' === x ? y = 2 : '%' === x ? y = 1 : f > 2 && (v = f - 2, 'x' === x && 'p' === l[v] && (y = 0)),
            void 0 !== y) return [ Number.parseInt(l.substring(0, v)), y ];
        }
        throw new Error('Value \'' + s + '\' is not a valid scale.');
    }

The Number.parseInt statement is what causes the error. This seems to originate from "openrct2-fluentui", and the line in question was very recently touched by you in Basssiiie/OpenRCT2-FlexUI@524d9ab .

Are we missing some kind of bugfix, or update for this dependency?

Describe the bug
Upon loading a park, OpenRCT2 outputs this error message:

Failed to load plug-in script: Error: Invalid entity type.

To reproduce

1. Install the latest OpenRCT2 (0.3.4.1)
2. Install ParkRatingInspector
3. Run openrct2.com
4. Start a new scenario
5. ParkRatingInspector is not loaded
6. See the output from openrct2.com

Expected behavior
The plugin should load and work.

Notes
I suspect this is due to changes to the "peep", "guest", and "staff" entity types.

WrongRating.zip

Park rating shown in UI: 0

Park rating shown in inspector: ~900-something