Disable italics about solarized-emacs HOT 11 CLOSED

Maybe, some kind of test implementation of an idea for #18 has begun.. This is a feature related to one of those mentioned somewhere in that ticket. Or at least at a basic level maybe would require the same kind of functionality. I am interested in providing some klnd of "feature sets" which this is some kind of.

from solarized-emacs.

I also feel we're making too much use of italics and maybe should tone them down a bit. At least in the default font-lock faces. I'll probably adjust those soon.

from solarized-emacs.

About note about this ongong bold vs. italic battle...
Using some fonts italic looks way better than bold in situations where a light emphasis might be wanted instead of heavy.
Maybe time to introduce a defcustom for this? Ive been wanting to define which defs are bases for other ones,. this could be a first step to a system like that.

from solarized-emacs.

Not sure how we'll decide which faces the defcustom(s) would apply to. Maybe you should explain your idea in more detail?

from solarized-emacs.

It would have to be decided for each instance where italics are used..
I feel that the reason why you and other people don't prefer italics is because it feels more intrusive than even bold which typography-wise using great fonts might not always is the case.
For me, with my favourite fonts, switchig from/to bold all the time is way more intrusive for reading.
The defcustom would be something like solarized-italics-emphasis and would mostly replace instances of bold and maybe in rare cases introduce italic where bold is not used at all.

These basic font-lock faces are a perfect candidate for this, it will maybe even only be used there.

from solarized-emacs.

I generally try to keep the default solarized true to the Emacs canon - Emacs themes rarely make use of italics for the core font-locking (for historical reasons - italics used to suck in the past). Never-the-less - your suggestion is sound and I guess it makes sense to implement it.

Alternatively instead of using a defcustom we can have alternative variants of the theme - solarized-dark-italics or something like that.
Btw, the current theme generation logic is flawed since instead of producing the code for the theme it actually applies the theme faces. create-solarized-theme should probably be a macro to avoid the current problem as noted in #70. Please, rework it when you have the time.

from solarized-emacs.

About the generation logic I generally like much more how the sellout-solarized emacs is strucutred.
About the italics I might want to have more options in the future so defcustoms are more dynamic and combineable.
The sellout theme for instance has an option to completely disable both bold and/or italics.

from solarized-emacs.

altough the sellout way is limited in that it only generate defs for one color class at a time (like we do).. I have referneced a lot of this stuff in #18

from solarized-emacs.

The problem is not the structure of the code, the problem is that we're not only generating the theme - but we're applying it as well... And this is pretty annoying if you're upgrading your packages, you have solarized installed, but it's not currently the theme your using - when solarized is updated it will make solarized light your current theme. I guess you're not using package.el and I'm not sure if you understand the problem with the existing code.

from solarized-emacs.

Noi, I dont use package.el but I understand what #70 is about .. I was just referring to other issues related to the generation of the theme. Without generating all color class defs at once emacsclient support will not happen in a good way.

from solarized-emacs.

its actually the main reason that I dont use emacsclient at all.

from solarized-emacs.