Giter VIP home page Giter VIP logo

Comments (14)

thomasf avatar thomasf commented on May 26, 2024

Altight

from solarized-emacs.

thomasf avatar thomasf commented on May 26, 2024

I like the current soft look very much.. you can always create a child theme

from solarized-emacs.

bbatsov avatar bbatsov commented on May 26, 2024

The active mode-line and the inactive mode-line have different backgrounds even now. This makes distinguishing between the too fairly easy IMO.

from solarized-emacs.

oscarfv avatar oscarfv commented on May 26, 2024

For the active mode-line there is indeed a lighter background, but the inactive mode-line is hard to locate. See the attached screen capture.
snapshot3

IMO the thin box that encloses the inactive mode-line is not enough of a clue to avoid confusing it with the rest of the text. OTOH, I agree with @thomasf about the soft look, is is nice and relaxing. So I don't know what's the best thing to do here... maybe a darker background for the inactive mode-line (active -> lighter, inactive -> darker)

from solarized-emacs.

thomasf avatar thomasf commented on May 26, 2024

I changed the inactive mode line it use an underline instead of box but with a more visible color instead..
Is this visible enough?

from solarized-emacs.

oscarfv avatar oscarfv commented on May 26, 2024

IMHO, it is too visible (too bright) and at the same time it doesn't help enough to visually separate the stacked buffers.

Other than using an (slightly) different background (like you already do for the active mode-line) resorting to text attributes doesn't seem enough, because those effects are often used on some modes for displaying buffer contents.

from solarized-emacs.

vspinu avatar vspinu commented on May 26, 2024

Isn't this a relatively recent change? For years mode-line was perfect. Now (40ff12a) the inactive mode-line is indistinguishable.

I might be confused, but wasn't there a mode-line border before? Now border is missing.

modeline

from solarized-emacs.

vspinu avatar vspinu commented on May 26, 2024

Indeed. Reverting 618e36f puts the border back. I think it was good before. New users might find solarised mode-line a bit obscured, but I think it is a good and subtle design which makes this particular theme very balanced. If I could vote, I would vote for potting border back and making things as before.

On a more general note, given that this theme is there for quite some time and many people are very used to it, I think such radical changes should be made in a bit more careful manner.

from solarized-emacs.

thomasf avatar thomasf commented on May 26, 2024

I agree about reverting this, will do it soon unless someone has an better suggestion.

from solarized-emacs.

oscarfv avatar oscarfv commented on May 26, 2024

Thomas Frössman [email protected] writes:

I agree about reverting this, will do it soon unless someone has an
better suggestion.

Just as solarized uses a lighter background for the active modeline, I
suggest a darker background for the inactive modeline.

from solarized-emacs.

bradwright avatar bradwright commented on May 26, 2024

The main issue with the contrast is that the active mode is roughly the same contrast (and perhaps colour) as the hl-line-mode background. Which is a bit confusing.

from solarized-emacs.

thomasf avatar thomasf commented on May 26, 2024

bradleywright: I know.. I think we should move this into a custoizable option for low/high contrast modeline.. Even if stuff looks more or less the same as it is now I still prefer it to the heavier looking bg/fg inverse way.

from solarized-emacs.

thomasf avatar thomasf commented on May 26, 2024

I have added an option for this now

from solarized-emacs.

oscarfv avatar oscarfv commented on May 26, 2024

Looks good. Thanks!

from solarized-emacs.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.