Light

bbc / alephant-cache Goto Github PK

View Code? Open in Web Editor NEW

3.0 25.0 1.0 20 KB

Simple abstraction layer over S3 for get/put.

alephant-cache's Issues

Return the s3 object instead of subset of objects properties

Issue

Currently the get method returns a hash with the content_type and content:

    def get(id)
      logger.info("Cache.get: #{path}/#{id}")
      object = bucket.objects["#{path}/#{id}"]

      {
        :content      => object.read,
        :content_type => object.content_type
      }
    end

Proposal

this isn't very flexible when we need to get other properties out of the s3 object, so it make sense to just return the object:

    def get(id)
      logger.info("Cache.get: #{path}/#{id}")
      bucket.objects["#{path}/#{id}"]
    end

Alternatively we could just add the metadata to the hash that's returned and keep the abstraction:

    def get(id)
      logger.info("Cache.get: #{path}/#{id}")
      object = bucket.objects["#{path}/#{id}"]

      {
        :content           => object.read,
        :content_type      => object.content_type,
        :meta              => object.metadata.to_h
      }
    end

Gem Naming

Calling this Alephant::Cache is confusing seeing it has little to do with caching. A better name would be:

Alephant::S3
Alephant::Storage

Recommend Projects

React

A declarative, efficient, and flexible JavaScript library for building user interfaces.
Vue.js

🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
Typescript

TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
TensorFlow

An Open Source Machine Learning Framework for Everyone
Django

The Web framework for perfectionists with deadlines.
Laravel

A PHP framework for web artisans
D3

Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

javascript

JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
web

Some thing interesting about web. New door for the world.
server

A server is a program made to process requests and deliver data to clients.
Machine learning

Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
Visualization

Some thing interesting about visualization, use data art
Game

Some thing interesting about game, make everyone happy.

Recommend Org

Facebook

We are working to build community through open source technology. NB: members must have two-factor auth.
Microsoft

Open source projects and samples from Microsoft.
Google

Google ❤️ Open Source for everyone.
Alibaba

Alibaba Open Source for everyone
D3

Data-Driven Documents codes.
Tencent

China tencent open source team.