bbottema / gulp-js-base64-inject Goto Github PK

When image gets injected into src, src string is incorrect:

image/png;base64,...
// should be
data:image/png;base64,i...

If you pre-pend "data:" to base64 strings, that fixes the problem. Pull request #2 fixes that.
If you can kindly merge PR#2 and push to NPM that would be great.

Hi, thank you for a useful gulp plugin.
There is a bug. This line:

var filecontents = mime.lookup(filepath) + ';base64,' + fs.readFileSync(filepath).toString('base64');

should read like this:

var filecontents = mime.lookup(filepath) + ';base64,' + fs.readFileSync(fp).toString('base64');

Otherwise fs.readFileSync() errors out with "unable to read utf8 file".