Giter VIP home page Giter VIP logo

whatsapp-desktop's People

Contributors

afro1114 avatar ann0nip avatar bcalik avatar bpartridge avatar championswimmer avatar enrico204 avatar imsys avatar mariovillani avatar mathsalmi avatar neyaoz avatar nyancrimew avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

whatsapp-desktop's Issues

Mac - clarifying all keyboard shortcuts?

Unclear that keyboard shortcuts like command+f exist (other than from release notes). Worth adding to the Edit menu, along with any other undocumented shortcuts?

Other nice keyboard shortcuts used by BetterChat on the app store are command+n for new messages, shift+command+n for new audio messages, and command+g for new group.

Those small changes along with the bug in search would make this best-in-class I believe.

deb package

Hi @bcalik,

I am not sure whether you have seen my comment.

Do you plan on releasing an Ubuntu deb package for your version?

Is there any way I can help you with that?

Thankfully,

Robert

White screen

Anyone had the same problem? Just white screen, nothing is loaded into the screen.
screen shot 2015-08-27 at 9 29 50 am

The App screen is blank from start.

Running the latest release on OS X 10.11.1.
screen shot 2015-10-30 at 4 59 54 pm

Deleted
~/Library/Preferences/com.electron.whatsapp.plist (not sure of the name of the file here now, since i've already deleted the file).
and
~/Library/Application\ Support/whatsapp

But, still the issue remains.

App not closing right on Windows

Been using this app for 2 days and I've noticed that it doesn't close the way it should. Electron keeps running in the background and the systemtray icon doesn't go away either. Launching another session of the app doesn't fix this, it just add another instance of Electron to the running processes and adds another systemtray icon.

Edit: I've noticed that the app launches 2 instances of Electron to begin with.

The Icon in the System Tray doesnt go away.

Good Evening,
After Closing Whatsapp-Desktop, the Icon in the System Tray doesnt go away. When I click on it it says :
image
Wanted behavior: make the thing disappear after closing Whatsapp-Desktop.
After opening and closing n times Whatsapp-Desktop i have n Icons spamming my System Tray.
image
OS: ArchLinux (64bit) with kde-plasma, Whatsapp-Desktop downloaded from the AUR with pkgbuilder

npm run build doesn't work on Windows 10

I did what the page told me, just
git clone https://github.com/bcalik/Whatsapp-Desktop.git
cd WhatsApp-Desktop
npm install
npm run build
and this error appears

==================================
npm-debug.log

0 info it worked if it ends with ok
1 verbose cli [ 'C:\\Program Files\\nodejs\\node.exe',
1 verbose cli   'C:\\Program Files\\nodejs\\node_modules\\npm\\bin\\npm-cli.js',
1 verbose cli   'run',
1 verbose cli   'build' ]
2 info using [email protected]
3 info using [email protected]
4 verbose run-script [ 'prebuild', 'build', 'postbuild' ]
5 info lifecycle [email protected]~prebuild: [email protected]
6 silly lifecycle [email protected]~prebuild: no script for prebuild, continuing
7 info lifecycle [email protected]~build: [email protected]
8 verbose lifecycle [email protected]~build: unsafe-perm in lifecycle true
9 verbose lifecycle [email protected]~build: PATH: C:\Program Files\nodejs\node_modules\npm\bin\node-gyp-bin;C:\Users\ramm\Desktop\Whatsapp-Desktop-master\node_modules\.bin;C:\ProgramData\Oracle\Java\javapath;C:\Program Files (x86)\Intel\iCLS Client\;C:\Program Files\Intel\iCLS Client\;C:\Windows\system32;C:\Windows;C:\Windows\System32\Wbem;C:\Windows\System32\WindowsPowerShell\v1.0\;C:\Program Files\Intel\Intel(R) Management Engine Components\DAL;C:\Program Files\Intel\Intel(R) Management Engine Components\IPT;C:\Program Files (x86)\Intel\Intel(R) Management Engine Components\DAL;C:\Program Files (x86)\Intel\Intel(R) Management Engine Components\IPT;C:\Program Files\Microsoft SQL Server\130\Tools\Binn\;C:\Program Files\dotnet\;C:\Program Files\nodejs\;C:\Users\ramm\AppData\Local\Microsoft\WindowsApps;C:\Program Files (x86)\Microsoft VS Code\bin;C:\Program Files\Python36;C:\Program Files\Python36\Scripts;C:\Program Files\Java\jdk1.8.0_131\bin;C:\Users\ramm\AppData\Roaming\npm;
10 verbose lifecycle [email protected]~build: CWD: C:\Users\ramm\Desktop\Whatsapp-Desktop-master
11 silly lifecycle [email protected]~build: Args: [ '/d /s /c',
11 silly lifecycle   'npm run clean && npm run build:osx && npm run build:win && npm run build:linux' ]
12 silly lifecycle [email protected]~build: Returned: code: 1  signal: null
13 info lifecycle [email protected]~build: Failed to exec build script
14 verbose stack Error: [email protected] build: `npm run clean && npm run build:osx && npm run build:win && npm run build:linux`
14 verbose stack Exit status 1
14 verbose stack     at EventEmitter.<anonymous> (C:\Program Files\nodejs\node_modules\npm\lib\utils\lifecycle.js:255:16)
14 verbose stack     at emitTwo (events.js:106:13)
14 verbose stack     at EventEmitter.emit (events.js:191:7)
14 verbose stack     at ChildProcess.<anonymous> (C:\Program Files\nodejs\node_modules\npm\lib\utils\spawn.js:40:14)
14 verbose stack     at emitTwo (events.js:106:13)
14 verbose stack     at ChildProcess.emit (events.js:191:7)
14 verbose stack     at maybeClose (internal/child_process.js:891:16)
14 verbose stack     at Process.ChildProcess._handle.onexit (internal/child_process.js:226:5)
15 verbose pkgid [email protected]
16 verbose cwd C:\Users\ramm\Desktop\Whatsapp-Desktop-master
17 error Windows_NT 10.0.15063
18 error argv "C:\\Program Files\\nodejs\\node.exe" "C:\\Program Files\\nodejs\\node_modules\\npm\\bin\\npm-cli.js" "run" "build"
19 error node v6.11.0
20 error npm  v3.10.10
21 error code ELIFECYCLE
22 error [email protected] build: `npm run clean && npm run build:osx && npm run build:win && npm run build:linux`
22 error Exit status 1
23 error Failed at the [email protected] build script 'npm run clean && npm run build:osx && npm run build:win && npm run build:linux'.
23 error Make sure you have the latest version of node.js and npm installed.
23 error If you do, this is most likely a problem with the whatsapp-desktop package,
23 error not with npm itself.
23 error Tell the author that this fails on your system:
23 error     npm run clean && npm run build:osx && npm run build:win && npm run build:linux
23 error You can get information on how to open an issue for this project with:
23 error     npm bugs whatsapp-desktop
23 error Or if that isn't available, you can get their info via:
23 error     npm owner ls whatsapp-desktop
23 error There is likely additional logging output above.
24 verbose exit [ 1, true ]

I have the latest versions of node.js, npm and electron

Tray icon doesn't restore app's window

If you're using the app and close it's window it goes to the system's tray as shown here:

screenshot from 2016-05-07 21-29-35

But if you click on the icon instead of restoring the app's window you get this error:

screenshot from 2016-05-07 21-30-20

And the process is still shown as running:

screenshot from 2016-05-07 21-36-14

I'm running Debian testing x64 with GNOME.

demo screenshot

It would be nice to have a screenshot of the app in the README.md.

A click on the notification should maximize the chat window (Mac)

I noticed that when I close or minimize the window into the dock, a notification still appears and when I click on it, it´ll will also bring me to the main desktop, but it won´t maximize the window.
It´s not critical, but it requires an additional action which can be a little bit annoying when you use it a lot (which I do right now).

Whatsapp app shows the desktop as Mac Version

I have found out that this wrapper was done using electron wrapper, and after checking the connections my whatsapp has i have seen that the application shows the desktop connection as if it was connected using the Mac version while using the original web version shows the correct OS name which in my case is Debian Ubuntu

How to run?

The Whatsapp.app "file" is a folder. What in there am I supposed to run? I'm on an Ubuntu 14.04.

Security: executing external malicious node.js code

Hi, there. I may say that my reasoning could be wrong, I've not checked it, but I think there could be an invisible privilege escalation security issue with this Electron app.
This could be caused with third-party remote JS code, like WhatsApp code or any CDN libraries without the user notice.

Basically, the app fetches some unknown JS code and execute it in the node.js runtime instead of a normal browser JS runtime (Spidermonkey, V8), meaning that it has access to node.js IO (filesystem) and other potentially risky modules.

The solution may consist in execute the webpage in some kind of isolated sandbox, from which the JS code can't have any access to node.js capabilities.

Any real implementation for this? First step may be check Electron configs or some npm modules.

Close Button

As OS X default the close button shouldn't quit the application - in my opinion ;)

What's the license of the project?

The license is needed in order to get the packaging done on some linux distro... I assume it's MIT?
also if you can add the license on github it would be better :)

Send Image Console Browser

Hello personal , all right?
I'm trying to accomplish sending images by browser cosole and I'm CORS (Cross Domain) problems. Does anyone know how I can do this ?

The following sample code:

var imageURL ="http://www.mydomain.com/image.jpg";
var canvas = document.createElement('canvas');
var context = canvas.getContext('2d');
var image = new Image();
image.setAttribute('crossorigin', 'anonymous');
image.onload = function () {
canvas.width = image.width;
canvas.height = image.height;
context.drawImage(image, 0, 0, image.width, image.height);
canvas.width(function (blob) {
var event = new Event('drop');
var uri = new URI(imageURL);
var file = new File([blob], 'upload.' + uri.path.substr(uri.path.lastIndexOf('.') + 1), {type: 'image/' + (uri.path.substr(uri.path.lastIndexOf('.') + 1))});

});

};
image.src = imageURL;

Best regards .

Linux executable

Ubuntu 14.04 64 bits

I have added the following lines to package.json:

...
    "clean:linux": "rm -rf ./dist/linux",
...
    "build:linux": "npm run clean:linux && electron-packager ./app \"Whatsapp\" --out=dist/linux --platform=linux --arch=x64 --version=0.30.0"
...

It creates the files correctly but when I execute, it opens a borderless window:
20150805_17 23 23_01

and it doesn't show any icon in Unity launcher:
20150805_17 25 33_01

Javascript error

capture

run the whatapp executable binary after I unzip, and I get this error message. I could still proceed though.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.