bchadwic / gh-cli Goto Github PK

Describe the bug

To create line number navigation more efficient and more standard use "main.go:32" instead of a flag --line 32

Expected vs actual behavior

From "gh browse "main.go" --line 32"
To "gh browse "main.go:32"

1. Send a request to the GH api and see if you receive a 404
2. if no 404 is found, return true as a function

function name ideas:

• validPageRequest()

I think we should consider making the exitCode start at the top as successful, then if it reaches any point where the command is unsuccessful, we can change the variable. That way at the end, we just have to check if the exitCode is successful, if so open the browser and print the success message, if not, print the error message and return. This reduces the amount of locations calling exitPrint to two locations in the main run function

Create a list of flags and determine whether or not a correct flag was passed in.

Describe the bug

Two considerations for solutions

1. Make sure branch takes two arguments
2. If branch only has one arg, consider opening that branch in the browser w/o file

gh browse --branch "actions-demo"

Describe the bug

Make sure we don't prohibit users from reaching a site because we got an false positive on the 404 checker function. This includes limiting the 404 checker to exclusively issues and pr args.

Testing on a forked repo

Missing examples
Missing arg usage
Missing a -R repo directory

To print out errors, use fmt.ErrorfF, return errors.New

Replace Run with RunE

Change print statements to fmt.ErrorF();

Get rid of the checkmarks and x's from the print statements

remove all unnecessary comments

Understand how arguments are passed through the cli

1. look into making a ViewOptions struct
2. using a struct or strictly parsing, work on concatenating it to the url to open in browser

Finished example:
gh browse "main.go" || main.go?

Still considering quotes or not