bcoin-org / bclient Goto Github PK

It would be really convenient if bcoin-cli printed off the environmental variables that it works with after running something like:

$ bcoin-cli help

Because of this line:
https://github.com/bcoin-org/bclient/blob/master/bin/bwallet-cli#L278
...for any send using bwallet-cli send the value is interpreted as WHOLE BTC and is exponentiated by ^8 to get a satoshis value, which is then sent to the actual wallet for composing a transaction.

This is VERY DIFFERENT from using curl:
https://github.com/bcoin-org/bcoin/blob/c7d844ea3785c939cd546ce2fe7ff0e03f27197a/lib/wallet/http.js#L450
...where the value is interpreted literally as satoshis. This is the same behavior when using the Javascript WalletClient from bclient

Currently the documentation does not distinguish between the two formats:
http://localhost:4567/?shell--cli#send-a-transaction

So, when sending a value=1000 from cURL or from Javascript WalletClient, you will send 0.00001000 BTC. If you send the same value=1000 from bwallet-cli you will send 1,000 BTC (1000.00000000) !!

Hi there,

I am currently using bcoin in a large scale application and now looking into this wallet rewrite. I am concerned about watching thousands of wallet and the performances problems of having thousands of web sockets connection on the same process.

It seems like the bcurl’s client is not bound to a specific wallet, so we don’t need to have one instance for every wallet (today by inheritance). Instead, we could share one instance, so it also share the web socket connection in same process.

This way, each wallet ask client to register to a wallet id, then the client will receive events for every wallets. It could re-dispatch these events with wallet id in name of event, so each wallet only get event that is is destined to.

socket.on(‘wallet tx’) => this.emit('wallet:walletId tx’)

Do you think this is envisageable ?

Version
bclient v0.1.1

Expected

./bin/bwallet-cli --network="regtest"
  ...
  $ account get [account-name]: Get account details.
  $ address [account-name]: Derive new address.
  $ change: Derive new change address.
  ...

Actual

./bin/bwallet-cli --network="regtest"
  ...
  $ account get [account-name]: Get account details.
  $ address: Derive new address.
  $ change: Derive new change address.
  ...

Reproduce

Does not work:

./bin/bwallet-cli --network="regtest" address

Works:

./bin/bwallet-cli --network="regtest" address "default"

It appears that NodeClient and WalletClient are designed to communicate with servers, since they're subclasses of bcurl's Client.

To test these two modules, should we require bcoin as a dependency and launch its server during testing or should we create a dummy/ephemeral server to use during testing?