beamanator / rips-validation-cext Goto Github PK

Version 0.1.3 prevents attendance notes from being saved in "Add action" - NOT GOOD

Clients can be created or 'saved' (on CBI) with invalid data. Warnings will pop up when data is entered incorrectly, but form submission is not prevented!!

Only one name should go in First Name box, all other names go in Surname.

Should I automatically edit names, or pop up a warning for people? Probably can be automatic.

Currently when v0.1.3 is enabled, clicking delete button makes the page refresh but doesn't pop up the swal error saying the client was deleted - probably because of the submit listeners

I'm still not clear what these values are used for, and they probably should be hidden. Some more analysis should be done before completely removing them :)

Want to know how many times Archive is being hit, and maybe who is doing it - send it to my email address?

An employee found that an input box has been hidden when the value is set to 9 because of this css selector. The selector should only match the vulnerability checkbox + label

Right now we always add a 0 when phone number is 9 characters. This isn't useful when the first character is 0 because this phone number is still invalid, but the extension accepts it.

Now we should error (and not add initial 0) when phone number is 9 numbers and first is a 0.

Disable save button that we hid! Right now it's not hidden so it's possible it can be clicked on accident (maybe) but it would be safer if it was disabled.

Each time someone clicks on a report (or actually runs the report), count it in Firebase

People keep giving me feedback that they can't follow the Extension Installation guide b/c it's not working. Often this is because people are trying to click on the screenshot in the google doc, instead of navigating to the tab with RIPS. This should be improved somehow.

Users aren't automatically adding Dependents / Vulnerabilities because 1) they aren't shown on the Registration page, and 2) they aren't shown automatically in CBI page.

Solutions:

1. Add to Registration page
2. Automatically show them on CBI page
3. Pop up a warning when a user goes to CBI, then another page when a client doesn't have dependents OR vulnerabilities filled out

Try to set up a link to client accounts from the relatives page - not necessarily needed for reporting or anything, but it would make it easier to access related clients probably

Columns that should probably be hidden:
Note?
Major Action?

In Firebase: Somehow found that the 'unknown' user is saying the last login date is TOMORROW, and the count is 5, as of today. This SHOULD NOT BE POSSIBLE since this was implemented only recently.

All data with real usernames looks good - last login is today or in the past, and login count is max of 2 or 3.

Specifically, improve view manipulator files. Suggested edit:

1. Make individual view controllers for each page
2. each controller can call its own specific view manipulator function in a general view manipulator utils file

This is not a bug with the validation extension, but with RIPS itself. I should fix this issue w/ the extension so that the issue can be fixed now!

International #s can start with +2 or +20 - right now this extension will probably strip the + automatically, then tell you the number is invalid because it will most likely start with a non-zero digit.

This can be better!

Or make it slightly less easy to see for now - then hide it once we confirm nobody is using it.

Automatically set caseworker dropdowns (on Add Actions and Services) pages to the logged-in user. If user is not a caseworker, don't worry. Just don't select anything.

When RIPS times out, saving a page causes RIPS to log out, so all of the data is lost. This is needed for the following pages:
Add Action (high)
CBI (low)
Registration (low)

Examples: '<', '&', ' ', etc
these characters show up as HTML characters (&nsp, etc)

A while ago I (and some colleagues) discovered that sometimes when you add / remove Vulns and click "Save" quickly, the page reloads & shows the old data. This is pretty reproducible, so there definitely is a bug somewhere. For a while, I didn't mention anything because the devs were working on bigger issues, but now I thought it would be a good time to bring this one up again.

One workaround I found is:
$('form#postClntVulSubmit').removeAttr('action').removeAttr('method').removeAttr('novalidate') - removing the 'action', 'method', and 'novalidate' attributes from the form surrounding the vulnerability checkboxes. I told the devs, they will hopefully let me know later this week if they have a better solution.

When users log in to RIPS (hopefully right at the beginning), update their most recent log in date via the chrome extension

Purpose: track people who have installed the extension and from this, can tell who hasn't installed it.

Just in case another org wants to use the code, de-couple site-specific code.
Ex: Dependent & Vulnerability warnings

In CBI - hide "Delete" Button b/c currently ANYONE can delete... Babs says NOBODY should b able to (except me)

Similar - think about "Archiving" - who should be allowed, who shouldn't, etc.